From: Juergen Gross <jgross@suse.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, rusty@rustcorp.com.au
Cc: kozerkov@parallels.com, matt@codeblueprint.co.uk,
lv.zheng@intel.com, xen-devel@lists.xensource.com,
joro@8bytes.org, x86@kernel.org, robert.moore@intel.com,
linux-acpi@vger.kernel.org, glin@suse.com, lenb@kernel.org,
josh@joshtriplett.org, jlee@suse.com, lguest@lists.ozlabs.org,
boris.ostrovsky@oracle.com, andriy.shevchenko@linux.intel.com,
toshi.kani@hp.com, andrew.cooper3@citrix.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, luto@amacapital.net,
david.vrabel@citrix.com, tiwai@suse.de
Subject: Re: [Xen-devel] [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled()
Date: Mon, 11 Apr 2016 08:51:13 +0200 [thread overview]
Message-ID: <570B4961.6000703@suse.com> (raw)
In-Reply-To: <1460158825-13117-15-git-send-email-mcgrof@kernel.org>
On 09/04/16 01:40, Luis R. Rodriguez wrote:
> That that paravirt_enabled() is replaced with proper
> x86 semantics we can remove it.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
> arch/x86/include/asm/paravirt.h | 5 -----
> arch/x86/include/asm/paravirt_types.h | 1 -
> arch/x86/include/asm/processor.h | 1 -
> arch/x86/kernel/kvm.c | 8 --------
> arch/x86/kernel/paravirt.c | 1 -
> arch/x86/lguest/boot.c | 2 --
> arch/x86/xen/enlighten.c | 1 -
> 7 files changed, 19 deletions(-)
Xen parts:
Acked-by: Juergen Gross <jgross@suse.com>
Juergen
>
> diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
> index 6c7a4a192032..dff26bc91b17 100644
> --- a/arch/x86/include/asm/paravirt.h
> +++ b/arch/x86/include/asm/paravirt.h
> @@ -15,11 +15,6 @@
> #include <linux/cpumask.h>
> #include <asm/frame.h>
>
> -static inline int paravirt_enabled(void)
> -{
> - return pv_info.paravirt_enabled;
> -}
> -
> static inline void load_sp0(struct tss_struct *tss,
> struct thread_struct *thread)
> {
> diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
> index 6acc1b26cf40..7fedf24bd811 100644
> --- a/arch/x86/include/asm/paravirt_types.h
> +++ b/arch/x86/include/asm/paravirt_types.h
> @@ -69,7 +69,6 @@ struct pv_info {
> u16 extra_user_64bit_cs; /* __USER_CS if none */
> #endif
>
> - int paravirt_enabled;
> const char *name;
> };
>
> diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
> index 0c70c7daa6b8..8d326e822cb8 100644
> --- a/arch/x86/include/asm/processor.h
> +++ b/arch/x86/include/asm/processor.h
> @@ -473,7 +473,6 @@ static inline unsigned long current_top_of_stack(void)
> #include <asm/paravirt.h>
> #else
> #define __cpuid native_cpuid
> -#define paravirt_enabled() 0
>
> static inline void load_sp0(struct tss_struct *tss,
> struct thread_struct *thread)
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index dc1207e2f193..eea2a6f72b31 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -285,14 +285,6 @@ static void __init paravirt_ops_setup(void)
> {
> pv_info.name = "KVM";
>
> - /*
> - * KVM isn't paravirt in the sense of paravirt_enabled. A KVM
> - * guest kernel works like a bare metal kernel with additional
> - * features, and paravirt_enabled is about features that are
> - * missing.
> - */
> - pv_info.paravirt_enabled = 0;
> -
> if (kvm_para_has_feature(KVM_FEATURE_NOP_IO_DELAY))
> pv_cpu_ops.io_delay = kvm_io_delay;
>
> diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
> index f08ac28b8136..71a2d8a05a66 100644
> --- a/arch/x86/kernel/paravirt.c
> +++ b/arch/x86/kernel/paravirt.c
> @@ -294,7 +294,6 @@ enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
>
> struct pv_info pv_info = {
> .name = "bare hardware",
> - .paravirt_enabled = 0,
> .kernel_rpl = 0,
> .shared_kernel_pmd = 1, /* Only used when CONFIG_X86_PAE is set */
>
> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> index f5497ee5fd2f..3847e736702e 100644
> --- a/arch/x86/lguest/boot.c
> +++ b/arch/x86/lguest/boot.c
> @@ -1408,8 +1408,6 @@ __init void lguest_init(void)
> {
> /* We're under lguest. */
> pv_info.name = "lguest";
> - /* Paravirt is enabled. */
> - pv_info.paravirt_enabled = 1;
> /* We're running at privilege level 1, not 0 as normal. */
> pv_info.kernel_rpl = 1;
> /* Everyone except Xen runs with this set. */
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index e066fcf87c3d..7c1da39623f4 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1186,7 +1186,6 @@ static unsigned xen_patch(u8 type, u16 clobbers, void *insnbuf,
> }
>
> static const struct pv_info xen_info __initconst = {
> - .paravirt_enabled = 1,
> .shared_kernel_pmd = 0,
>
> #ifdef CONFIG_X86_64
>
next prev parent reply other threads:[~2016-04-11 6:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 23:40 [PATCH v5 00/14] x86: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-04-13 8:01 ` Ingo Molnar
2016-04-13 15:17 ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 03/14] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-11 6:50 ` [Xen-devel] " Juergen Gross
2016-04-12 20:50 ` Luis R. Rodriguez
2016-04-13 22:49 ` Luis R. Rodriguez
2016-04-11 13:49 ` Boris Ostrovsky
2016-04-12 20:56 ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 06/14] x86/init: use a platform legacy quirk for ebda Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 08/14] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 11/14] pnpbios: replace paravirt_enabled() check with legacy device check Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 12/14] x86, ACPI: parse ACPI_FADT_LEGACY_DEVICES Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 13/14] x86/init: rename ebda code file Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-11 6:51 ` Juergen Gross [this message]
2016-04-08 23:57 ` [PATCH v5 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-08 23:57 ` [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-08 23:57 ` [PATCH v5 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-13 8:44 ` Ingo Molnar
2016-04-13 15:45 ` Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-04-08 23:59 ` [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-09 0:00 ` [PATCH v5 00/14] x86: " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B4961.6000703@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=glin@suse.com \
--cc=hpa@zytor.com \
--cc=jlee@suse.com \
--cc=joro@8bytes.org \
--cc=josh@joshtriplett.org \
--cc=kozerkov@parallels.com \
--cc=lenb@kernel.org \
--cc=lguest@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=lv.zheng@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).