From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [ANNOUNCE] Xen 4.13 Development Update
Date: Wed, 29 May 2019 00:07:42 +0100 [thread overview]
Message-ID: <89f4a2db-46bd-c039-af05-708ef6077abf@citrix.com> (raw)
Message-ID: <20190528230742.3Ni1d3yl0uAteXnmf-icf53x45sx76ZD5PhcA-UpQkg@z> (raw)
In-Reply-To: <CABfawhnMVFrpwc8tc_cPtCFD+he6X79PZZ-LtHQ0d0Jcwv58LA@mail.gmail.com>
On 28/05/2019 14:44, Tamas K Lengyel wrote:
>> * Improvements to domain creation (v2)
>> - Andrew Cooper
> Hi Andrew,
> could you point me to a git branch where you have this work? I'm
> experimenting with some stuff and would like to see what your work in
> this area touches.
There is essentially nothing which isn't already in staging. Suffice it
to say that MDS got in the way of continuing that work.
The next task on the list is to make the vcpu/domain destroy paths
idempotent, then reimplement the create paths by just returning out of
the top of the call tree with an error, and having the top level call
destroy. This avoids having two different sets of destruction logic
which aren't quite identical.
With that in place, I can move the vcpu allocation loop into
domain_create() after which it will be impossible to find a domain by ID
and trip over some NULL vcpu pointers.
If you are introducing or adjusting allocation/deallocation logic,
please make the deallocation idempotent, and ideally use the deallocate
function to clean up from a failed allocate. There will be some
tree-wide refactoring at some point in the future which moves everything
into place. Until then, have at it.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-28 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 10:54 [ANNOUNCE] Xen 4.13 Development Update Juergen Gross
2019-05-28 10:54 ` [Xen-devel] " Juergen Gross
2019-05-28 13:44 ` Tamas K Lengyel
2019-05-28 13:44 ` [Xen-devel] " Tamas K Lengyel
2019-05-28 23:07 ` Andrew Cooper [this message]
2019-05-28 23:07 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f4a2db-46bd-c039-af05-708ef6077abf@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=tamas.k.lengyel@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).