From: Julien Grall <julien.grall@arm.com> To: xen-devel@lists.xenproject.org Cc: "Stefano Stabellini" <sstabellini@kernel.org>, andrii_anisov@epam.com, "Wei Liu" <wl@xen.org>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "George Dunlap" <george.dunlap@eu.citrix.com>, "Andrew Cooper" <andrew.cooper3@citrix.com>, "Tim Deegan" <tim@xen.org>, "Gang Wei" <gang.wei@intel.com>, oleksandr_tyshchenko@epam.com, "Julien Grall" <julien.grall@arm.com>, "Tamas K Lengyel" <tamas@tklengyel.com>, "Jan Beulich" <jbeulich@suse.com>, "Shane Wang" <shane.wang@intel.com>, "Ian Jackson" <ian.jackson@eu.citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: [PATCH v3 00/14] xen/arm: Properly disable M2P on Arm Date: Mon, 3 Jun 2019 17:03:36 +0100 [thread overview] Message-ID: <20190603160350.29806-1-julien.grall@arm.com> (raw) Hi all, Arm never supported a M2P yet there are some helpers implemented to deal with the common code. However, the implementation of mfn_to_gmfn is completely bogus. This series aims to properly disable the M2P on Arm. See patch #8 for the rationale regarding the lack of M2P on Arm. While looking at the code, I also continued to convert some code to use typesafe MFN/GFN. Cheers, Julien Grall (14): xen/x86: Make mfn_to_gfn typesafe xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn xen/grant-table: Make arch specific macros typesafe xen: Convert hotplug page function to use typesafe MFN xen: Convert is_xen_fixed_mfn to use typesafe MFN xen: Convert is_xen_heap_mfn to use typesafe MFN xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call xen: Remove mfn_to_gmfn macro xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function xen/x86: pv: Convert update_intpte() to use typesafe MFN xen/x86: p2m: Remove duplicate error message in p2m_pt_audit_p2m() xen/x86: p2m: Rework printk format in audit_p2m() xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P xen/arch/x86/Kconfig | 1 + xen/arch/x86/cpu/mcheck/mcaction.c | 20 +++---- xen/arch/x86/domain.c | 34 ++++++------ xen/arch/x86/mm.c | 102 ++++++++++++++++++------------------ xen/arch/x86/mm/mem_sharing.c | 19 +++---- xen/arch/x86/mm/p2m-pod.c | 4 +- xen/arch/x86/mm/p2m-pt.c | 35 ++++++------- xen/arch/x86/mm/p2m.c | 71 +++++++++++++------------ xen/arch/x86/mm/paging.c | 4 +- xen/arch/x86/mm/shadow/common.c | 31 ++++++----- xen/arch/x86/mm/shadow/multi.c | 6 +-- xen/arch/x86/pv/dom0_build.c | 6 +-- xen/arch/x86/pv/emul-priv-op.c | 4 +- xen/arch/x86/pv/grant_table.c | 6 +-- xen/arch/x86/pv/mm.h | 7 ++- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/tboot.c | 2 +- xen/arch/x86/x86_64/traps.c | 41 ++++++++------- xen/common/Kconfig | 3 ++ xen/common/domctl.c | 9 +++- xen/common/grant_table.c | 4 +- xen/common/memory.c | 4 ++ xen/common/page_alloc.c | 28 +++++----- xen/common/sysctl.c | 14 ++--- xen/drivers/passthrough/iommu.c | 15 ++++-- xen/drivers/passthrough/x86/iommu.c | 16 +++--- xen/include/asm-arm/domain.h | 5 ++ xen/include/asm-arm/grant_table.h | 12 ++--- xen/include/asm-arm/mm.h | 25 +++------ xen/include/asm-x86/grant_table.h | 19 +++---- xen/include/asm-x86/mm.h | 46 ++++++++-------- xen/include/asm-x86/p2m.h | 6 +-- xen/include/public/domctl.h | 6 +++ xen/include/xen/domain.h | 12 +++++ xen/include/xen/mm.h | 20 +++++-- 35 files changed, 344 insertions(+), 295 deletions(-) -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: xen-devel@lists.xenproject.org Cc: "Stefano Stabellini" <sstabellini@kernel.org>, andrii_anisov@epam.com, "Wei Liu" <wl@xen.org>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "George Dunlap" <george.dunlap@eu.citrix.com>, "Andrew Cooper" <andrew.cooper3@citrix.com>, "Tim Deegan" <tim@xen.org>, "Gang Wei" <gang.wei@intel.com>, oleksandr_tyshchenko@epam.com, "Julien Grall" <julien.grall@arm.com>, "Tamas K Lengyel" <tamas@tklengyel.com>, "Jan Beulich" <jbeulich@suse.com>, "Shane Wang" <shane.wang@intel.com>, "Ian Jackson" <ian.jackson@eu.citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: [Xen-devel] [PATCH v3 00/14] xen/arm: Properly disable M2P on Arm Date: Mon, 3 Jun 2019 17:03:36 +0100 [thread overview] Message-ID: <20190603160350.29806-1-julien.grall@arm.com> (raw) Message-ID: <20190603160336.ktAufWo_V4X5g_KF8YT7-Tfe5MRvQT8Y9ksIxQaf8l0@z> (raw) Hi all, Arm never supported a M2P yet there are some helpers implemented to deal with the common code. However, the implementation of mfn_to_gmfn is completely bogus. This series aims to properly disable the M2P on Arm. See patch #8 for the rationale regarding the lack of M2P on Arm. While looking at the code, I also continued to convert some code to use typesafe MFN/GFN. Cheers, Julien Grall (14): xen/x86: Make mfn_to_gfn typesafe xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn xen/grant-table: Make arch specific macros typesafe xen: Convert hotplug page function to use typesafe MFN xen: Convert is_xen_fixed_mfn to use typesafe MFN xen: Convert is_xen_heap_mfn to use typesafe MFN xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call xen: Remove mfn_to_gmfn macro xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function xen/x86: pv: Convert update_intpte() to use typesafe MFN xen/x86: p2m: Remove duplicate error message in p2m_pt_audit_p2m() xen/x86: p2m: Rework printk format in audit_p2m() xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P xen/arch/x86/Kconfig | 1 + xen/arch/x86/cpu/mcheck/mcaction.c | 20 +++---- xen/arch/x86/domain.c | 34 ++++++------ xen/arch/x86/mm.c | 102 ++++++++++++++++++------------------ xen/arch/x86/mm/mem_sharing.c | 19 +++---- xen/arch/x86/mm/p2m-pod.c | 4 +- xen/arch/x86/mm/p2m-pt.c | 35 ++++++------- xen/arch/x86/mm/p2m.c | 71 +++++++++++++------------ xen/arch/x86/mm/paging.c | 4 +- xen/arch/x86/mm/shadow/common.c | 31 ++++++----- xen/arch/x86/mm/shadow/multi.c | 6 +-- xen/arch/x86/pv/dom0_build.c | 6 +-- xen/arch/x86/pv/emul-priv-op.c | 4 +- xen/arch/x86/pv/grant_table.c | 6 +-- xen/arch/x86/pv/mm.h | 7 ++- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/tboot.c | 2 +- xen/arch/x86/x86_64/traps.c | 41 ++++++++------- xen/common/Kconfig | 3 ++ xen/common/domctl.c | 9 +++- xen/common/grant_table.c | 4 +- xen/common/memory.c | 4 ++ xen/common/page_alloc.c | 28 +++++----- xen/common/sysctl.c | 14 ++--- xen/drivers/passthrough/iommu.c | 15 ++++-- xen/drivers/passthrough/x86/iommu.c | 16 +++--- xen/include/asm-arm/domain.h | 5 ++ xen/include/asm-arm/grant_table.h | 12 ++--- xen/include/asm-arm/mm.h | 25 +++------ xen/include/asm-x86/grant_table.h | 19 +++---- xen/include/asm-x86/mm.h | 46 ++++++++-------- xen/include/asm-x86/p2m.h | 6 +-- xen/include/public/domctl.h | 6 +++ xen/include/xen/domain.h | 12 +++++ xen/include/xen/mm.h | 20 +++++-- 35 files changed, 344 insertions(+), 295 deletions(-) -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-06-03 16:04 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-03 16:03 Julien Grall [this message] 2019-06-03 16:03 ` [Xen-devel] [PATCH v3 00/14] xen/arm: Properly disable M2P on Arm Julien Grall 2019-06-03 16:03 ` [PATCH v3 01/14] xen/x86: Make mfn_to_gfn typesafe Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-04 16:06 ` Jan Beulich 2019-07-29 12:13 ` Julien Grall 2019-08-19 13:50 ` George Dunlap 2019-06-03 16:03 ` [PATCH v3 02/14] xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 03/14] xen/grant-table: Make arch specific macros typesafe Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 04/14] xen: Convert hotplug page function to use typesafe MFN Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 05/14] xen: Convert is_xen_fixed_mfn " Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 06/14] xen: Convert is_xen_heap_mfn " Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 07/14] xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-04 16:14 ` Jan Beulich 2019-06-04 16:22 ` Julien Grall 2019-06-05 7:14 ` Jan Beulich 2019-06-05 9:35 ` Julien Grall 2019-06-05 10:10 ` Jan Beulich 2019-07-29 12:08 ` Julien Grall 2019-06-03 16:03 ` [PATCH v3 08/14] xen: Remove mfn_to_gmfn macro Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 09/14] xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-04 16:21 ` Jan Beulich 2019-06-04 16:23 ` Julien Grall 2019-06-05 7:18 ` Jan Beulich 2019-06-03 16:03 ` [PATCH v3 10/14] xen/x86: pv: Convert update_intpte() to use typesafe MFN Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 11/14] xen/x86: p2m: Remove duplicate error message in p2m_pt_audit_p2m() Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-05 10:43 ` Jan Beulich 2019-06-05 10:44 ` Julien Grall 2019-06-03 16:03 ` [PATCH v3 12/14] xen/x86: p2m: Rework printk format in audit_p2m() Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-03 16:03 ` [PATCH v3 13/14] xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-05 11:01 ` Jan Beulich 2019-06-05 11:03 ` Julien Grall 2019-06-03 16:03 ` [PATCH v3 14/14] xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P Julien Grall 2019-06-03 16:03 ` [Xen-devel] " Julien Grall 2019-06-05 11:07 ` Jan Beulich 2019-06-05 11:17 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190603160350.29806-1-julien.grall@arm.com \ --to=julien.grall@arm.com \ --cc=andrew.cooper3@citrix.com \ --cc=andrii_anisov@epam.com \ --cc=gang.wei@intel.com \ --cc=george.dunlap@eu.citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=jbeulich@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=oleksandr_tyshchenko@epam.com \ --cc=roger.pau@citrix.com \ --cc=shane.wang@intel.com \ --cc=sstabellini@kernel.org \ --cc=tamas@tklengyel.com \ --cc=tim@xen.org \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).