From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Claudia <claudia1@disroot.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
zachm1996@gmail.com, Jan Beulich <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] Xen fails to resume on AMD Fam15h (and Fam17h?) because of CPUID mismatch
Date: Tue, 11 Feb 2020 22:08:52 +0100 [thread overview]
Message-ID: <20200211210852.GF2995@mail-itl> (raw)
In-Reply-To: <b1dfd8e66ff2cfdd1a5d77d46238b637@disroot.org>
[-- Attachment #1.1: Type: text/plain, Size: 2364 bytes --]
On Tue, Feb 11, 2020 at 12:59:22PM +0000, Claudia wrote:
> February 10, 2020 12:14 PM, "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com> wrote:
>
> > On Mon, Feb 10, 2020 at 11:17:34AM +0000, Andrew Cooper wrote:
> >
> >> On 10/02/2020 08:55, Jan Beulich wrote:
> >> On 10.02.2020 00:06, Marek Marczykowski-Górecki wrote:
> >> Hi,
> >>
> >> Multiple Qubes users have reported issues with resuming from S3 on AMD
> >> systems (Ryzen 2500U, Ryzen Pro 3700U, maybe more). The error message
> >> is:
> >>
> >> (XEN) CPU0: cap[ 1] is 7ed8320b (expected f6d8320b)
> >>
> >> If I read it right, this is:
> >> - OSXSAVE: 0 -> 1
> >> - HYPERVISOR: 1 -> 0
> >>
> >> Commenting out the panic on a failed recheck_cpu_features() in power.c
> >> makes the system work after resume, reportedly stable. But that doesn't
> >> sounds like a good idea generally.
> >>
> >> Is this difference a Xen fault (some missing MSR / other register
> >> restore on resume)? Or BIOS vendor / AMD, that could be worked around in
> >> Xen?
> >> The transition of the HYPERVISOR bit is definitely a Xen issue,
> >> with Andrew having sent a patch already (iirc).
> >>
> >> https://lore.kernel.org/xen-devel/20200127202121.2961-1-andrew.cooper3@citrix.com
> >>
> >> Code is correct. Commit message needs rework, including in light of
> >> this discovery. (I may eventually split it into two patches.)
> >
> > Claudia, do you want to test with this patch?
>
> I'm getting hunk failed in domctl.c applying to R4.1 default repo (fc31, Xen 4.13). I'll see if I can fix it but bear with me, I'm new at this.
>
> Marek: Would you by any chance be willing to merge this into a test branch on your repo, so the rest of us can pull it directly into qubes-builder? It'll take you a fraction of the time it'll take me, plus then zachm and awokd and anyone else can pull it also.
Here is one for Xen 4.13:
https://github.com/QubesOS/qubes-vmm-xen/pull/71
builder.conf snippet for qubes-builder:
BRANCH_vmm_xen=xen-4.13-amd-suspend
GIT_URL_vmm_xen=https://github.com/marmarek/qubes-vmm-xen
This is already v2 patch from the other thread.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-11 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 23:06 [Xen-devel] Xen fails to resume on AMD Fam15h (and Fam17h?) because of CPUID mismatch Marek Marczykowski-Górecki
2020-02-10 8:55 ` Jan Beulich
2020-02-10 11:17 ` Andrew Cooper
2020-02-10 12:14 ` Marek Marczykowski-Górecki
2020-02-10 12:46 ` Andrew Cooper
2020-02-11 12:59 ` Claudia
2020-02-11 21:08 ` Marek Marczykowski-Górecki [this message]
2020-02-12 4:20 ` Claudia
2020-05-02 21:12 ` Z M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211210852.GF2995@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=andrew.cooper3@citrix.com \
--cc=claudia1@disroot.org \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zachm1996@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).