* [Xen-devel] [PATCH v6 0/3] nvmx: implement support for MSR bitmaps
@ 2020-02-19 10:22 Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_* Roger Pau Monne
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Roger Pau Monne @ 2020-02-19 10:22 UTC (permalink / raw)
To: xen-devel
Cc: Kevin Tian, Stefano Stabellini, Julien Grall, Jun Nakajima,
Wei Liu, Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper,
Ian Jackson, Jan Beulich, Volodymyr Babchuk, Roger Pau Monne
Hello,
Patch #3 makes sure the x2APIC MSR range is always trapped, or else a
guest with nested virtualization enabled could manage to access some of
the x2APIC MSR registers from the host. Previous patches are preparatory
patches in order to import bitmap_{set/clear}.
Thanks, Roger.
Roger Pau Monne (3):
arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_*
bitmap: import bitmap_{set/clear} from Linux 5.5
nvmx: always trap accesses to x2APIC MSRs
xen/arch/arm/arm32/lib/bitops.c | 10 +++----
xen/arch/arm/arm64/lib/bitops.c | 10 +++----
xen/arch/arm/arm64/lib/find_next_bit.c | 10 +++----
xen/arch/x86/hvm/vmx/vvmx.c | 7 +++++
xen/common/bitmap.c | 39 +++++++++++++++++++++++++
xen/include/asm-arm/bitops.h | 20 ++++++-------
xen/include/xen/bitmap.h | 40 ++++++++++++++++++++++++++
xen/include/xen/bitops.h | 2 ++
8 files changed, 112 insertions(+), 26 deletions(-)
--
2.25.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_*
2020-02-19 10:22 [Xen-devel] [PATCH v6 0/3] nvmx: implement support for MSR bitmaps Roger Pau Monne
@ 2020-02-19 10:22 ` Roger Pau Monne
2020-02-19 11:35 ` Julien Grall
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 2/3] bitmap: import bitmap_{set/clear} from Linux 5.5 Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 3/3] nvmx: always trap accesses to x2APIC MSRs Roger Pau Monne
2 siblings, 1 reply; 7+ messages in thread
From: Roger Pau Monne @ 2020-02-19 10:22 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
Volodymyr Babchuk, Roger Pau Monne
So BIT_WORD can be imported from Linux. The difference between current
Linux implementation of BIT_WORD is that the size of the word unit is
a long integer, while the Xen one is hardcoded to 32 bits.
Current users of BITOP_WORD on Arm (which considers a word a long
integer) are switched to use the generic BIT_WORD which also operates
on long integers.
No functional change intended.
Suggested-by: Julien Grall <julien@xen.org>
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v5:
- Also rename BIT_MASK and BITS_PER_WORD.
Changes since v4:
- New in this version.
---
xen/arch/arm/arm32/lib/bitops.c | 10 +++++-----
xen/arch/arm/arm64/lib/bitops.c | 10 +++++-----
xen/arch/arm/arm64/lib/find_next_bit.c | 10 ++++------
xen/include/asm-arm/bitops.h | 20 ++++++++++----------
xen/include/xen/bitops.h | 2 ++
5 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/xen/arch/arm/arm32/lib/bitops.c b/xen/arch/arm/arm32/lib/bitops.c
index 3dca769bf0..ceddd76d1b 100644
--- a/xen/arch/arm/arm32/lib/bitops.c
+++ b/xen/arch/arm/arm32/lib/bitops.c
@@ -33,8 +33,8 @@
static always_inline bool int_##name(int nr, volatile void *p, bool timeout,\
unsigned int max_try) \
{ \
- volatile uint32_t *ptr = (uint32_t *)p + BIT_WORD((unsigned int)nr); \
- const uint32_t mask = BIT_MASK((unsigned int)nr); \
+ volatile uint32_t *ptr = (uint32_t *)p + BITOP_WORD((unsigned int)nr); \
+ const uint32_t mask = BITOP_MASK((unsigned int)nr); \
unsigned long res, tmp; \
\
ASSERT(((vaddr_t)p & 0x3) == 0); \
@@ -71,9 +71,9 @@ bool name##_timeout(int nr, volatile void *p, unsigned int max_try) \
static always_inline bool int_##name(int nr, volatile void *p, int *oldbit, \
bool timeout, unsigned int max_try) \
{ \
- volatile uint32_t *ptr = (uint32_t *)p + BIT_WORD((unsigned int)nr); \
- unsigned int bit = (unsigned int)nr % BITS_PER_WORD; \
- const uint32_t mask = BIT_MASK(bit); \
+ volatile uint32_t *ptr = (uint32_t *)p + BITOP_WORD((unsigned int)nr); \
+ unsigned int bit = (unsigned int)nr % BITOP_BITS_PER_WORD; \
+ const uint32_t mask = BITOP_MASK(bit); \
unsigned long res, tmp; \
\
ASSERT(((vaddr_t)p & 0x3) == 0); \
diff --git a/xen/arch/arm/arm64/lib/bitops.c b/xen/arch/arm/arm64/lib/bitops.c
index 27688e5418..20e3f3d6ce 100644
--- a/xen/arch/arm/arm64/lib/bitops.c
+++ b/xen/arch/arm/arm64/lib/bitops.c
@@ -32,8 +32,8 @@
static always_inline bool int_##name(int nr, volatile void *p, bool timeout,\
unsigned int max_try) \
{ \
- volatile uint32_t *ptr = (uint32_t *)p + BIT_WORD((unsigned int)nr); \
- const uint32_t mask = BIT_MASK((unsigned int)nr); \
+ volatile uint32_t *ptr = (uint32_t *)p + BITOP_WORD((unsigned int)nr); \
+ const uint32_t mask = BITOP_MASK((unsigned int)nr); \
unsigned long res, tmp; \
\
do \
@@ -67,9 +67,9 @@ bool name##_timeout(int nr, volatile void *p, unsigned int max_try) \
static always_inline bool int_##name(int nr, volatile void *p, int *oldbit, \
bool timeout, unsigned int max_try) \
{ \
- volatile uint32_t *ptr = (uint32_t *)p + BIT_WORD((unsigned int)nr); \
- unsigned int bit = (unsigned int)nr % BITS_PER_WORD; \
- const uint32_t mask = BIT_MASK(bit); \
+ volatile uint32_t *ptr = (uint32_t *)p + BITOP_WORD((unsigned int)nr); \
+ unsigned int bit = (unsigned int)nr % BITOP_BITS_PER_WORD; \
+ const uint32_t mask = BITOP_MASK(bit); \
unsigned long res, tmp; \
\
do \
diff --git a/xen/arch/arm/arm64/lib/find_next_bit.c b/xen/arch/arm/arm64/lib/find_next_bit.c
index 17cb176266..8ebf8bfe97 100644
--- a/xen/arch/arm/arm64/lib/find_next_bit.c
+++ b/xen/arch/arm/arm64/lib/find_next_bit.c
@@ -12,8 +12,6 @@
#include <asm/types.h>
#include <asm/byteorder.h>
-#define BITOP_WORD(nr) ((nr) / BITS_PER_LONG)
-
#ifndef find_next_bit
/*
* Find the next set bit in a memory region.
@@ -21,7 +19,7 @@
unsigned long find_next_bit(const unsigned long *addr, unsigned long size,
unsigned long offset)
{
- const unsigned long *p = addr + BITOP_WORD(offset);
+ const unsigned long *p = addr + BIT_WORD(offset);
unsigned long result = offset & ~(BITS_PER_LONG-1);
unsigned long tmp;
@@ -67,7 +65,7 @@ EXPORT_SYMBOL(find_next_bit);
unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size,
unsigned long offset)
{
- const unsigned long *p = addr + BITOP_WORD(offset);
+ const unsigned long *p = addr + BIT_WORD(offset);
unsigned long result = offset & ~(BITS_PER_LONG-1);
unsigned long tmp;
@@ -197,7 +195,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned
if (offset >= size)
return size;
- p += BITOP_WORD(offset);
+ p += BIT_WORD(offset);
size -= result;
offset &= (BITS_PER_LONG - 1UL);
if (offset) {
@@ -243,7 +241,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned
if (offset >= size)
return size;
- p += BITOP_WORD(offset);
+ p += BIT_WORD(offset);
size -= result;
offset &= (BITS_PER_LONG - 1UL);
if (offset) {
diff --git a/xen/include/asm-arm/bitops.h b/xen/include/asm-arm/bitops.h
index fbb4b82413..71ae14cab3 100644
--- a/xen/include/asm-arm/bitops.h
+++ b/xen/include/asm-arm/bitops.h
@@ -20,9 +20,9 @@
#define __set_bit(n,p) set_bit(n,p)
#define __clear_bit(n,p) clear_bit(n,p)
-#define BITS_PER_WORD 32
-#define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_WORD))
-#define BIT_WORD(nr) ((nr) / BITS_PER_WORD)
+#define BITOP_BITS_PER_WORD 32
+#define BITOP_MASK(nr) (1UL << ((nr) % BITOP_BITS_PER_WORD))
+#define BITOP_WORD(nr) ((nr) / BITOP_BITS_PER_WORD)
#define BITS_PER_BYTE 8
#define ADDR (*(volatile int *) addr)
@@ -85,9 +85,9 @@ bool clear_mask16_timeout(uint16_t mask, volatile void *p,
*/
static inline int __test_and_set_bit(int nr, volatile void *addr)
{
- unsigned int mask = BIT_MASK(nr);
+ unsigned int mask = BITOP_MASK(nr);
volatile unsigned int *p =
- ((volatile unsigned int *)addr) + BIT_WORD(nr);
+ ((volatile unsigned int *)addr) + BITOP_WORD(nr);
unsigned int old = *p;
*p = old | mask;
@@ -105,9 +105,9 @@ static inline int __test_and_set_bit(int nr, volatile void *addr)
*/
static inline int __test_and_clear_bit(int nr, volatile void *addr)
{
- unsigned int mask = BIT_MASK(nr);
+ unsigned int mask = BITOP_MASK(nr);
volatile unsigned int *p =
- ((volatile unsigned int *)addr) + BIT_WORD(nr);
+ ((volatile unsigned int *)addr) + BITOP_WORD(nr);
unsigned int old = *p;
*p = old & ~mask;
@@ -118,9 +118,9 @@ static inline int __test_and_clear_bit(int nr, volatile void *addr)
static inline int __test_and_change_bit(int nr,
volatile void *addr)
{
- unsigned int mask = BIT_MASK(nr);
+ unsigned int mask = BITOP_MASK(nr);
volatile unsigned int *p =
- ((volatile unsigned int *)addr) + BIT_WORD(nr);
+ ((volatile unsigned int *)addr) + BITOP_WORD(nr);
unsigned int old = *p;
*p = old ^ mask;
@@ -135,7 +135,7 @@ static inline int __test_and_change_bit(int nr,
static inline int test_bit(int nr, const volatile void *addr)
{
const volatile unsigned int *p = (const volatile unsigned int *)addr;
- return 1UL & (p[BIT_WORD(nr)] >> (nr & (BITS_PER_WORD-1)));
+ return 1UL & (p[BITOP_WORD(nr)] >> (nr & (BITOP_BITS_PER_WORD-1)));
}
/*
diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
index dfb70417c2..a64595f68e 100644
--- a/xen/include/xen/bitops.h
+++ b/xen/include/xen/bitops.h
@@ -245,4 +245,6 @@ static inline __u32 ror32(__u32 word, unsigned int shift)
(bit) < (size); \
(bit) = find_next_bit(addr, size, (bit) + 1) )
+#define BIT_WORD(nr) ((nr) / BITS_PER_LONG)
+
#endif
--
2.25.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Xen-devel] [PATCH v6 2/3] bitmap: import bitmap_{set/clear} from Linux 5.5
2020-02-19 10:22 [Xen-devel] [PATCH v6 0/3] nvmx: implement support for MSR bitmaps Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_* Roger Pau Monne
@ 2020-02-19 10:22 ` Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 3/3] nvmx: always trap accesses to x2APIC MSRs Roger Pau Monne
2 siblings, 0 replies; 7+ messages in thread
From: Roger Pau Monne @ 2020-02-19 10:22 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
Roger Pau Monne
Import the functions and it's dependencies. Based on Linux 5.5, commit
id d5226fa6dbae0569ee43ecfc08bdcd6770fc4755.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
Changes since v4:
- Introduce BIT_WORD in generic header bitops.h (instead of the x86
one).
- Include byteorder.h for __LITTLE_ENDIAN
- Remove EXPORT_SYMBOL.
---
xen/common/bitmap.c | 39 +++++++++++++++++++++++++++++++++++++++
xen/include/xen/bitmap.h | 40 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 79 insertions(+)
diff --git a/xen/common/bitmap.c b/xen/common/bitmap.c
index fd070bee97..88768bf8bc 100644
--- a/xen/common/bitmap.c
+++ b/xen/common/bitmap.c
@@ -212,6 +212,45 @@ int __bitmap_weight(const unsigned long *bitmap, int bits)
#endif
EXPORT_SYMBOL(__bitmap_weight);
+void __bitmap_set(unsigned long *map, unsigned int start, int len)
+{
+ unsigned long *p = map + BIT_WORD(start);
+ const unsigned int size = start + len;
+ int bits_to_set = BITS_PER_LONG - (start % BITS_PER_LONG);
+ unsigned long mask_to_set = BITMAP_FIRST_WORD_MASK(start);
+
+ while (len - bits_to_set >= 0) {
+ *p |= mask_to_set;
+ len -= bits_to_set;
+ bits_to_set = BITS_PER_LONG;
+ mask_to_set = ~0UL;
+ p++;
+ }
+ if (len) {
+ mask_to_set &= BITMAP_LAST_WORD_MASK(size);
+ *p |= mask_to_set;
+ }
+}
+
+void __bitmap_clear(unsigned long *map, unsigned int start, int len)
+{
+ unsigned long *p = map + BIT_WORD(start);
+ const unsigned int size = start + len;
+ int bits_to_clear = BITS_PER_LONG - (start % BITS_PER_LONG);
+ unsigned long mask_to_clear = BITMAP_FIRST_WORD_MASK(start);
+
+ while (len - bits_to_clear >= 0) {
+ *p &= ~mask_to_clear;
+ len -= bits_to_clear;
+ bits_to_clear = BITS_PER_LONG;
+ mask_to_clear = ~0UL;
+ p++;
+ }
+ if (len) {
+ mask_to_clear &= BITMAP_LAST_WORD_MASK(size);
+ *p &= ~mask_to_clear;
+ }
+}
/**
* bitmap_find_free_region - find a contiguous aligned mem region
diff --git a/xen/include/xen/bitmap.h b/xen/include/xen/bitmap.h
index 4e1e690af1..c44e009f8c 100644
--- a/xen/include/xen/bitmap.h
+++ b/xen/include/xen/bitmap.h
@@ -85,6 +85,8 @@ extern int __bitmap_intersects(const unsigned long *bitmap1,
extern int __bitmap_subset(const unsigned long *bitmap1,
const unsigned long *bitmap2, int bits);
extern int __bitmap_weight(const unsigned long *bitmap, int bits);
+extern void __bitmap_set(unsigned long *map, unsigned int start, int len);
+extern void __bitmap_clear(unsigned long *map, unsigned int start, int len);
extern int bitmap_find_free_region(unsigned long *bitmap, int bits, int order);
extern void bitmap_release_region(unsigned long *bitmap, int pos, int order);
@@ -227,6 +229,44 @@ static inline int bitmap_weight(const unsigned long *src, int nbits)
return __bitmap_weight(src, nbits);
}
+#include <asm/byteorder.h>
+
+#ifdef __LITTLE_ENDIAN
+#define BITMAP_MEM_ALIGNMENT 8
+#else
+#define BITMAP_MEM_ALIGNMENT (8 * sizeof(unsigned long))
+#endif
+#define BITMAP_MEM_MASK (BITMAP_MEM_ALIGNMENT - 1)
+#define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - 1)))
+
+static inline void bitmap_set(unsigned long *map, unsigned int start,
+ unsigned int nbits)
+{
+ if (__builtin_constant_p(nbits) && nbits == 1)
+ __set_bit(start, map);
+ else if (__builtin_constant_p(start & BITMAP_MEM_MASK) &&
+ IS_ALIGNED(start, BITMAP_MEM_ALIGNMENT) &&
+ __builtin_constant_p(nbits & BITMAP_MEM_MASK) &&
+ IS_ALIGNED(nbits, BITMAP_MEM_ALIGNMENT))
+ memset((char *)map + start / 8, 0xff, nbits / 8);
+ else
+ __bitmap_set(map, start, nbits);
+}
+
+static inline void bitmap_clear(unsigned long *map, unsigned int start,
+ unsigned int nbits)
+{
+ if (__builtin_constant_p(nbits) && nbits == 1)
+ __clear_bit(start, map);
+ else if (__builtin_constant_p(start & BITMAP_MEM_MASK) &&
+ IS_ALIGNED(start, BITMAP_MEM_ALIGNMENT) &&
+ __builtin_constant_p(nbits & BITMAP_MEM_MASK) &&
+ IS_ALIGNED(nbits, BITMAP_MEM_ALIGNMENT))
+ memset((char *)map + start / 8, 0, nbits / 8);
+ else
+ __bitmap_clear(map, start, nbits);
+}
+
#undef bitmap_switch
#undef bitmap_bytes
--
2.25.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Xen-devel] [PATCH v6 3/3] nvmx: always trap accesses to x2APIC MSRs
2020-02-19 10:22 [Xen-devel] [PATCH v6 0/3] nvmx: implement support for MSR bitmaps Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_* Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 2/3] bitmap: import bitmap_{set/clear} from Linux 5.5 Roger Pau Monne
@ 2020-02-19 10:22 ` Roger Pau Monne
2 siblings, 0 replies; 7+ messages in thread
From: Roger Pau Monne @ 2020-02-19 10:22 UTC (permalink / raw)
To: xen-devel
Cc: Kevin Tian, Jun Nakajima, Wei Liu, Andrew Cooper, Jan Beulich,
Roger Pau Monne
Nested VMX doesn't expose support for
SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE,
SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY or
SECONDARY_EXEC_APIC_REGISTER_VIRT, and hence the x2APIC MSRs should
always be trapped in the nested guest MSR bitmap, or else a nested
guest could access the hardware x2APIC MSRs given certain conditions.
Accessing the hardware MSRs could be achieved by forcing the L0 Xen to
use SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE and
SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY or
SECONDARY_EXEC_APIC_REGISTER_VIRT (if supported), and then creating a
L2 guest with a MSR bitmap that doesn't trap accesses to the x2APIC
MSR range. Then OR'ing both L0 and L1 MSR bitmaps would result in a
bitmap that doesn't trap certain x2APIC MSRs and a VMCS that doesn't
have SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE and
SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY or
SECONDARY_EXEC_APIC_REGISTER_VIRT set either.
Fix this by making sure x2APIC MSRs are always trapped in the nested
MSR bitmap.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
---
Changes since v4:
- Fix size of x2APIC region to use 0x100.
Changes since v3:
- Use bitmap_set.
Changes since v1:
- New in this version (split from #1 patch).
- Use non-locked set_bit.
---
xen/arch/x86/hvm/vmx/vvmx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index 3337260d4b..926a11c15f 100644
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -596,6 +596,13 @@ static void update_msrbitmap(struct vcpu *v, uint32_t shadow_ctrl)
v->arch.hvm.vmx.msr_bitmap->write_high,
sizeof(msr_bitmap->write_high) * 8);
+ /*
+ * Nested VMX doesn't support any x2APIC hardware virtualization, so
+ * make sure all the x2APIC MSRs are trapped.
+ */
+ bitmap_set(msr_bitmap->read_low, MSR_X2APIC_FIRST, 0x100);
+ bitmap_set(msr_bitmap->write_low, MSR_X2APIC_FIRST, 0x100);
+
unmap_domain_page(msr_bitmap);
__vmwrite(MSR_BITMAP, page_to_maddr(nvmx->msr_merged));
--
2.25.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_*
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_* Roger Pau Monne
@ 2020-02-19 11:35 ` Julien Grall
2020-02-19 11:41 ` Roger Pau Monné
0 siblings, 1 reply; 7+ messages in thread
From: Julien Grall @ 2020-02-19 11:35 UTC (permalink / raw)
To: Roger Pau Monne, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
Volodymyr Babchuk
Hi Roger,
On 19/02/2020 10:22, Roger Pau Monne wrote:
> So BIT_WORD can be imported from Linux. The difference between current
> Linux implementation of BIT_WORD is that the size of the word unit is
> a long integer, while the Xen one is hardcoded to 32 bits.
>
> Current users of BITOP_WORD on Arm (which considers a word a long
> integer) are switched to use the generic BIT_WORD which also operates
> on long integers.
>
> No functional change intended.
>
> Suggested-by: Julien Grall <julien@xen.org>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Julien Grall <julien@xen.org>
Did you build test it on Arm?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_*
2020-02-19 11:35 ` Julien Grall
@ 2020-02-19 11:41 ` Roger Pau Monné
2020-02-19 12:03 ` Julien Grall
0 siblings, 1 reply; 7+ messages in thread
From: Roger Pau Monné @ 2020-02-19 11:41 UTC (permalink / raw)
To: Julien Grall
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
xen-devel, Volodymyr Babchuk
On Wed, Feb 19, 2020 at 11:35:16AM +0000, Julien Grall wrote:
> Hi Roger,
>
> On 19/02/2020 10:22, Roger Pau Monne wrote:
> > So BIT_WORD can be imported from Linux. The difference between current
> > Linux implementation of BIT_WORD is that the size of the word unit is
> > a long integer, while the Xen one is hardcoded to 32 bits.
> >
> > Current users of BITOP_WORD on Arm (which considers a word a long
> > integer) are switched to use the generic BIT_WORD which also operates
> > on long integers.
> >
> > No functional change intended.
> >
> > Suggested-by: Julien Grall <julien@xen.org>
> > Suggested-by: Jan Beulich <jbeulich@suse.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Acked-by: Julien Grall <julien@xen.org>
>
> Did you build test it on Arm?
Did a gitlab run, build was fine:
https://gitlab.com/xen-project/people/royger/xen/pipelines/118878544
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_*
2020-02-19 11:41 ` Roger Pau Monné
@ 2020-02-19 12:03 ` Julien Grall
0 siblings, 0 replies; 7+ messages in thread
From: Julien Grall @ 2020-02-19 12:03 UTC (permalink / raw)
To: Roger Pau Monné
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
xen-devel, Volodymyr Babchuk
On 19/02/2020 11:41, Roger Pau Monné wrote:
> On Wed, Feb 19, 2020 at 11:35:16AM +0000, Julien Grall wrote:
>> Hi Roger,
>>
>> On 19/02/2020 10:22, Roger Pau Monne wrote:
>>> So BIT_WORD can be imported from Linux. The difference between current
>>> Linux implementation of BIT_WORD is that the size of the word unit is
>>> a long integer, while the Xen one is hardcoded to 32 bits.
>>>
>>> Current users of BITOP_WORD on Arm (which considers a word a long
>>> integer) are switched to use the generic BIT_WORD which also operates
>>> on long integers.
>>>
>>> No functional change intended.
>>>
>>> Suggested-by: Julien Grall <julien@xen.org>
>>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> Acked-by: Julien Grall <julien@xen.org>
>>
>> Did you build test it on Arm?
>
> Did a gitlab run, build was fine:
> > https://gitlab.com/xen-project/people/royger/xen/pipelines/118878544
Thank you!
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-19 12:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 10:22 [Xen-devel] [PATCH v6 0/3] nvmx: implement support for MSR bitmaps Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_* Roger Pau Monne
2020-02-19 11:35 ` Julien Grall
2020-02-19 11:41 ` Roger Pau Monné
2020-02-19 12:03 ` Julien Grall
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 2/3] bitmap: import bitmap_{set/clear} from Linux 5.5 Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 3/3] nvmx: always trap accesses to x2APIC MSRs Roger Pau Monne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).