[PATCH v2 00/10] arm: add one kconfig option per platform

[PATCH v2 00/10] arm: add one kconfig option per platform

[Stefano Stabellini]

Hi all,

This patch series introduces one kconfig option for each remaing
platform under platforms/.  Each kconfig option enables the required
drivers in Xen.

Cheers,

Stefano

Changes in v2:
- remove all platform options except for thunderx, sunxi, rcar2, omap5
- add "make platform specific code dependent on ALL32_PLAT or ALL64_PLAT"
- add "introduce NO_PLAT"
- remove HAS_SMMU from ThunderX


The following changes since commit 37b7c808b3fd68c11425accb53b83c37479a2b51:

  automation: build with debian unstable (2018-08-20 14:05:11 +0100)

are available in the git repository at:

  http://xenbits.xenproject.org/git-http/people/sstabellini/xen-unstable.git kconfig-plat-2

for you to fetch changes up to 1051ae3832c3960150ccac5ce75260ae61442bf0:

  xen/arm: introduce NO_PLAT (2018-08-23 16:25:27 -0700)

----------------------------------------------------------------
Stefano Stabellini (6):
      xen/arm: add THUNDERX kconfig
      xen/arm: add SUNXI kconfig
      xen/arm: add RCAR2 kconfig
      xen/arm: add OMAP5 kconfig
      xen/arm: make platform specific code dependent on ALL32_PLAT or ALL64_PLAT
      xen/arm: introduce NO_PLAT

 xen/arch/arm/platforms/Kconfig  | 51 +++++++++++++++++++++++++++++++++++++++++
 xen/arch/arm/platforms/Makefile | 21 +++++++++--------
 2 files changed, 62 insertions(+), 10 deletions(-)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 1/6] xen/arm: add THUNDERX kconfig

[Stefano Stabellini]

Add a kconfig option for Cavium ThunderX platforms.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
CC: mjaggi@caviumnetworks.com
CC: Zi.Lim@cavium.com
---
Changes in v2:
- remove HAS_SMMU
---
 xen/arch/arm/platforms/Kconfig  | 13 +++++++++++++
 xen/arch/arm/platforms/Makefile |  1 +
 2 files changed, 14 insertions(+)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index 409d3f8..b9c0b7f 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -36,6 +36,16 @@ config MPSOC
 	---help---
 	Enable all the required drivers for Xilinx Ultrascale+ MPSoC
 
+config THUNDERX
+	bool "Cavium ThunderX"
+	depends on ARM_64
+	select GICV3
+	select HAS_ITS
+	select HAS_PL011
+	select ACPI if EXPERT = "y"
+	---help---
+	Enable all the required drivers for Cavium ThunderX
+
 endchoice
 
 config ALL64_PLAT
@@ -50,3 +60,6 @@ config MPSOC_PLATFORM
 	bool
 	default (ALL64_PLAT || MPSOC)
 
+config THUNDERX_PLATFORM
+	bool
+	default (ALL64_PLAT || THUNDERX)
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index a79bdb9..f352a29 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -7,5 +7,6 @@ obj-$(CONFIG_ARM_32) += rcar2.o
 obj-$(CONFIG_ARM_64) += seattle.o
 obj-y += sunxi.o
 obj-$(CONFIG_ARM_64) += thunderx.o
+obj-$(CONFIG_THUNDERX_PLATFORM) += thunderx.o
 obj-$(CONFIG_ARM_64) += xgene-storm.o
 obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp.o
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 2/6] xen/arm: add SUNXI kconfig

[Stefano Stabellini]

Add a kconfig option for SUNXI platforms.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
CC: andre.przywara@arm.com
CC: v1ne2go@gmail.com
---
 xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
 xen/arch/arm/platforms/Makefile |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index b9c0b7f..a43c938 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -46,6 +46,13 @@ config THUNDERX
 	---help---
 	Enable all the required drivers for Cavium ThunderX
 
+config SUNXI
+	bool "Allwinner sunxi platforms"
+	select HAS_NS16550
+	---help---
+	Enable all the required drivers for Allwinnder sunxi platforms,
+	including Pine64, OrangePi, CubieBoard, etc.
+
 endchoice
 
 config ALL64_PLAT
@@ -63,3 +70,7 @@ config MPSOC_PLATFORM
 config THUNDERX_PLATFORM
 	bool
 	default (ALL64_PLAT || THUNDERX)
+
+config SUNXI_PLATFORM
+	bool
+	default (ALL_PLAT || SUNXI)
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index f352a29..aabf1d4 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -5,7 +5,7 @@ obj-$(CONFIG_ARM_32) += midway.o
 obj-$(CONFIG_ARM_32) += omap5.o
 obj-$(CONFIG_ARM_32) += rcar2.o
 obj-$(CONFIG_ARM_64) += seattle.o
-obj-y += sunxi.o
+obj-$(CONFIG_SUNXI_PLATFORM)    += sunxi.o
 obj-$(CONFIG_ARM_64) += thunderx.o
 obj-$(CONFIG_THUNDERX_PLATFORM) += thunderx.o
 obj-$(CONFIG_ARM_64) += xgene-storm.o
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 3/6] xen/arm: add RCAR2 kconfig

[Stefano Stabellini]

Add a kconfig option for Renesas Rcar2 platforms.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
CC: iurii.konovalenko@globallogic.com
---
 xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
 xen/arch/arm/platforms/Makefile |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index a43c938..e54825a 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -53,6 +53,13 @@ config SUNXI
 	Enable all the required drivers for Allwinnder sunxi platforms,
 	including Pine64, OrangePi, CubieBoard, etc.
 
+config RCAR2
+	bool "Renesas R-Car Gen2"
+	depends on ARM_32
+	select HAS_SCIF
+	---help---
+	Enable all the required drivers for Renesas R-Car Gen2.
+
 endchoice
 
 config ALL64_PLAT
@@ -74,3 +81,7 @@ config THUNDERX_PLATFORM
 config SUNXI_PLATFORM
 	bool
 	default (ALL_PLAT || SUNXI)
+
+config RCAR2_PLATFORM
+	bool
+	default (ALL32_PLAT || RCAR2)
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index aabf1d4..27cc383 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -3,7 +3,7 @@ obj-$(CONFIG_ARM_32) += brcm.o
 obj-$(CONFIG_ARM_32) += exynos5.o
 obj-$(CONFIG_ARM_32) += midway.o
 obj-$(CONFIG_ARM_32) += omap5.o
-obj-$(CONFIG_ARM_32) += rcar2.o
+obj-$(CONFIG_RCAR2_PLATFORM)    += rcar2.o
 obj-$(CONFIG_ARM_64) += seattle.o
 obj-$(CONFIG_SUNXI_PLATFORM)    += sunxi.o
 obj-$(CONFIG_ARM_64) += thunderx.o
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 4/6] xen/arm: add OMAP5 kconfig

[Stefano Stabellini]

Add a kconfig option for TI OMAP5 platforms.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
CC: baozich@gmail.com
---
 xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
 xen/arch/arm/platforms/Makefile |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index e54825a..6486bf6 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -60,6 +60,13 @@ config RCAR2
 	---help---
 	Enable all the required drivers for Renesas R-Car Gen2.
 
+config OMAP5
+	bool "TI OMAP5 platforms"
+	depends on ARM_32
+	select HAS_OMAP
+	---help---
+	Enable all the required drivers for TI OMAP5 based platforms.
+
 endchoice
 
 config ALL64_PLAT
@@ -85,3 +92,7 @@ config SUNXI_PLATFORM
 config RCAR2_PLATFORM
 	bool
 	default (ALL32_PLAT || RCAR2)
+
+config OMAP5_PLATFORM
+	bool
+	default (ALL32_PLAT || OMAP5)
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index 27cc383..190a744 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -2,7 +2,7 @@ obj-y += vexpress.o
 obj-$(CONFIG_ARM_32) += brcm.o
 obj-$(CONFIG_ARM_32) += exynos5.o
 obj-$(CONFIG_ARM_32) += midway.o
-obj-$(CONFIG_ARM_32) += omap5.o
+obj-$(CONFIG_OMAP5_PLATFORM)    += omap5.o
 obj-$(CONFIG_RCAR2_PLATFORM)    += rcar2.o
 obj-$(CONFIG_ARM_64) += seattle.o
 obj-$(CONFIG_SUNXI_PLATFORM)    += sunxi.o
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 5/6] xen/arm: make platform specific code dependent on ALL32_PLAT or ALL64_PLAT

[Stefano Stabellini]

Compile platform code that doesn't have its own specific kconfig option
only if ALL32_PLAT or ALL64_PLAT depending on the architecture. The
benefit is that choosing one of the platforms available as a menu
option allows the user not to build other unnecessary platform code.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
---
 xen/arch/arm/platforms/Makefile | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index 190a744..daf0d45 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -1,12 +1,12 @@
 obj-y += vexpress.o
-obj-$(CONFIG_ARM_32) += brcm.o
-obj-$(CONFIG_ARM_32) += exynos5.o
-obj-$(CONFIG_ARM_32) += midway.o
+obj-$(CONFIG_ALL32_PLAT)        += brcm.o
+obj-$(CONFIG_ALL32_PLAT)        += exynos5.o
+obj-$(CONFIG_ALL32_PLAT)        += midway.o
 obj-$(CONFIG_OMAP5_PLATFORM)    += omap5.o
 obj-$(CONFIG_RCAR2_PLATFORM)    += rcar2.o
-obj-$(CONFIG_ARM_64) += seattle.o
+obj-$(CONFIG_ALL64_PLAT)        += seattle.o
 obj-$(CONFIG_SUNXI_PLATFORM)    += sunxi.o
-obj-$(CONFIG_ARM_64) += thunderx.o
+obj-$(CONFIG_ALL64_PLAT)        += thunderx.o
 obj-$(CONFIG_THUNDERX_PLATFORM) += thunderx.o
-obj-$(CONFIG_ARM_64) += xgene-storm.o
-obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp.o
+obj-$(CONFIG_ALL64_PLAT)        += xgene-storm.o
+obj-$(CONFIG_MPSOC_PLATFORM)    += xilinx-zynqmp.o
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 6/6] xen/arm: introduce NO_PLAT

[Stefano Stabellini]

Add a Kconfig option to select no specific platform support.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
---
 xen/arch/arm/platforms/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index 6486bf6..4c8b225 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -67,6 +67,11 @@ config OMAP5
 	---help---
 	Enable all the required drivers for TI OMAP5 based platforms.
 
+config NO_PLAT
+	bool "No Platforms"
+	---help---
+	Do not enable specific support for any platform.
+
 endchoice
 
 config ALL64_PLAT
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 00/10] arm: add one kconfig option per platform

[Julien Grall]

On 24/08/18 00:33, Stefano Stabellini wrote:
> Hi all,

Hi,

> 
> This patch series introduces one kconfig option for each remaing
> platform under platforms/.  Each kconfig option enables the required
> drivers in Xen.
> 
> Cheers,
> 
> Stefano
> 
> Changes in v2:
> - remove all platform options except for thunderx, sunxi, rcar2, omap5

As we discussed yesterday, I would rather not introduce per-platform 
config until we have a real use-case.

It makes sense to have a per-platform config for Omap5 and Rcar2. But I 
don't see a use-case for Thunder-X/Sunxi.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 1/6] xen/arm: add THUNDERX kconfig

[Julien Grall]

Hi,

On 24/08/18 00:33, Stefano Stabellini wrote:
> Add a kconfig option for Cavium ThunderX platforms. >
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> CC: mjaggi@caviumnetworks.com
> CC: Zi.Lim@cavium.com
> ---
> Changes in v2:
> - remove HAS_SMMU
> ---
>   xen/arch/arm/platforms/Kconfig  | 13 +++++++++++++
>   xen/arch/arm/platforms/Makefile |  1 +
>   2 files changed, 14 insertions(+)
> 
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index 409d3f8..b9c0b7f 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -36,6 +36,16 @@ config MPSOC
>   	---help---
>   	Enable all the required drivers for Xilinx Ultrascale+ MPSoC
>   
> +config THUNDERX
> +	bool "Cavium ThunderX"
> +	depends on ARM_64
> +	select GICV3
> +	select HAS_ITS
> +	select HAS_PL011
> +	select ACPI if EXPERT = "y"

Regardless what I said in the cover letter. ACPI should really not be 
selected here. It is not mandatory to use on Thunder-X and the decision 
should be left to the user.

In other words, the platform config should *only* select what is 
mandatory to run a given SoC.

To be honest, I would even consider the UART as optional because a user 
may decide it does not want any output from Xen.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 6/6] xen/arm: introduce NO_PLAT

[Julien Grall]

Hi,

On 24/08/18 00:33, Stefano Stabellini wrote:
> Add a Kconfig option to select no specific platform support.

That's not entirely true. After this series applied, there are still 
some obj-y present in the Makefile.

Cheers,

> 
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> ---
>   xen/arch/arm/platforms/Kconfig | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index 6486bf6..4c8b225 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -67,6 +67,11 @@ config OMAP5
>   	---help---
>   	Enable all the required drivers for TI OMAP5 based platforms.
>   
> +config NO_PLAT
> +	bool "No Platforms"
> +	---help---
> +	Do not enable specific support for any platform.
> +
>   endchoice
>   
>   config ALL64_PLAT
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 3/6] xen/arm: add RCAR2 kconfig

[Julien Grall]

Hi,

On 24/08/18 00:33, Stefano Stabellini wrote:
> Add a kconfig option for Renesas Rcar2 platforms.
> 
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
> CC: iurii.konovalenko@globallogic.com
> ---
>   xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
>   xen/arch/arm/platforms/Makefile |  2 +-
>   2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index a43c938..e54825a 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -53,6 +53,13 @@ config SUNXI
>   	Enable all the required drivers for Allwinnder sunxi platforms,
>   	including Pine64, OrangePi, CubieBoard, etc.
>   
> +config RCAR2
> +	bool "Renesas R-Car Gen2"
> +	depends on ARM_32
> +	select HAS_SCIF
> +	---help---
> +	Enable all the required drivers for Renesas R-Car Gen2.

Technically the UART is not required. By selecting it, you give no way 
to the user to remove it.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 3/6] xen/arm: add RCAR2 kconfig

[Stefano Stabellini]

On Fri, 24 Aug 2018, Julien Grall wrote:
> Hi,
> 
> On 24/08/18 00:33, Stefano Stabellini wrote:
> > Add a kconfig option for Renesas Rcar2 platforms.
> > 
> > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> > Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
> > CC: iurii.konovalenko@globallogic.com
> > ---
> >   xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
> >   xen/arch/arm/platforms/Makefile |  2 +-
> >   2 files changed, 12 insertions(+), 1 deletion(-)
> > 
> > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> > index a43c938..e54825a 100644
> > --- a/xen/arch/arm/platforms/Kconfig
> > +++ b/xen/arch/arm/platforms/Kconfig
> > @@ -53,6 +53,13 @@ config SUNXI
> >   	Enable all the required drivers for Allwinnder sunxi platforms,
> >   	including Pine64, OrangePi, CubieBoard, etc.
> >   +config RCAR2
> > +	bool "Renesas R-Car Gen2"
> > +	depends on ARM_32
> > +	select HAS_SCIF
> > +	---help---
> > +	Enable all the required drivers for Renesas R-Car Gen2.
> 
> Technically the UART is not required. By selecting it, you give no way to the
> user to remove it.

I don't know of a way to select the UART driver by default, which is the
desired configuration for the majority, while still allowing users to
remove it if they want to.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 6/6] xen/arm: introduce NO_PLAT

[Stefano Stabellini]

On Fri, 24 Aug 2018, Julien Grall wrote:
> Hi,
> 
> On 24/08/18 00:33, Stefano Stabellini wrote:
> > Add a Kconfig option to select no specific platform support.
> 
> That's not entirely true. After this series applied, there are still some
> obj-y present in the Makefile.

Sorry I must have been too tired, I missed one change in the previous
patch. :-/


> 
> > 
> > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> > ---
> >   xen/arch/arm/platforms/Kconfig | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> > index 6486bf6..4c8b225 100644
> > --- a/xen/arch/arm/platforms/Kconfig
> > +++ b/xen/arch/arm/platforms/Kconfig
> > @@ -67,6 +67,11 @@ config OMAP5
> >   	---help---
> >   	Enable all the required drivers for TI OMAP5 based platforms.
> >   +config NO_PLAT
> > +	bool "No Platforms"
> > +	---help---
> > +	Do not enable specific support for any platform.
> > +
> >   endchoice
> >     config ALL64_PLAT
> > 
> 
> -- 
> Julien Grall
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 00/10] arm: add one kconfig option per platform

[Stefano Stabellini]

On Fri, 24 Aug 2018, Julien Grall wrote:
> On 24/08/18 00:33, Stefano Stabellini wrote:
> > Hi all,
> 
> Hi,
> 
> > 
> > This patch series introduces one kconfig option for each remaing
> > platform under platforms/.  Each kconfig option enables the required
> > drivers in Xen.
> > 
> > Cheers,
> > 
> > Stefano
> > 
> > Changes in v2:
> > - remove all platform options except for thunderx, sunxi, rcar2, omap5
> 
> As we discussed yesterday, I would rather not introduce per-platform config
> until we have a real use-case.
> 
> It makes sense to have a per-platform config for Omap5 and Rcar2. But I don't
> see a use-case for Thunder-X/Sunxi.

There is an argument that Thunder-X is a server platform, hence, there
is no need to do a tailored kconfig for it.

But I think that Sunxi would be nice to have as there are several
embedded boards out there using it. I know of a few people using Sunxi
embedded boards with Xen today in their business.

What if I remove the Thunder-X specific option but I keep the Sunxi
option?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 3/6] xen/arm: add RCAR2 kconfig

[Julien Grall]

(Switching to my Arm e-mail)

Hi,

On 24/08/18 20:31, Stefano Stabellini wrote:
> On Fri, 24 Aug 2018, Julien Grall wrote:
>> Hi,
>>
>> On 24/08/18 00:33, Stefano Stabellini wrote:
>>> Add a kconfig option for Renesas Rcar2 platforms.
>>>
>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
>>> Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
>>> CC: iurii.konovalenko@globallogic.com
>>> ---
>>>    xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
>>>    xen/arch/arm/platforms/Makefile |  2 +-
>>>    2 files changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
>>> index a43c938..e54825a 100644
>>> --- a/xen/arch/arm/platforms/Kconfig
>>> +++ b/xen/arch/arm/platforms/Kconfig
>>> @@ -53,6 +53,13 @@ config SUNXI
>>>    	Enable all the required drivers for Allwinnder sunxi platforms,
>>>    	including Pine64, OrangePi, CubieBoard, etc.
>>>    +config RCAR2
>>> +	bool "Renesas R-Car Gen2"
>>> +	depends on ARM_32
>>> +	select HAS_SCIF
>>> +	---help---
>>> +	Enable all the required drivers for Renesas R-Car Gen2.
>>
>> Technically the UART is not required. By selecting it, you give no way to the
>> user to remove it.
> 
> I don't know of a way to select the UART driver by default, which is the
> desired configuration for the majority, while still allowing users to
> remove it if they want to.

You can't do this directly with Kconfig. Linux is solving the problem by 
introducing "config fragment" and using scripts/kconfig/merge_config.sh 
to merge the fragments.

The scripts exists on Xen in xen/xen/tools/kconfig/. So if you provide
a fragment for tiny and R-Car, you could merge both in a single one.

This would also give the freedom for the user to tailor a bit more his 
.config.

Cheers,

> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 00/10] arm: add one kconfig option per platform

[Julien Grall]

Hi,

On 24/08/18 20:38, Stefano Stabellini wrote:
> On Fri, 24 Aug 2018, Julien Grall wrote:
>> On 24/08/18 00:33, Stefano Stabellini wrote:
>>> Hi all,
>>
>> Hi,
>>
>>>
>>> This patch series introduces one kconfig option for each remaing
>>> platform under platforms/.  Each kconfig option enables the required
>>> drivers in Xen.
>>>
>>> Cheers,
>>>
>>> Stefano
>>>
>>> Changes in v2:
>>> - remove all platform options except for thunderx, sunxi, rcar2, omap5
>>
>> As we discussed yesterday, I would rather not introduce per-platform config
>> until we have a real use-case.
>>
>> It makes sense to have a per-platform config for Omap5 and Rcar2. But I don't
>> see a use-case for Thunder-X/Sunxi.
> 
> There is an argument that Thunder-X is a server platform, hence, there
> is no need to do a tailored kconfig for it.
> 
> But I think that Sunxi would be nice to have as there are several
> embedded boards out there using it. I know of a few people using Sunxi
> embedded boards with Xen today in their business.
> 
> What if I remove the Thunder-X specific option but I keep the Sunxi
> option?

I guess I could be convinced with Sunxi.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 3/6] xen/arm: add RCAR2 kconfig

[Stefano Stabellini]

On Tue, 28 Aug 2018, Julien Grall wrote:
> (Switching to my Arm e-mail)
> 
> Hi,
> 
> On 24/08/18 20:31, Stefano Stabellini wrote:
> > On Fri, 24 Aug 2018, Julien Grall wrote:
> > > Hi,
> > > 
> > > On 24/08/18 00:33, Stefano Stabellini wrote:
> > > > Add a kconfig option for Renesas Rcar2 platforms.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> > > > Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
> > > > CC: iurii.konovalenko@globallogic.com
> > > > ---
> > > >    xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
> > > >    xen/arch/arm/platforms/Makefile |  2 +-
> > > >    2 files changed, 12 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/xen/arch/arm/platforms/Kconfig
> > > > b/xen/arch/arm/platforms/Kconfig
> > > > index a43c938..e54825a 100644
> > > > --- a/xen/arch/arm/platforms/Kconfig
> > > > +++ b/xen/arch/arm/platforms/Kconfig
> > > > @@ -53,6 +53,13 @@ config SUNXI
> > > >    	Enable all the required drivers for Allwinnder sunxi
> > > > platforms,
> > > >    	including Pine64, OrangePi, CubieBoard, etc.
> > > >    +config RCAR2
> > > > +	bool "Renesas R-Car Gen2"
> > > > +	depends on ARM_32
> > > > +	select HAS_SCIF
> > > > +	---help---
> > > > +	Enable all the required drivers for Renesas R-Car Gen2.
> > > 
> > > Technically the UART is not required. By selecting it, you give no way to
> > > the
> > > user to remove it.
> > 
> > I don't know of a way to select the UART driver by default, which is the
> > desired configuration for the majority, while still allowing users to
> > remove it if they want to.
> 
> You can't do this directly with Kconfig. Linux is solving the problem by
> introducing "config fragment" and using scripts/kconfig/merge_config.sh to
> merge the fragments.
> 
> The scripts exists on Xen in xen/xen/tools/kconfig/. So if you provide
> a fragment for tiny and R-Car, you could merge both in a single one.
> 
> This would also give the freedom for the user to tailor a bit more his
> .config.

I don't mind the config fragment approach but it is very low on my
priority list at the moment. We discussed removing the selects from the
new platform kconfigs, but I am now thinking of dropping the platform
specific options introduced by the series altogether and only send the
ALL32_PLAT, ALL64_PLAT and NO_PLAT options (only the last 2 patches).


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel