From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
grub-devel@gnu.org, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, eric.snowberg@oracle.com,
seth.goldberg@oracle.com, arvidjaar@gmail.com, phcoder@gmail.com
Subject: Re: [MULTIBOOT2 DOC PATCH 06/10] multiboot2: Add description of support for relocatable images
Date: Thu, 9 Jun 2016 22:36:29 +0100 [thread overview]
Message-ID: <33053e4b-2c66-dc4f-6e5a-bfcb05bde590@citrix.com> (raw)
In-Reply-To: <1465504244-17175-7-git-send-email-daniel.kiper@oracle.com>
On 09/06/2016 21:30, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> doc/multiboot.texi | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> doc/multiboot2.h | 24 ++++++++++++++++++++++
> 2 files changed, 80 insertions(+)
>
> diff --git a/doc/multiboot.texi b/doc/multiboot.texi
> index 130176a..f1e0e09 100644
> --- a/doc/multiboot.texi
> +++ b/doc/multiboot.texi
> @@ -359,6 +359,7 @@ executable header.
> * Console header tags::
> * Module alignment tag::
> * EFI boot services tag::
> +* Relocatable header tag::
>
> @end menu
>
> @@ -681,6 +682,47 @@ u32 | size = 8 |
> This tag indicates that payload supports starting without
> terminating boot services.
>
> +@node Relocatable header tag
> +@subsection Relocatable header tag
> +
> +@example
> +@group
> + +-------------------+
> +u16 | type = 10 |
> +u16 | flags |
> +u32 | size = 24 |
> +u32 | min_addr |
> +u32 | max_addr |
> +u32 | align |
> +u32 | preference |
> + +-------------------+
> +@end group
> +@end example
> +
> +This tag indicates that image is relocatable.
> +
> +The meaning of each field is as follows:
> +
> +@table @code
> +@item min_addr
> +Lowest possible physical address at which image should be loaded.
> +Boot loader cannot load any part of image below this address.
"The bootloader".
> +
> +@item max_addr
> +Highest possible physical address at which loaded image should end.
> +Boot loader cannot load any part of image above this address.
"The bootloader".
> +
> +@item align
> +Image alignment in memory, e.g. 4096 (know on many machines as page).
I would drop the qualification in brackets. It isn't helpful to the
intended audience.
> +
> +@item preference
> +It contains load address placement suggestion for boot loader.
> +Boot loader should follow it. @samp{0} means none, @samp{1} means
> +load image at lowest possible address but not lower than min_addr
> +and @samp{2} means load image at highest possible address but not
> +higher than max_addr.
> +@end table
> +
> @node Machine state
> @section MIPS machine state
>
> @@ -1309,6 +1351,20 @@ u64 | pointer |
> This tag contains pointer to EFI amd64 image handle.
> Usually it is boot loader image handle.
>
> +@subsection Image load base physical address
> +@example
> +@group
> + +-------------------+
> +u32 | type = 21 |
> +u32 | size = 12 |
> +u32 | load_base_addr |
> + +-------------------+
> +@end group
> +@end example
> +
> +This tag contains image load base physical address. It is
> +provided only if image has relocatable header tag.
> +
> @node Examples
> @chapter Examples
>
> diff --git a/doc/multiboot2.h b/doc/multiboot2.h
> index b85cb13..b181607 100644
> --- a/doc/multiboot2.h
> +++ b/doc/multiboot2.h
> @@ -62,6 +62,7 @@
> #define MULTIBOOT_TAG_TYPE_EFI_BS 18
> #define MULTIBOOT_TAG_TYPE_EFI32_IH 19
> #define MULTIBOOT_TAG_TYPE_EFI64_IH 20
> +#define MULTIBOOT_TAG_TYPE_LOAD_BASE_ADDR 21
>
> #define MULTIBOOT_HEADER_TAG_END 0
> #define MULTIBOOT_HEADER_TAG_INFORMATION_REQUEST 1
> @@ -73,11 +74,16 @@
> #define MULTIBOOT_HEADER_TAG_EFI_BS 7
> #define MULTIBOOT_HEADER_TAG_ENTRY_ADDRESS_EFI32 8
> #define MULTIBOOT_HEADER_TAG_ENTRY_ADDRESS_EFI64 9
> +#define MULTIBOOT_HEADER_TAG_RELOCATABLE 10
>
> #define MULTIBOOT_ARCHITECTURE_I386 0
> #define MULTIBOOT_ARCHITECTURE_MIPS32 4
> #define MULTIBOOT_HEADER_TAG_OPTIONAL 1
>
> +#define MULTIBOOT_LOAD_PREFERENCE_NONE 0
> +#define MULTIBOOT_LOAD_PREFERENCE_LOW 1
> +#define MULTIBOOT_LOAD_PREFERENCE_HIGH 2
> +
> #define MULTIBOOT_CONSOLE_FLAGS_CONSOLE_REQUIRED 1
> #define MULTIBOOT_CONSOLE_FLAGS_EGA_TEXT_SUPPORTED 2
>
> @@ -162,6 +168,17 @@ struct multiboot_header_tag_module_align
> multiboot_uint32_t size;
> };
>
> +struct multiboot_header_tag_relocatable
> +{
> + multiboot_uint16_t type;
> + multiboot_uint16_t flags;
> + multiboot_uint32_t size;
> + multiboot_uint32_t min_addr;
> + multiboot_uint32_t max_addr;
64bit multiboot2 payloads could reasonably expect to be able to have
themselves relocated about the 4G boundary.
~Andrew
> + multiboot_uint32_t align;
> + multiboot_uint32_t preference;
> +};
> +
> struct multiboot_color
> {
> multiboot_uint8_t red;
> @@ -388,6 +405,13 @@ struct multiboot_tag_efi64_ih
> multiboot_uint64_t pointer;
> };
>
> +struct multiboot_tag_load_base_addr
> +{
> + multiboot_uint32_t type;
> + multiboot_uint32_t size;
> + multiboot_uint32_t load_base_addr;
> +};
> +
> #endif /* ! ASM_FILE */
>
> #endif /* ! MULTIBOOT_HEADER */
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-09 21:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1465504244-17175-1-git-send-email-daniel.kiper@oracle.com>
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 01/10] multiboot2: Remove redundant if Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 02/10] multiboot2: Clarify meaning of information request header tag Daniel Kiper
2016-06-09 21:14 ` Andrew Cooper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 03/10] multiboot2: Fix description of EFI boot services tag Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 04/10] multiboot2: Add description of support for EFI boot services Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 05/10] multiboot2: Add description of EFI image handle tags Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 06/10] multiboot2: Add description of support for relocatable images Daniel Kiper
2016-06-09 21:36 ` Andrew Cooper [this message]
2016-06-10 17:36 ` Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 07/10] multiboot2: Say that memory maps may not be available on EFI platforms Daniel Kiper
2016-06-09 21:37 ` Andrew Cooper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 08/10] multiboot2: Add C structure alignment and padding consideration section Daniel Kiper
2016-06-09 22:07 ` Andrew Cooper
[not found] ` <1c1e54de-2f19-20b6-b8c8-229619b95038@citrix.com>
2016-06-10 17:58 ` Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 09/10] multiboot2: Add me to authors Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 10/10] multiboot2: Bump version to 2.0 Daniel Kiper
[not found] ` <1465504244-17175-2-git-send-email-daniel.kiper@oracle.com>
2016-06-09 21:02 ` [MULTIBOOT2 DOC PATCH 01/10] multiboot2: Remove redundant if Andrew Cooper
[not found] ` <1465504244-17175-5-git-send-email-daniel.kiper@oracle.com>
2016-06-09 21:31 ` [MULTIBOOT2 DOC PATCH 04/10] multiboot2: Add description of support for EFI boot services Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33053e4b-2c66-dc4f-6e5a-bfcb05bde590@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=arvidjaar@gmail.com \
--cc=daniel.kiper@oracle.com \
--cc=eric.snowberg@oracle.com \
--cc=grub-devel@gnu.org \
--cc=jgross@suse.com \
--cc=phcoder@gmail.com \
--cc=seth.goldberg@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).