From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
Paul Durrant <paul@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 08/11] x86/dpci: switch to use a GSI EOI callback
Date: Thu, 8 Apr 2021 16:49:48 +0200 [thread overview]
Message-ID: <47616bd4-2e3e-92ea-73de-8ea6fb1992ed@suse.com> (raw)
In-Reply-To: <20210331103303.79705-9-roger.pau@citrix.com>
On 31.03.2021 12:33, Roger Pau Monne wrote:
> @@ -515,17 +528,44 @@ int pt_irq_create_bind(
> }
> else
> {
> + /*
> + * NB: the callback structure allocated below will never be freed
> + * once setup because it's used by the hardware domain and will
> + * never be unregistered.
> + */
> + cb = xmalloc(struct hvm_gsi_eoi_callback);
Is this comment as well as ...
> ASSERT(is_hardware_domain(d));
>
> + if ( !cb )
> + {
> + spin_unlock(&d->event_lock);
> + return -ENOMEM;
> + }
> +
> /* MSI_TRANSLATE is not supported for the hardware domain. */
> if ( pt_irq_bind->irq_type != PT_IRQ_TYPE_PCI ||
> pirq >= hvm_domain_irq(d)->nr_gsis )
> {
> spin_unlock(&d->event_lock);
> -
> + xfree(cb);
> return -EINVAL;
> }
> guest_gsi = pirq;
> +
> + cb->callback = dpci_eoi;
> + cb->data = d;
> + /*
> + * IRQ binds created for the hardware domain are never destroyed,
> + * so it's fine to not keep a reference to cb here.
> + */
> + rc = hvm_gsi_register_callback(d, guest_gsi, cb);
... the one here really true? vpci_msi_arch_update() and
vpci_msi_disable() seem to tell me otherwise (or for the former
comment, they suggest there should be un-registration somewhere).
It also doesn't seem logical to me, considering (yet to be made
work) pass-through of devices or hot-unplugged ones, at which
point Dom0 shouldn't retain IRQ bindings, I would think.
Jan
next prev parent reply other threads:[~2021-04-08 14:50 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 10:32 [PATCH v3 00/11] x86/intr: introduce EOI callbacks and fix vPT Roger Pau Monne
2021-03-31 10:32 ` [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks Roger Pau Monne
2021-03-31 16:02 ` Jan Beulich
2021-03-31 16:24 ` Andrew Cooper
2021-04-01 9:12 ` Roger Pau Monné
2021-04-01 11:06 ` Jan Beulich
2021-04-07 7:41 ` Roger Pau Monné
2021-04-07 8:19 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic " Roger Pau Monne
2021-03-31 16:04 ` Jan Beulich
2021-04-01 9:15 ` Roger Pau Monné
2021-04-01 9:28 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism Roger Pau Monne
2021-03-31 11:47 ` Andrew Cooper
2021-03-31 12:50 ` Roger Pau Monné
2021-04-07 14:55 ` Jan Beulich
2021-04-07 16:27 ` Roger Pau Monné
2021-04-08 6:20 ` Jan Beulich
2021-04-08 9:12 ` Roger Pau Monné
2021-04-08 10:49 ` Jan Beulich
2021-04-08 10:56 ` Roger Pau Monné
2021-03-31 10:32 ` [PATCH v3 04/11] x86/vmsi: use the newly introduced EOI callbacks Roger Pau Monne
2021-04-07 14:59 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism Roger Pau Monne
2021-04-07 15:19 ` Jan Beulich
2021-04-07 16:46 ` Roger Pau Monné
2021-04-08 6:27 ` Jan Beulich
2021-04-08 8:59 ` Roger Pau Monné
2021-04-08 10:52 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs Roger Pau Monne
2021-04-07 15:51 ` Jan Beulich
2021-04-07 17:08 ` Roger Pau Monné
2021-04-08 6:34 ` Jan Beulich
2021-04-15 16:04 ` Roger Pau Monné
2021-04-16 7:29 ` Jan Beulich
2021-04-19 8:31 ` Roger Pau Monné
2021-04-08 12:52 ` Roger Pau Monné
2021-04-08 14:31 ` Jan Beulich
2021-04-08 15:06 ` Roger Pau Monné
2021-03-31 10:32 ` [PATCH v3 07/11] x86/dpci: move code Roger Pau Monne
2021-03-31 10:33 ` [PATCH v3 08/11] x86/dpci: switch to use a GSI EOI callback Roger Pau Monne
2021-04-08 14:49 ` Jan Beulich [this message]
2021-04-08 15:23 ` Roger Pau Monné
2021-03-31 10:33 ` [PATCH v3 09/11] x86/vpt: switch interrupt injection model Roger Pau Monne
2021-04-14 10:28 ` Jan Beulich
2021-04-14 13:37 ` Roger Pau Monné
2021-04-14 14:05 ` Jan Beulich
2021-04-14 14:20 ` Roger Pau Monné
2021-03-31 10:33 ` [PATCH v3 10/11] x86/vpt: remove vPT timers per-vCPU lists Roger Pau Monne
2021-04-14 10:38 ` Jan Beulich
2021-03-31 10:33 ` [PATCH v3 11/11] x86/vpt: introduce a per-vPT lock Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47616bd4-2e3e-92ea-73de-8ea6fb1992ed@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).