From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 10/11] x86/vpt: remove vPT timers per-vCPU lists
Date: Wed, 14 Apr 2021 12:38:20 +0200 [thread overview]
Message-ID: <5d80d406-6275-3de4-8734-a0204151a34c@suse.com> (raw)
In-Reply-To: <20210331103303.79705-11-roger.pau@citrix.com>
On 31.03.2021 12:33, Roger Pau Monne wrote:
> No longer add vPT timers to lists on specific vCPUs, since there's no
> need anymore to check if timer interrupts have been injected on return
> to HVM guest.
>
> Such change allows to get rid of virtual timers vCPU migration, and
> also cleanup some of the virtual timers fields that are no longer
> required.
>
> The model is also slightly different now in that timers are not
> stopped when a vCPU is de-scheduled. Such timers will continue
> running, and when triggered the function will try to inject the
> corresponding interrupt to the guest (which might be different than
> the currently running one). Note that the timer triggering when the
> guest is no longer running can only happen once, as the timer callback
> will not reset the interrupt to fire again. Such resetting if required
> will be done by the EOI callback.
>
> Since virtual timers are no longer added to per-VCPU lists when active
> a new 'masked' field is added to the structure, to signal whether a
> timer has it's interrupt source currently masked.
I guess this paragraph has become stale with ...
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Changes since v2:
> - Remove pt_{save/restore}_timer and instead use
> pt_{freeze/thaw}_time.
> - Remove the introduction of the 'masked' field, it's not needed.
... this change?
Other than this
Reviewed-by: Jan Beulich <jbeulich@suse.com>
> - Rework pt_active to use timer_is_active.
>
> Changes since v1:
> - New in this version.
> ---
> xen/arch/x86/domain.c | 4 +-
> xen/arch/x86/hvm/hvm.c | 4 +-
> xen/arch/x86/hvm/vlapic.c | 1 -
> xen/arch/x86/hvm/vpt.c | 174 ++++-----------------------------
> xen/include/asm-x86/hvm/vcpu.h | 3 +-
> xen/include/asm-x86/hvm/vpt.h | 12 +--
> 6 files changed, 27 insertions(+), 171 deletions(-)
Yet nicer than the previous one!
Jan
next prev parent reply other threads:[~2021-04-14 10:38 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 10:32 [PATCH v3 00/11] x86/intr: introduce EOI callbacks and fix vPT Roger Pau Monne
2021-03-31 10:32 ` [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks Roger Pau Monne
2021-03-31 16:02 ` Jan Beulich
2021-03-31 16:24 ` Andrew Cooper
2021-04-01 9:12 ` Roger Pau Monné
2021-04-01 11:06 ` Jan Beulich
2021-04-07 7:41 ` Roger Pau Monné
2021-04-07 8:19 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic " Roger Pau Monne
2021-03-31 16:04 ` Jan Beulich
2021-04-01 9:15 ` Roger Pau Monné
2021-04-01 9:28 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism Roger Pau Monne
2021-03-31 11:47 ` Andrew Cooper
2021-03-31 12:50 ` Roger Pau Monné
2021-04-07 14:55 ` Jan Beulich
2021-04-07 16:27 ` Roger Pau Monné
2021-04-08 6:20 ` Jan Beulich
2021-04-08 9:12 ` Roger Pau Monné
2021-04-08 10:49 ` Jan Beulich
2021-04-08 10:56 ` Roger Pau Monné
2021-03-31 10:32 ` [PATCH v3 04/11] x86/vmsi: use the newly introduced EOI callbacks Roger Pau Monne
2021-04-07 14:59 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism Roger Pau Monne
2021-04-07 15:19 ` Jan Beulich
2021-04-07 16:46 ` Roger Pau Monné
2021-04-08 6:27 ` Jan Beulich
2021-04-08 8:59 ` Roger Pau Monné
2021-04-08 10:52 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs Roger Pau Monne
2021-04-07 15:51 ` Jan Beulich
2021-04-07 17:08 ` Roger Pau Monné
2021-04-08 6:34 ` Jan Beulich
2021-04-15 16:04 ` Roger Pau Monné
2021-04-16 7:29 ` Jan Beulich
2021-04-19 8:31 ` Roger Pau Monné
2021-04-08 12:52 ` Roger Pau Monné
2021-04-08 14:31 ` Jan Beulich
2021-04-08 15:06 ` Roger Pau Monné
2021-03-31 10:32 ` [PATCH v3 07/11] x86/dpci: move code Roger Pau Monne
2021-03-31 10:33 ` [PATCH v3 08/11] x86/dpci: switch to use a GSI EOI callback Roger Pau Monne
2021-04-08 14:49 ` Jan Beulich
2021-04-08 15:23 ` Roger Pau Monné
2021-03-31 10:33 ` [PATCH v3 09/11] x86/vpt: switch interrupt injection model Roger Pau Monne
2021-04-14 10:28 ` Jan Beulich
2021-04-14 13:37 ` Roger Pau Monné
2021-04-14 14:05 ` Jan Beulich
2021-04-14 14:20 ` Roger Pau Monné
2021-03-31 10:33 ` [PATCH v3 10/11] x86/vpt: remove vPT timers per-vCPU lists Roger Pau Monne
2021-04-14 10:38 ` Jan Beulich [this message]
2021-03-31 10:33 ` [PATCH v3 11/11] x86/vpt: introduce a per-vPT lock Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d80d406-6275-3de4-8734-a0204151a34c@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).