Re: [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service

From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Lars Kurth <lars.kurth@citrix.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Dong Eddie <eddie.dong@intel.com>,
	xen devel <xen-devel@lists.xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service
Date: Mon, 28 Mar 2016 11:52:55 +0800	[thread overview]
Message-ID: <56F8AA97.6000007@cn.fujitsu.com> (raw)
In-Reply-To: <20160325155143.GB21775@citrix.com>

On 03/25/2016 11:51 PM, Wei Liu wrote:
> On Fri, Mar 25, 2016 at 02:44:07PM +0800, Changlong Xie wrote:
>> This patchset implemented the COLO feature for Xen.
>> For detail/install/use of COLO feature, refer to:
>> http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping
>>
>> You can get the codes from here:
>> https://github.com/Pating/xen/tree/changlox/colo_v13
>>
>> Changlog from v12 to v13
>> 1. Rebase to the upstream xen
>> 2. Address commnets from Ian and Liu Wei.
>> p7, Add A-B
>> p8, Add A-B
>> p10, Add A-B
>> p11, Add A-B
>> p12, Add LOG(ERROR, )
>> p13, Add A-B
>> p14, Remove libxl__ao_complete(xxx)
>> p15, Add A-B
>> p16, Add A-B
>> p17, Add A-B, replace "-c" with "--colo" for migrate-receive()
>> p19, Add A-B, introduce "switch ... case ..."
>> p21, Add A-B
>> p22, Add A-B
>> p23, replace "forwarddev" with "coloft_fowarddev"
>> p24, Add A-B
>> p25, Add A-B
>> p26, replace "--script" with "--coloft-script"
>
> I went over those unacked patches. The major thing I found is that you
> didn't add in the warning text as Ian suggested. I've pointed out one
> instance where you should add that. However, xl manage and libxl header
> file changes are spread across multiple commits, so I'm not quite sure
> which particular commit you should add in warning text.
>

https://github.com/Pating/xen/tree/changlox/colo_v13_fixup

I just update p20, p23, p26 as Ian suggested

Thanks
	-Xie
> I propose that you submit a separate patch to xl manpage and libxl
> header file for adding warning text after the majority part of this
> series is merged.
>
> Wei.
>
>
> .
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel