From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wl@xen.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT
Date: Wed, 14 Aug 2019 13:06:39 +0100 [thread overview]
Message-ID: <572631ef-5f81-ad13-38c5-6d1dd8e31ce3@citrix.com> (raw)
In-Reply-To: <20190814120052.cyimf6ya3eojpyvp@liuwe-gateway.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net>
On 14/08/2019 13:00, Wei Liu wrote:
> On Wed, Aug 14, 2019 at 11:44:04AM +0100, Andrew Cooper wrote:
> [...]
>> diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h
>> index 22dc795eea..35705441ff 100644
>> --- a/xen/include/asm-x86/config.h
>> +++ b/xen/include/asm-x86/config.h
>> @@ -56,6 +56,11 @@
>> #define GLOBAL(name) \
>> .globl name; \
>> name:
>> +
>> +#define ENDDATA(name) \
>> + .type name, STT_OBJECT; \
> Isn't the correct syntax
>
> .type name STT_OBJECT;
>
> ?
>
> The comma shouldn't be there according to as manual.
Huh. I'd not even noticed that. We use a comma with .type everywhere in
Xen, including when using STT_* notation rather than the @ variants.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-14 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:44 [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT Andrew Cooper
2019-08-14 12:00 ` Wei Liu
2019-08-14 12:06 ` Andrew Cooper [this message]
2019-08-27 14:33 ` Jan Beulich
2019-08-27 14:36 ` Jan Beulich
2019-08-28 18:24 ` Andrew Cooper
2019-08-29 7:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572631ef-5f81-ad13-38c5-6d1dd8e31ce3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).