From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT
Date: Tue, 27 Aug 2019 16:36:30 +0200 [thread overview]
Message-ID: <c5fa4def-f574-e37e-1973-02a3d1931c2d@suse.com> (raw)
In-Reply-To: <20190814104404.17739-1-andrew.cooper3@citrix.com>
On 14.08.2019 12:44, Andrew Cooper wrote:
> Introduce a new ENDDATA() helper which sets type and size together.
Except this isn't very natural: Setting the size late is quite
common, to avoid the need for an "end" label. But the type would
better be set together with the label definition, i.e. by a
GLOBAL() counterpart (e.g. GLOBAL_DATA()). However, if despite
this remark you think your approach is the way to go:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-27 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:44 [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT Andrew Cooper
2019-08-14 12:00 ` Wei Liu
2019-08-14 12:06 ` Andrew Cooper
2019-08-27 14:33 ` Jan Beulich
2019-08-27 14:36 ` Jan Beulich [this message]
2019-08-28 18:24 ` Andrew Cooper
2019-08-29 7:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5fa4def-f574-e37e-1973-02a3d1931c2d@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).