From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>,
Wei Chen <wei.chen@linaro.org>
Subject: Re: [PATCH V6 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS
Date: Tue, 7 Jun 2016 15:09:40 +0100 [thread overview]
Message-ID: <5756D5A4.6060203@arm.com> (raw)
In-Reply-To: <5756D44E.6010001@codeaurora.org>
On 07/06/16 15:03, Shanker Donthineni wrote:
> Hi Julien,
>
> On 06/07/2016 08:58 AM, Julien Grall wrote:
>> Hello Shanker,
>>
>> On 06/06/16 23:58, Shanker Donthineni wrote:
>>> The Masked interrupt status register (UARTMIS) is not described in ARM
>>> SBSA 2.x document. Anding of two registers UARTMSC and UARTRIS values
>>> gives the same information as register UARTMIS.
>>>
>>> UARTRIS, UARTMSC and UARTMIS definitions are found in PrimeCell UART
>>> PL011 (Revision: r1p4).
>>> - 3.3.10 Interrupt mask set/clear register, UARTIMSC
>>> - 3.3.11 Raw interrupt status register, UARTRIS
>>> - 3.3.12 Masked interrupt status register, UARTMIS
>>>
>>> This change is necessary for driver to be SBSA compliant v2.x without
>>> affecting the current driver functionality.
>>>
>>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
>>> ---
>>> Fixed typo in commit text.
>>>
>>> xen/drivers/char/pl011.c | 7 +++++--
>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c
>>> index 6a3c21b..755a965 100644
>>> --- a/xen/drivers/char/pl011.c
>>> +++ b/xen/drivers/char/pl011.c
>>> @@ -57,7 +57,10 @@ static void pl011_interrupt(int irq, void *data, struct cpu_user_regs *regs)
>>> {
>>> struct serial_port *port = data;
>>> struct pl011 *uart = port->uart;
>>> - unsigned int status = pl011_read(uart, MIS);
>>> + unsigned int status;
>>> +
>>> + /* UARTMIS is not documented in SBSA v2.x, so using UARTRIS/UARTIMSC */
>>> + status = pl011_read(uart, RIS) & pl011_read(uart, IMSC);
>>
>> Please use an helper here to avoid code duplication and have the comment in both place.
>>
> Sure, I'll move to a separate function 'pl011_intr_status(uart)'. Do you have any other comment?
None so far.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 22:58 [PATCH V6 1/3] drivers/pl011: Don't configure baudrate Shanker Donthineni
2016-06-06 22:58 ` [PATCH V6 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS Shanker Donthineni
2016-06-07 13:58 ` Julien Grall
2016-06-07 14:03 ` Shanker Donthineni
2016-06-07 14:09 ` Julien Grall [this message]
2016-06-06 22:59 ` [PATCH V6 3/3] arm/acpi: Add Server Base System Architecture UART support Shanker Donthineni
2016-06-07 14:09 ` Julien Grall
2016-06-07 14:00 ` [PATCH V6 1/3] drivers/pl011: Don't configure baudrate Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756D5A4.6060203@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).