From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Michał Kowalczyk" <mkow@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: "Wei Liu" <wl@xen.org>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup
Date: Mon, 19 Aug 2019 18:28:43 +0100 [thread overview]
Message-ID: <5e31c8e1-878a-3302-1b29-022f56f95b3d@citrix.com> (raw)
In-Reply-To: <1bbeb58d-c5d8-3da1-47c0-bd54b40afda4@invisiblethingslab.com>
On 19/08/2019 14:56, Michał Kowalczyk wrote:
> On 8/19/19 3:52 PM, Andrew Cooper wrote:
>> On 19/08/2019 14:50, Michał Kowalczyk wrote:
>>> On 8/19/19 11:04 AM, Andrew Cooper wrote:
>>>> On 19/08/2019 03:23, Michał Kowalczyk wrote:
>>>>> diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S
>>>>> index 7c6a2328d2..fcaa3eeaf1 100644
>>>>> --- a/xen/arch/x86/boot/trampoline.S
>>>>> +++ b/xen/arch/x86/boot/trampoline.S
>>>>> @@ -85,7 +85,7 @@ trampoline_gdt:
>>>>> .long trampoline_gdt + BOOT_PSEUDORM_DS + 2 - .
>>>>> .popsection
>>>>>
>>>>> -GLOBAL(trampoline_misc_enable_off)
>>>>> +GLOBAL(misc_enable_off)
>>>> The overall change is fine, but why have you renamed this variable?
>>> The old name had "trampoline_" prefix because the only place where it
>>> was used was trampoline_protmode_entry in arch/x86/boot/trampoline.S.
>>> Now it's also used in the wakeup code, so I removed the prefix which
>>> could be (IMO) misleading.
>>>> Without the rename, the patch would be just the single hunk in wakeup.S
>>>> and therefore easier to backport.
>>> True. Anyway, the decision is on your side, I can leave the old name if
>>> you prefer.
>> The trampoline_ prefix indicates where the data lives, which is in the
>> 16 bit trampoline which contains both the AP boot path, and wakeup path.
> Ah, if this is the convention you use then we should leave the old name.
>> If you're happy with this, I can adjust on commit to avoid you sending a
>> second time.
> Would be great, thanks!
Done.
https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=c3cfa5b3084d71bccd8360d044bea813688b587c
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-19 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 2:23 [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup Michał Kowalczyk
2019-08-19 9:04 ` Andrew Cooper
2019-08-19 13:50 ` Michał Kowalczyk
2019-08-19 13:52 ` Andrew Cooper
2019-08-19 13:56 ` Michał Kowalczyk
2019-08-19 17:28 ` Andrew Cooper [this message]
2019-08-19 18:01 ` Michał Kowalczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e31c8e1-878a-3302-1b29-022f56f95b3d@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=mkow@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).