From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Michał Kowalczyk" <mkow@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: "Wei Liu" <wl@xen.org>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup
Date: Mon, 19 Aug 2019 10:04:19 +0100 [thread overview]
Message-ID: <93632bab-f393-0c9c-94a8-dc18a06d873e@citrix.com> (raw)
In-Reply-To: <1c917278029b206317a2155fb78e63ed14b621e5.1566176127.git.mkow@invisiblethingslab.com>
On 19/08/2019 03:23, Michał Kowalczyk wrote:
> diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S
> index 7c6a2328d2..fcaa3eeaf1 100644
> --- a/xen/arch/x86/boot/trampoline.S
> +++ b/xen/arch/x86/boot/trampoline.S
> @@ -85,7 +85,7 @@ trampoline_gdt:
> .long trampoline_gdt + BOOT_PSEUDORM_DS + 2 - .
> .popsection
>
> -GLOBAL(trampoline_misc_enable_off)
> +GLOBAL(misc_enable_off)
The overall change is fine, but why have you renamed this variable?
Without the rename, the patch would be just the single hunk in wakeup.S
and therefore easier to backport.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-19 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 2:23 [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup Michał Kowalczyk
2019-08-19 9:04 ` Andrew Cooper [this message]
2019-08-19 13:50 ` Michał Kowalczyk
2019-08-19 13:52 ` Andrew Cooper
2019-08-19 13:56 ` Michał Kowalczyk
2019-08-19 17:28 ` Andrew Cooper
2019-08-19 18:01 ` Michał Kowalczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93632bab-f393-0c9c-94a8-dc18a06d873e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=mkow@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).