xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [Xen-devel] [PATCH] x86: "spec-ctrl=no-xen" should also disable branch hardening
@ 2020-02-19  8:12 Jan Beulich
  2020-02-19 16:39 ` Andrew Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2020-02-19  8:12 UTC (permalink / raw)
  To: xen-devel; +Cc: Andrew Cooper, Jin Nan Wang, Wei Liu, Roger Pau Monné

This is controlling Xen behavior alone, after all.

Reported-by: Jin Nan Wang <jnwang@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -98,8 +98,6 @@ static int __init parse_spec_ctrl(const
             if ( opt_pv_l1tf_domu < 0 )
                 opt_pv_l1tf_domu = 0;
 
-            opt_branch_harden = false;
-
             if ( opt_tsx == -1 )
                 opt_tsx = -3;
 
@@ -114,6 +112,7 @@ static int __init parse_spec_ctrl(const
             opt_ibpb = false;
             opt_ssbd = false;
             opt_l1d_flush = 0;
+            opt_branch_harden = false;
         }
         else if ( val > 0 )
             rc = -EINVAL;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Xen-devel] [PATCH] x86: "spec-ctrl=no-xen" should also disable branch hardening
  2020-02-19  8:12 [Xen-devel] [PATCH] x86: "spec-ctrl=no-xen" should also disable branch hardening Jan Beulich
@ 2020-02-19 16:39 ` Andrew Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2020-02-19 16:39 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Jin Nan Wang, Wei Liu, Roger Pau Monné

On 19/02/2020 08:12, Jan Beulich wrote:
> This is controlling Xen behavior alone, after all.
>
> Reported-by: Jin Nan Wang <jnwang@suse.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-19 16:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19  8:12 [Xen-devel] [PATCH] x86: "spec-ctrl=no-xen" should also disable branch hardening Jan Beulich
2020-02-19 16:39 ` Andrew Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).