xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API
@ 2021-03-25 11:42 Julien Grall
  2021-03-25 14:29 ` Andrew Cooper
  2021-03-26  7:56 ` Jürgen Groß
  0 siblings, 2 replies; 3+ messages in thread
From: Julien Grall @ 2021-03-25 11:42 UTC (permalink / raw)
  To: xen-devel; +Cc: julien, Julien Grall, Ian Jackson, Wei Liu, Juergen Gross

From: Julien Grall <jgrall@amazon.com>

The last use of the compat foreign API was dropped in commit
38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign
map".

Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 tools/xenstore/xenstored_core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
index 0c9a0961b57e..1cdbc3dcb5f7 100644
--- a/tools/xenstore/xenstored_core.h
+++ b/tools/xenstore/xenstored_core.h
@@ -19,7 +19,6 @@
 #ifndef _XENSTORED_CORE_H
 #define _XENSTORED_CORE_H
 
-#define XC_WANT_COMPAT_MAP_FOREIGN_API
 #include <xenctrl.h>
 #include <xengnttab.h>
 
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API
  2021-03-25 11:42 [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API Julien Grall
@ 2021-03-25 14:29 ` Andrew Cooper
  2021-03-26  7:56 ` Jürgen Groß
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2021-03-25 14:29 UTC (permalink / raw)
  To: Julien Grall, xen-devel; +Cc: Julien Grall, Ian Jackson, Wei Liu, Juergen Gross

On 25/03/2021 11:42, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The last use of the compat foreign API was dropped in commit
> 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign
> map".
>
> Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Oops sorry.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API
  2021-03-25 11:42 [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API Julien Grall
  2021-03-25 14:29 ` Andrew Cooper
@ 2021-03-26  7:56 ` Jürgen Groß
  1 sibling, 0 replies; 3+ messages in thread
From: Jürgen Groß @ 2021-03-26  7:56 UTC (permalink / raw)
  To: Julien Grall, xen-devel; +Cc: Julien Grall, Ian Jackson, Wei Liu


[-- Attachment #1.1.1: Type: text/plain, Size: 422 bytes --]

On 25.03.21 12:42, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The last use of the compat foreign API was dropped in commit
> 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign
> map".
> 
> Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-26  7:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 11:42 [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API Julien Grall
2021-03-25 14:29 ` Andrew Cooper
2021-03-26  7:56 ` Jürgen Groß

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).