* [PATCH] xen/arm: print update firmware only once
@ 2020-10-07 11:05 Bertrand Marquis
2020-10-07 13:00 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Bertrand Marquis @ 2020-10-07 11:05 UTC (permalink / raw)
To: xen-devel; +Cc: Stefano Stabellini, Julien Grall, Volodymyr Babchuk
Fix enable_smccc_arch_workaround_1 to only print the warning asking to
update the firmware once.
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
xen/arch/arm/cpuerrata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
index 6c09017515..0c63dfa779 100644
--- a/xen/arch/arm/cpuerrata.c
+++ b/xen/arch/arm/cpuerrata.c
@@ -187,7 +187,7 @@ warn:
ASSERT(system_state < SYS_STATE_active);
warning_add("No support for ARM_SMCCC_ARCH_WORKAROUND_1.\n"
"Please update your firmware.\n");
- warned = false;
+ warned = true;
}
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/arm: print update firmware only once
2020-10-07 11:05 [PATCH] xen/arm: print update firmware only once Bertrand Marquis
@ 2020-10-07 13:00 ` Julien Grall
2020-10-07 13:38 ` Bertrand Marquis
2020-10-07 17:22 ` Stefano Stabellini
0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2020-10-07 13:00 UTC (permalink / raw)
To: Bertrand Marquis, xen-devel; +Cc: Stefano Stabellini, Volodymyr Babchuk
Hi Bertrand,
On 07/10/2020 12:05, Bertrand Marquis wrote:
> Fix enable_smccc_arch_workaround_1 to only print the warning asking to
> update the firmware once.
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> xen/arch/arm/cpuerrata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
> index 6c09017515..0c63dfa779 100644
> --- a/xen/arch/arm/cpuerrata.c
> +++ b/xen/arch/arm/cpuerrata.c
> @@ -187,7 +187,7 @@ warn:
> ASSERT(system_state < SYS_STATE_active);
> warning_add("No support for ARM_SMCCC_ARCH_WORKAROUND_1.\n"
> "Please update your firmware.\n");
> - warned = false;
> + warned = true;
Thanks for spotting it. It looks like I introduced this bug in commit
976319fa3de7f98b558c87b350699fffc278effc "xen/arm64: Kill
PSCI_GET_VERSION as a variant-2 workaround".
I would suggest to add a fixes tag (can be done on commit).
Reviewed-by: Julien Grall <jgrall@amazon.com>
> }
>
> return 0;
>
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/arm: print update firmware only once
2020-10-07 13:00 ` Julien Grall
@ 2020-10-07 13:38 ` Bertrand Marquis
2020-10-07 17:22 ` Stefano Stabellini
1 sibling, 0 replies; 4+ messages in thread
From: Bertrand Marquis @ 2020-10-07 13:38 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Stefano Stabellini, Volodymyr Babchuk
> On 7 Oct 2020, at 14:00, Julien Grall <julien@xen.org> wrote:
>
> Hi Bertrand,
>
> On 07/10/2020 12:05, Bertrand Marquis wrote:
>> Fix enable_smccc_arch_workaround_1 to only print the warning asking to
>> update the firmware once.
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> xen/arch/arm/cpuerrata.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
>> index 6c09017515..0c63dfa779 100644
>> --- a/xen/arch/arm/cpuerrata.c
>> +++ b/xen/arch/arm/cpuerrata.c
>> @@ -187,7 +187,7 @@ warn:
>> ASSERT(system_state < SYS_STATE_active);
>> warning_add("No support for ARM_SMCCC_ARCH_WORKAROUND_1.\n"
>> "Please update your firmware.\n");
>> - warned = false;
>> + warned = true;
>
> Thanks for spotting it. It looks like I introduced this bug in commit 976319fa3de7f98b558c87b350699fffc278effc "xen/arm64: Kill PSCI_GET_VERSION as a variant-2 workaround".
>
> I would suggest to add a fixes tag (can be done on commit).
If you can do it during the commit that works for me.
>
> Reviewed-by: Julien Grall <jgrall@amazon.com>
Thanks
Cheers
Bertrand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/arm: print update firmware only once
2020-10-07 13:00 ` Julien Grall
2020-10-07 13:38 ` Bertrand Marquis
@ 2020-10-07 17:22 ` Stefano Stabellini
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2020-10-07 17:22 UTC (permalink / raw)
To: Julien Grall
Cc: Bertrand Marquis, xen-devel, Stefano Stabellini, Volodymyr Babchuk
On Wed, 7 Oct 2020, Julien Grall wrote:
> Hi Bertrand,
>
> On 07/10/2020 12:05, Bertrand Marquis wrote:
> > Fix enable_smccc_arch_workaround_1 to only print the warning asking to
> > update the firmware once.
> >
> > Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> > ---
> > xen/arch/arm/cpuerrata.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
> > index 6c09017515..0c63dfa779 100644
> > --- a/xen/arch/arm/cpuerrata.c
> > +++ b/xen/arch/arm/cpuerrata.c
> > @@ -187,7 +187,7 @@ warn:
> > ASSERT(system_state < SYS_STATE_active);
> > warning_add("No support for ARM_SMCCC_ARCH_WORKAROUND_1.\n"
> > "Please update your firmware.\n");
> > - warned = false;
> > + warned = true;
>
> Thanks for spotting it. It looks like I introduced this bug in commit
> 976319fa3de7f98b558c87b350699fffc278effc "xen/arm64: Kill PSCI_GET_VERSION as
> a variant-2 workaround".
>
> I would suggest to add a fixes tag (can be done on commit).
>
> Reviewed-by: Julien Grall <jgrall@amazon.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-07 17:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-07 11:05 [PATCH] xen/arm: print update firmware only once Bertrand Marquis
2020-10-07 13:00 ` Julien Grall
2020-10-07 13:38 ` Bertrand Marquis
2020-10-07 17:22 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).