From: Stefano Stabellini <sstabellini@kernel.org>
To: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Cc: xen-devel@lists.xenproject.org, "Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [XEN PATCH v1 2/7] x86/intel: guard vmce_has_lmce() with INTEL option
Date: Fri, 26 Apr 2024 16:04:27 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2404261602590.3940@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <5e26895d84f8b7750799740ac2324b2cb92fa97e.1713860310.git.Sergiy_Kibrik@epam.com>
On Tue, 23 Apr 2024, Sergiy Kibrik wrote:
> Since MCG_LMCE_P bit is specific to Intel CPUs the code to check it can
> possibly be excluded from build if !CONFIG_INTEL. With these guards
> calls to vmce_has_lmce() are eliminated and mce_intel.c can end up
> not being built.
>
> Also replace boilerplate code that checks for MCG_LMCE_P flag with
> vmce_has_lmce(), which might contribute to readability a bit.
>
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
next prev parent reply other threads:[~2024-04-26 23:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 8:45 [XEN PATCH v1 0/7] x86: make Intel/AMD vPMU & MCE support configurable Sergiy Kibrik
2024-04-23 8:48 ` [XEN PATCH v1 1/7] x86/vpmu: separate amd/intel vPMU code Sergiy Kibrik
2024-04-26 23:00 ` Stefano Stabellini
2024-04-29 15:28 ` Jan Beulich
2024-04-30 9:07 ` Sergiy Kibrik
2024-04-23 8:50 ` [XEN PATCH v1 2/7] x86/intel: guard vmce_has_lmce() with INTEL option Sergiy Kibrik
2024-04-26 23:04 ` Stefano Stabellini [this message]
2024-04-29 15:34 ` Jan Beulich
2024-04-30 9:42 ` Sergiy Kibrik
2024-04-23 8:52 ` [XEN PATCH v1 3/7] x86/MCE: guard access to Intel/AMD-specific MCA MSRs Sergiy Kibrik
2024-04-26 23:08 ` Stefano Stabellini
2024-04-29 15:41 ` Jan Beulich
2024-04-23 8:54 ` [XEN PATCH v1 4/7] x86/MCE: guard lmce_support/cmci_support Sergiy Kibrik
2024-04-26 23:10 ` Stefano Stabellini
2024-04-29 15:42 ` Jan Beulich
2024-05-02 8:56 ` Sergiy Kibrik
2024-04-23 8:56 ` [XEN PATCH v1 5/7] x86/MCE: guard {intel/amd}_mcheck_init() calls Sergiy Kibrik
2024-04-26 23:12 ` Stefano Stabellini
2024-04-29 15:45 ` Jan Beulich
2024-04-23 8:58 ` [XEN PATCH v1 6/7] x86/MCE: guard call to Intel-specific intel_get_extended_msrs() Sergiy Kibrik
2024-04-26 23:14 ` Stefano Stabellini
2024-04-29 15:47 ` Jan Beulich
2024-04-23 9:00 ` [XEN PATCH v1 7/7] x86/MCE: optional build of AMD/Intel MCE code Sergiy Kibrik
2024-04-26 23:16 ` Stefano Stabellini
2024-04-29 15:54 ` Jan Beulich
2024-05-02 8:59 ` Sergiy Kibrik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2404261602590.3940@ubuntu-linux-20-04-desktop \
--to=sstabellini@kernel.org \
--cc=Sergiy_Kibrik@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).