xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kconfig: ensure strndup() declaration is visible
@ 2021-01-11 14:42 Jan Beulich
  2021-01-13 21:14 ` Andrew Cooper
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jan Beulich @ 2021-01-11 14:42 UTC (permalink / raw)
  To: xen-devel; +Cc: Doug Goldstein

Its guard was updated such that it is visible by default when POSIX 2008
was adopted by glibc. It's not visible by default on older glibc.

Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/tools/kconfig/parser.y
+++ b/xen/tools/kconfig/parser.y
@@ -4,6 +4,7 @@
  */
 %{
 
+#define _GNU_SOURCE
 #include <ctype.h>
 #include <stdarg.h>
 #include <stdio.h>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] kconfig: ensure strndup() declaration is visible
  2021-01-11 14:42 [PATCH] kconfig: ensure strndup() declaration is visible Jan Beulich
@ 2021-01-13 21:14 ` Andrew Cooper
  2021-01-18 15:39 ` Ping: " Jan Beulich
  2021-01-18 17:21 ` Doug Goldstein
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2021-01-13 21:14 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Doug Goldstein

On 11/01/2021 14:42, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
>
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Ping: [PATCH] kconfig: ensure strndup() declaration is visible
  2021-01-11 14:42 [PATCH] kconfig: ensure strndup() declaration is visible Jan Beulich
  2021-01-13 21:14 ` Andrew Cooper
@ 2021-01-18 15:39 ` Jan Beulich
  2021-01-18 17:21 ` Doug Goldstein
  2 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2021-01-18 15:39 UTC (permalink / raw)
  To: Doug Goldstein; +Cc: xen-devel

Doug,

On 11.01.2021 15:42, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
> 
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I've got an ack from Andrew, but strictly speaking I need yours
aiui. I'll wait some more, but will commit this perhaps by mid
of the week.

Jan


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] kconfig: ensure strndup() declaration is visible
  2021-01-11 14:42 [PATCH] kconfig: ensure strndup() declaration is visible Jan Beulich
  2021-01-13 21:14 ` Andrew Cooper
  2021-01-18 15:39 ` Ping: " Jan Beulich
@ 2021-01-18 17:21 ` Doug Goldstein
  2 siblings, 0 replies; 4+ messages in thread
From: Doug Goldstein @ 2021-01-18 17:21 UTC (permalink / raw)
  To: Jan Beulich, xen-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 565 bytes --]

On 1/11/21 8:42 AM, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
> 
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/tools/kconfig/parser.y
> +++ b/xen/tools/kconfig/parser.y
> @@ -4,6 +4,7 @@
>    */
>   %{
>   
> +#define _GNU_SOURCE
>   #include <ctype.h>
>   #include <stdarg.h>
>   #include <stdio.h>
> 

Ack-by: Doug Goldstein <cardoe@cardoe.com>

[-- Attachment #1.1.2: OpenPGP_0xE15EE761499A935E.asc --]
[-- Type: application/pgp-keys, Size: 1783 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-18 17:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 14:42 [PATCH] kconfig: ensure strndup() declaration is visible Jan Beulich
2021-01-13 21:14 ` Andrew Cooper
2021-01-18 15:39 ` Ping: " Jan Beulich
2021-01-18 17:21 ` Doug Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).