From: Marek Szyprowski <m.szyprowski@samsung.com>
To: 'Michal Nazarewicz' <mina86@mina86.com>,
linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org
Cc: 'Kyungmin Park' <kyungmin.park@samsung.com>,
'Arnd Bergmann' <arnd@arndb.de>, 'Joerg Roedel' <joro@8bytes.org>,
'Russell King - ARM Linux' <linux@arm.linux.org.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: RE: [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops
Date: Mon, 20 Jun 2011 12:46:50 +0200 [thread overview]
Message-ID: <000001cc2f37$5c5605f0$150211d0$%szyprowski@samsung.com> (raw)
In-Reply-To: <op.vxc8tmru3l0zgt@mnazarewicz-glaptop>
Hello,
On Monday, June 20, 2011 10:36 AM Michal Nazarewicz wrote:
> On Mon, 20 Jun 2011 09:50:06 +0200, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> > +static inline void dma_sync_single_for_cpu(struct device *dev,
>
> I wouldn't really put inline here or in the function below.
>
> > + dma_addr_t handle, size_t size, enum dma_data_direction dir)
> > +{
> > + BUG_ON(!valid_dma_direction(dir));
> > +
> > + debug_dma_sync_single_for_cpu(dev, handle, size, dir);
> > +
> > + if (!dmabounce_sync_for_cpu(dev, handle, size, dir))
> > + return;
> > +
> > + __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);
>
> I know it is just copy'n'paste but how about:
This patch is just about moving the code between the files and I wanted just
to show what's being changed and how. There is a final cleanup anyway in the
separate patch. All these patches are meant to start the discussion about
the way the dma mapping can be redesigned for further extensions with generic
iommu support.
>
> if (dmabounce_sync_for_cpu(dev, handle, size, dir))
> __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);
The above lines will be removed by the next patches in this series, so I
really see no point in changing this.
(snipped)
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: 'Michal Nazarewicz' <mina86@mina86.com>,
linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org
Cc: 'Kyungmin Park' <kyungmin.park@samsung.com>,
'Arnd Bergmann' <arnd@arndb.de>, 'Joerg Roedel' <joro@8bytes.org>,
'Russell King - ARM Linux' <linux@arm.linux.org.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: RE: [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops
Date: Mon, 20 Jun 2011 12:46:50 +0200 [thread overview]
Message-ID: <000001cc2f37$5c5605f0$150211d0$%szyprowski@samsung.com> (raw)
Message-ID: <20110620104650.3TnZsg0Qam0vEyHM0GywnHtQ8FZTufZ8kIw6depZL2k@z> (raw)
In-Reply-To: <op.vxc8tmru3l0zgt@mnazarewicz-glaptop>
Hello,
On Monday, June 20, 2011 10:36 AM Michal Nazarewicz wrote:
> On Mon, 20 Jun 2011 09:50:06 +0200, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> > +static inline void dma_sync_single_for_cpu(struct device *dev,
>
> I wouldn't really put inline here or in the function below.
>
> > + dma_addr_t handle, size_t size, enum dma_data_direction dir)
> > +{
> > + BUG_ON(!valid_dma_direction(dir));
> > +
> > + debug_dma_sync_single_for_cpu(dev, handle, size, dir);
> > +
> > + if (!dmabounce_sync_for_cpu(dev, handle, size, dir))
> > + return;
> > +
> > + __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);
>
> I know it is just copy'n'paste but how about:
This patch is just about moving the code between the files and I wanted just
to show what's being changed and how. There is a final cleanup anyway in the
separate patch. All these patches are meant to start the discussion about
the way the dma mapping can be redesigned for further extensions with generic
iommu support.
>
> if (dmabounce_sync_for_cpu(dev, handle, size, dir))
> __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);
The above lines will be removed by the next patches in this series, so I
really see no point in changing this.
(snipped)
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
WARNING: multiple messages have this Message-ID (diff)
From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops
Date: Mon, 20 Jun 2011 12:46:50 +0200 [thread overview]
Message-ID: <000001cc2f37$5c5605f0$150211d0$%szyprowski@samsung.com> (raw)
In-Reply-To: <op.vxc8tmru3l0zgt@mnazarewicz-glaptop>
Hello,
On Monday, June 20, 2011 10:36 AM Michal Nazarewicz wrote:
> On Mon, 20 Jun 2011 09:50:06 +0200, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> > +static inline void dma_sync_single_for_cpu(struct device *dev,
>
> I wouldn't really put inline here or in the function below.
>
> > + dma_addr_t handle, size_t size, enum dma_data_direction dir)
> > +{
> > + BUG_ON(!valid_dma_direction(dir));
> > +
> > + debug_dma_sync_single_for_cpu(dev, handle, size, dir);
> > +
> > + if (!dmabounce_sync_for_cpu(dev, handle, size, dir))
> > + return;
> > +
> > + __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);
>
> I know it is just copy'n'paste but how about:
This patch is just about moving the code between the files and I wanted just
to show what's being changed and how. There is a final cleanup anyway in the
separate patch. All these patches are meant to start the discussion about
the way the dma mapping can be redesigned for further extensions with generic
iommu support.
>
> if (dmabounce_sync_for_cpu(dev, handle, size, dir))
> __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);
The above lines will be removed by the next patches in this series, so I
really see no point in changing this.
(snipped)
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2011-06-20 10:46 UTC|newest]
Thread overview: 207+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 7:50 [PATCH/RFC 0/8] ARM: DMA-mapping framework redesign Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 8:35 ` Michal Nazarewicz
2011-06-20 8:35 ` Michal Nazarewicz
2011-06-20 8:35 ` Michal Nazarewicz
2011-06-20 10:46 ` Marek Szyprowski [this message]
2011-06-20 10:46 ` Marek Szyprowski
2011-06-20 10:46 ` Marek Szyprowski
2011-07-03 15:28 ` Russell King - ARM Linux
2011-07-03 15:28 ` Russell King - ARM Linux
2011-07-03 15:28 ` Russell King - ARM Linux
2011-07-26 12:56 ` Marek Szyprowski
2011-07-26 12:56 ` Marek Szyprowski
2011-07-26 12:56 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 2/8] ARM: dma-mapping: implement dma_map_single on top of dma_map_page Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 14:39 ` Russell King - ARM Linux
2011-06-20 14:39 ` Russell King - ARM Linux
2011-06-20 14:39 ` Russell King - ARM Linux
2011-06-20 15:15 ` Marek Szyprowski
2011-06-20 15:15 ` Marek Szyprowski
2011-06-20 15:15 ` Marek Szyprowski
2011-06-24 15:24 ` Arnd Bergmann
2011-06-24 15:24 ` Arnd Bergmann
2011-06-24 15:24 ` Arnd Bergmann
2011-06-27 14:29 ` Marek Szyprowski
2011-06-27 14:29 ` Marek Szyprowski
2011-06-27 14:29 ` Marek Szyprowski
2011-06-27 14:53 ` Arnd Bergmann
2011-06-27 14:53 ` Arnd Bergmann
2011-06-27 14:53 ` Arnd Bergmann
2011-06-27 15:06 ` Marek Szyprowski
2011-06-27 15:06 ` Marek Szyprowski
2011-06-27 15:06 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 3/8] ARM: dma-mapping: use asm-generic/dma-mapping-common.h Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 14:33 ` [Linaro-mm-sig] " KyongHo Cho
2011-06-20 14:33 ` KyongHo Cho
2011-06-20 14:33 ` KyongHo Cho
2011-06-21 11:47 ` Marek Szyprowski
2011-06-21 11:47 ` Marek Szyprowski
2011-06-21 11:47 ` Marek Szyprowski
2011-06-24 8:39 ` 'Joerg Roedel'
2011-06-24 8:39 ` 'Joerg Roedel'
2011-06-24 8:39 ` 'Joerg Roedel'
2011-06-24 15:36 ` Arnd Bergmann
2011-06-24 15:36 ` Arnd Bergmann
2011-06-24 15:36 ` Arnd Bergmann
2011-06-24 15:36 ` Arnd Bergmann
2011-06-27 12:18 ` Marek Szyprowski
2011-06-27 12:18 ` Marek Szyprowski
2011-06-27 12:18 ` Marek Szyprowski
2011-06-27 13:19 ` Arnd Bergmann
2011-06-27 13:19 ` Arnd Bergmann
2011-06-27 13:19 ` Arnd Bergmann
2011-07-07 12:09 ` Lennert Buytenhek
2011-07-07 12:09 ` Lennert Buytenhek
2011-07-07 12:09 ` Lennert Buytenhek
2011-07-07 12:38 ` Russell King - ARM Linux
2011-07-07 12:38 ` Russell King - ARM Linux
2011-07-07 12:38 ` Russell King - ARM Linux
2011-07-15 0:10 ` Lennert Buytenhek
2011-07-15 0:10 ` Lennert Buytenhek
2011-07-15 0:10 ` Lennert Buytenhek
2011-07-15 9:27 ` Russell King - ARM Linux
2011-07-15 9:27 ` Russell King - ARM Linux
2011-07-15 9:27 ` Russell King - ARM Linux
2011-07-15 21:53 ` Lennert Buytenhek
2011-07-15 21:53 ` Lennert Buytenhek
2011-07-15 21:53 ` Lennert Buytenhek
2011-06-20 7:50 ` [PATCH 4/8] ARM: dma-mapping: implement dma sg methods on top of generic dma ops Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 14:37 ` KyongHo Cho
2011-06-20 14:37 ` KyongHo Cho
2011-06-20 14:37 ` KyongHo Cho
2011-06-20 14:40 ` Russell King - ARM Linux
2011-06-20 14:40 ` Russell King - ARM Linux
2011-06-20 14:40 ` Russell King - ARM Linux
2011-06-20 15:23 ` Marek Szyprowski
2011-06-20 15:23 ` Marek Szyprowski
2011-06-20 15:23 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 5/8] ARM: dma-mapping: move all dma bounce code to separate dma ops structure Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 14:42 ` Russell King - ARM Linux
2011-06-20 14:42 ` Russell King - ARM Linux
2011-06-20 14:42 ` Russell King - ARM Linux
2011-06-20 15:31 ` Marek Szyprowski
2011-06-20 15:31 ` Marek Szyprowski
2011-06-20 15:31 ` Marek Szyprowski
2011-06-24 15:47 ` Arnd Bergmann
2011-06-24 15:47 ` Arnd Bergmann
2011-06-24 15:47 ` Arnd Bergmann
2011-06-27 14:20 ` Marek Szyprowski
2011-06-27 14:20 ` Marek Szyprowski
2011-06-27 14:20 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 6/8] ARM: dma-mapping: remove redundant code and cleanup Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 7/8] common: dma-mapping: change alloc/free_coherent method to more generic alloc/free_attrs Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 14:45 ` KyongHo Cho
2011-06-20 14:45 ` KyongHo Cho
2011-06-20 14:45 ` KyongHo Cho
2011-06-20 15:06 ` Russell King - ARM Linux
2011-06-20 15:06 ` Russell King - ARM Linux
2011-06-20 15:06 ` Russell King - ARM Linux
2011-06-20 15:06 ` Russell King - ARM Linux
2011-06-20 15:14 ` [Linaro-mm-sig] " KyongHo Cho
2011-06-20 15:14 ` KyongHo Cho
2011-06-20 15:14 ` KyongHo Cho
2011-06-21 11:23 ` Marek Szyprowski
2011-06-21 11:23 ` Marek Szyprowski
2011-06-21 11:23 ` Marek Szyprowski
2011-06-22 0:00 ` [Linaro-mm-sig] " KyongHo Cho
2011-06-22 0:00 ` KyongHo Cho
2011-06-22 0:00 ` KyongHo Cho
2011-06-24 7:20 ` Marek Szyprowski
2011-06-24 7:20 ` Marek Szyprowski
2011-06-24 7:20 ` Marek Szyprowski
2011-06-24 15:51 ` Arnd Bergmann
2011-06-24 15:51 ` Arnd Bergmann
2011-06-24 15:51 ` Arnd Bergmann
2011-06-24 16:15 ` James Bottomley
2011-06-24 16:15 ` James Bottomley
2011-06-24 16:15 ` James Bottomley
2011-06-24 16:23 ` Arnd Bergmann
2011-06-24 16:23 ` Arnd Bergmann
2011-06-24 16:23 ` Arnd Bergmann
2011-06-27 12:23 ` Marek Szyprowski
2011-06-27 12:23 ` Marek Szyprowski
2011-06-27 12:23 ` Marek Szyprowski
2011-06-27 12:23 ` Marek Szyprowski
2011-06-27 13:22 ` Arnd Bergmann
2011-06-27 13:22 ` Arnd Bergmann
2011-06-27 13:22 ` Arnd Bergmann
2011-06-27 13:30 ` Marek Szyprowski
2011-06-27 13:30 ` Marek Szyprowski
2011-06-27 13:30 ` Marek Szyprowski
2011-06-24 15:53 ` Arnd Bergmann
2011-06-24 15:53 ` Arnd Bergmann
2011-06-24 15:53 ` Arnd Bergmann
2011-06-27 14:41 ` Marek Szyprowski
2011-06-27 14:41 ` Marek Szyprowski
2011-06-27 14:41 ` Marek Szyprowski
2011-06-20 7:50 ` [PATCH 8/8] ARM: dma-mapping: use alloc, mmap, free from dma_ops Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-20 7:50 ` Marek Szyprowski
2011-06-22 6:53 ` [Linaro-mm-sig] " KyongHo Cho
2011-06-22 6:53 ` KyongHo Cho
2011-06-22 6:53 ` KyongHo Cho
2011-06-22 4:53 ` [Linaro-mm-sig] [PATCH/RFC 0/8] ARM: DMA-mapping framework redesign Subash Patel
2011-06-22 4:53 ` Subash Patel
2011-06-22 4:53 ` Subash Patel
2011-06-22 6:59 ` Marek Szyprowski
2011-06-22 6:59 ` Marek Szyprowski
2011-06-22 6:59 ` Marek Szyprowski
2011-06-22 8:53 ` Subash Patel
2011-06-22 8:53 ` Subash Patel
2011-06-22 8:53 ` Subash Patel
2011-06-22 9:27 ` Marek Szyprowski
2011-06-22 9:27 ` Marek Szyprowski
2011-06-22 9:27 ` Marek Szyprowski
2011-06-22 16:00 ` Jordan Crouse
2011-06-22 16:00 ` Jordan Crouse
2011-06-22 16:00 ` Jordan Crouse
2011-06-23 13:09 ` Subash Patel
2011-06-23 13:09 ` Subash Patel
2011-06-23 13:09 ` Subash Patel
2011-06-23 16:24 ` Michael K. Edwards
2011-06-23 16:24 ` Michael K. Edwards
2011-06-23 16:24 ` Michael K. Edwards
2011-06-23 22:09 ` Michael K. Edwards
2011-06-23 22:09 ` Michael K. Edwards
2011-06-23 22:09 ` Michael K. Edwards
2011-06-25 5:23 ` Jonathan Morton
2011-06-25 5:23 ` Jonathan Morton
2011-06-25 5:23 ` Jonathan Morton
2011-06-25 9:55 ` Michael K. Edwards
2011-06-25 9:55 ` Michael K. Edwards
2011-06-25 9:55 ` Michael K. Edwards
2011-06-26 0:06 ` Jonathan Morton
2011-06-26 0:06 ` Jonathan Morton
2011-06-26 0:06 ` Jonathan Morton
2011-06-24 15:20 ` Arnd Bergmann
2011-06-24 15:20 ` Arnd Bergmann
2011-06-24 15:20 ` Arnd Bergmann
2011-06-24 9:18 ` Joerg Roedel
2011-06-24 9:18 ` Joerg Roedel
2011-06-24 9:18 ` Joerg Roedel
2011-06-24 14:26 ` Marek Szyprowski
2011-06-24 14:26 ` Marek Szyprowski
2011-06-24 14:26 ` Marek Szyprowski
2011-10-18 17:19 [PATCH 0/8 v3] " Marek Szyprowski
2011-10-18 17:19 ` [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Marek Szyprowski
2011-10-18 17:19 ` Marek Szyprowski
2011-10-18 17:19 ` Marek Szyprowski
2011-12-09 16:39 [PATCH 0/8 v4] ARM: DMA-mapping framework redesign Marek Szyprowski
2011-12-09 16:39 ` [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Marek Szyprowski
2011-12-09 16:39 ` Marek Szyprowski
2011-12-09 16:39 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cc2f37$5c5605f0$150211d0$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=arnd@arndb.de \
--cc=joro@8bytes.org \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.