From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>, "'Daniel Lezcano'" <daniel.lezcano@linaro.org>, "'Thomas Gleixner'" <tglx@linutronix.de>, "'Rob Herring'" <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-samsung-soc@vger.kernel.org> Subject: RE: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to MCT Date: Fri, 4 Mar 2022 16:27:12 +0530 [thread overview] Message-ID: <000201d82fb6$9b672090$d23561b0$@samsung.com> (raw) In-Reply-To: <20220225153650.289923-3-krzysztof.kozlowski@canonical.com> >-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Friday, February 25, 2022 9:07 PM >To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner ><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski ><krzysztof.kozlowski@canonical.com>; Alim Akhtar ><alim.akhtar@samsung.com>; linux-kernel@vger.kernel.org; >devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >samsung-soc@vger.kernel.org >Subject: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to MCT > >One compatible is used for the Multi-Core Timer on most of the Samsung Exynos >SoCs, which is correct but not specific enough. These MCT blocks have different >number of interrupts, so add a second specific compatible to Exynos5433 and >Exynos850. > >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >--- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 3 ++- >arch/arm64/boot/dts/exynos/exynos850.dtsi | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >index 661567d2dd7a..017ccc2f4650 100644 >--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >@@ -806,7 +806,8 @@ tmu_isp: tmu@1007c000 { > }; > > timer@101c0000 { >- compatible = "samsung,exynos4210-mct"; >+ compatible = "samsung,exynos5433-mct", >+ "samsung,exynos4210-mct"; Just a though, do we still need to keep Samsung,exyno4210-mct compatible? In anyway: Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > reg = <0x101c0000 0x800>; > interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>, >diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi >b/arch/arm64/boot/dts/exynos/exynos850.dtsi >index d1700e96fee2..12f7ddc6fd0a 100644 >--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi >+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi >@@ -181,7 +181,8 @@ chipid@10000000 { > }; > > timer@10040000 { >- compatible = "samsung,exynos4210-mct"; >+ compatible = "samsung,exynos850-mct", >+ "samsung,exynos4210-mct"; > reg = <0x10040000 0x800>; > interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH>, >-- >2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>, "'Daniel Lezcano'" <daniel.lezcano@linaro.org>, "'Thomas Gleixner'" <tglx@linutronix.de>, "'Rob Herring'" <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-samsung-soc@vger.kernel.org> Subject: RE: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to MCT Date: Fri, 4 Mar 2022 16:27:12 +0530 [thread overview] Message-ID: <000201d82fb6$9b672090$d23561b0$@samsung.com> (raw) In-Reply-To: <20220225153650.289923-3-krzysztof.kozlowski@canonical.com> >-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Friday, February 25, 2022 9:07 PM >To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner ><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski ><krzysztof.kozlowski@canonical.com>; Alim Akhtar ><alim.akhtar@samsung.com>; linux-kernel@vger.kernel.org; >devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >samsung-soc@vger.kernel.org >Subject: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to MCT > >One compatible is used for the Multi-Core Timer on most of the Samsung Exynos >SoCs, which is correct but not specific enough. These MCT blocks have different >number of interrupts, so add a second specific compatible to Exynos5433 and >Exynos850. > >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >--- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 3 ++- >arch/arm64/boot/dts/exynos/exynos850.dtsi | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >index 661567d2dd7a..017ccc2f4650 100644 >--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >@@ -806,7 +806,8 @@ tmu_isp: tmu@1007c000 { > }; > > timer@101c0000 { >- compatible = "samsung,exynos4210-mct"; >+ compatible = "samsung,exynos5433-mct", >+ "samsung,exynos4210-mct"; Just a though, do we still need to keep Samsung,exyno4210-mct compatible? In anyway: Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > reg = <0x101c0000 0x800>; > interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>, >diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi >b/arch/arm64/boot/dts/exynos/exynos850.dtsi >index d1700e96fee2..12f7ddc6fd0a 100644 >--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi >+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi >@@ -181,7 +181,8 @@ chipid@10000000 { > }; > > timer@10040000 { >- compatible = "samsung,exynos4210-mct"; >+ compatible = "samsung,exynos850-mct", >+ "samsung,exynos4210-mct"; > reg = <0x10040000 0x800>; > interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH>, >-- >2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-04 10:57 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20220225180401epcas5p35d6c09ca6da36289d66d1bb0dcdeffa1@epcas5p3.samsung.com> 2022-02-25 15:36 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: describe known hardware and its interrupts Krzysztof Kozlowski 2022-02-25 15:36 ` Krzysztof Kozlowski 2022-02-25 15:36 ` [PATCH 2/3] ARM: dts: exynos: add a specific compatible to MCT Krzysztof Kozlowski 2022-02-25 15:36 ` Krzysztof Kozlowski 2022-03-04 10:54 ` Alim Akhtar 2022-03-04 10:54 ` Alim Akhtar 2022-04-04 17:01 ` (subset) " Krzysztof Kozlowski 2022-04-04 17:01 ` Krzysztof Kozlowski 2022-02-25 15:36 ` [PATCH 3/3] arm64: " Krzysztof Kozlowski 2022-02-25 15:36 ` Krzysztof Kozlowski 2022-03-04 10:57 ` Alim Akhtar [this message] 2022-03-04 10:57 ` Alim Akhtar 2022-03-04 12:00 ` Krzysztof Kozlowski 2022-03-04 12:00 ` Krzysztof Kozlowski 2022-03-04 10:52 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: describe known hardware and its interrupts Alim Akhtar 2022-03-04 10:52 ` Alim Akhtar 2022-03-04 12:02 ` Krzysztof Kozlowski 2022-03-04 12:02 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='000201d82fb6$9b672090$d23561b0$@samsung.com' \ --to=alim.akhtar@samsung.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.