RE: [PATCH v3 01/12] dt-bindings: ufs: add common platform bindings

From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Avri Altman'" <avri.altman@wdc.com>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Andy Gross'" <agross@kernel.org>,
	"'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
	"'Wei Xu'" <xuwei5@hisilicon.com>,
	"'Matthias Brugger'" <matthias.bgg@gmail.com>,
	"'Jan Kotas'" <jank@cadence.com>,
	"'Li Wei'" <liwei213@huawei.com>,
	"'Stanley Chu'" <stanley.chu@mediatek.com>,
	"'Vignesh Raghavendra'" <vigneshr@ti.com>,
	<linux-scsi@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>
Subject: RE: [PATCH v3 01/12] dt-bindings: ufs: add common platform bindings
Date: Tue, 8 Mar 2022 00:06:24 +0530	[thread overview]
Message-ID: <000401d83252$41d5fe40$c581fac0$@samsung.com> (raw)
In-Reply-To: <20220306111125.116455-2-krzysztof.kozlowski@canonical.com>


Hi Krzysztof

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Sunday, March 6, 2022 4:41 PM
>To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman
><avri.altman@wdc.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski@canonical.com>; Andy Gross
><agross@kernel.org>; Bjorn Andersson <bjorn.andersson@linaro.org>; Wei
>Xu <xuwei5@hisilicon.com>; Matthias Brugger <matthias.bgg@gmail.com>;
>Jan Kotas <jank@cadence.com>; Li Wei <liwei213@huawei.com>; Stanley Chu
><stanley.chu@mediatek.com>; Vignesh Raghavendra <vigneshr@ti.com>;
>linux-scsi@vger.kernel.org; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>mediatek@lists.infradead.org
>Subject: [PATCH v3 01/12] dt-bindings: ufs: add common platform bindings
>
>Add bindings for common parts (platform) of Universal Flash Storage
>(UFS) Host Controllers in dtschema format.
>
>Include also the bindings directory in the UFS maintainers entry.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> .../devicetree/bindings/ufs/ufs-common.yaml   | 82 +++++++++++++++++++
> MAINTAINERS                                   |  1 +
> 2 files changed, 83 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-
>common.yaml
>
>diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>new file mode 100644
>index 000000000000..47a4e9e1a775
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>@@ -0,0 +1,82 @@
>+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>+---
>+$id:
>+https://protect2.fireeye.com/v1/url?k=1c5f8d40-43c4b442-1c5e060f-0cc47a
>+31381a-044442c4c340dc87&q=1&e=f6b89910-3420-4a58-a18d-
>4ca02e079c2b&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fufs%2Fufs-common.yaml%23
>+$schema:
>+https://protect2.fireeye.com/v1/url?k=bc24c591-e3bffc93-bc254ede-0cc47a
>+31381a-e9aaf10c3795a198&q=1&e=f6b89910-3420-4a58-a18d-
>4ca02e079c2b&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
>+
>+title: Common properties for Universal Flash Storage (UFS) Host
>+Controllers
>+
>+maintainers:
>+  - Alim Akhtar <alim.akhtar@samsung.com>
>+  - Avri Altman <avri.altman@wdc.com>
>+
>+properties:
>+  clocks: true
>+
>+  clock-names: true
>+
>+  freq-table-hz:
>+    items:
>+      items:
>+        - description: Minimum frequency for given clock in Hz
>+        - description: Maximum frequency for given clock in Hz
>+    description: |
>+      Array of <min max> operating frequencies in Hz stored in the same
order
>+      as the clocks property. If this property is not defined or a value
in the
>+      array is "0" then it is assumed that the frequency is set by the
parent
>+      clock or a fixed rate clock source.
>+
>+  interrupts:
>+    maxItems: 1
>+
>+  lanes-per-direction:
>+    $ref: /schemas/types.yaml#/definitions/uint32
>+    enum: [1, 2]
>+    default: 2
>+    description:
>+      Number of lanes available per direction.  Note that it is assume
same
>+      number of lanes is used both directions at once.
>+
>+  vdd-hba-supply:
>+    description:
>+      Phandle to UFS host controller supply regulator node.
>+
>+  vcc-supply:
>+    description:
>+      Phandle to VCC supply regulator node.
>+
>+  vccq-supply:
>+    description:
>+      Phandle to VCCQ supply regulator node.
>+
>+  vccq2-supply:
>+    description:
>+      Phandle to VCCQ2 supply regulator node.
>+
>+  vcc-supply-1p8:
>+    type: boolean
>+    description:
>+      For embedded UFS devices, valid VCC range is 1.7-1.95V or 2.7-3.6V.
This
>+      boolean property when set, specifies to use low voltage range of
>+      1.7-1.95V. Note for external UFS cards this property is invalid and
valid
>+      VCC range is always 2.7-3.6V.
>+
>+  vcc-max-microamp:
>+    description:
>+      Specifies max. load that can be drawn from VCC supply.
>+
>+  vccq-max-microamp:
>+    description:
>+      Specifies max. load that can be drawn from VCCQ supply.
>+
>+  vccq2-max-microamp:
>+    description:
>+      Specifies max. load that can be drawn from VCCQ2 supply.
>+
>+dependencies:
>+  freq-table-hz: [ 'clocks' ]
>+
>+required:
>+  - interrupts
>+
>+additionalProperties: true
>diff --git a/MAINTAINERS b/MAINTAINERS
>index d7ea92ce1b1d..ef16268b6ca6 100644
>--- a/MAINTAINERS
>+++ b/MAINTAINERS
>@@ -20100,6 +20100,7 @@ R:	Alim Akhtar <alim.akhtar@samsung.com>
> R:	Avri Altman <avri.altman@wdc.com>
> L:	linux-scsi@vger.kernel.org
> S:	Supported
>+F:	Documentation/devicetree/bindings/ufs/
> F:	Documentation/scsi/ufs.rst
> F:	drivers/scsi/ufs/
>
>--
>2.32.0