RE: [PATCH 10/10] arm64: dts: fsd: use proper 'dma-channels/requests' properties

From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Lee Jones'" <lee.jones@linaro.org>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
	"'Dinh Nguyen'" <dinguyen@kernel.org>,
	"'Michal Simek'" <michal.simek@xilinx.com>,
	"'Liviu Dudau'" <liviu.dudau@arm.com>,
	"'Sudeep Holla'" <sudeep.holla@arm.com>,
	"'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
	"'Ray Jui'" <rjui@broadcom.com>,
	"'Scott Branden'" <sbranden@broadcom.com>,
	"'Broadcom Kernel Team'" <bcm-kernel-feedback-list@broadcom.com>,
	"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: "'Rob Herring'" <robh@kernel.org>
Subject: RE: [PATCH 10/10] arm64: dts: fsd: use proper 'dma-channels/requests' properties
Date: Wed, 27 Apr 2022 22:19:00 +0530	[thread overview]
Message-ID: <000401d85a56$b43a8150$1caf83f0$@samsung.com> (raw)
In-Reply-To: <20220427155840.596535-11-krzysztof.kozlowski@linaro.org>


>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Wednesday, April 27, 2022 9:29 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Dinh Nguyen <dinguyen@kernel.org>; Michal
>Simek <michal.simek@xilinx.com>; Liviu Dudau <liviu.dudau@arm.com>;
>Sudeep Holla <sudeep.holla@arm.com>; Lorenzo Pieralisi
><lorenzo.pieralisi@arm.com>; Ray Jui <rjui@broadcom.com>; Scott Branden
><sbranden@broadcom.com>; Broadcom Kernel Team <bcm-kernel-feedback-
>list@broadcom.com>; Sylwester Nawrocki <s.nawrocki@samsung.com>;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Rob Herring
><robh@kernel.org>
>Subject: [PATCH 10/10] arm64: dts: fsd: use proper 'dma-channels/requests'
>properties
>
>pl330 DMA controller bindings documented 'dma-channels' and 'dma-
>requests' properties (without leading hash sign), so fix the DTS to match
the
>bindings.
>
>Reported-by: Rob Herring <robh@kernel.org>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---

Acked-by: Alim Akhtar <alim.akhtar@samsung.com>

> arch/arm64/boot/dts/tesla/fsd.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>b/arch/arm64/boot/dts/tesla/fsd.dtsi
>index 10c217a57a7d..7fba37d860b2 100644
>--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>@@ -432,8 +432,8 @@ mdma0: dma-controller@10100000 {
> 			reg = <0x0 0x10100000 0x0 0x1000>;
> 			interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
> 			#dma-cells = <1>;
>-			#dma-channels = <8>;
>-			#dma-requests = <32>;
>+			dma-channels = <8>;
>+			dma-requests = <32>;
> 			clocks = <&clock_imem
>IMEM_DMA0_IPCLKPORT_ACLK>;
> 			clock-names = "apb_pclk";
> 			iommus = <&smmu_imem 0x800 0x0>;
>@@ -444,8 +444,8 @@ mdma1: dma-controller@10110000 {
> 			reg = <0x0 0x10110000 0x0 0x1000>;
> 			interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> 			#dma-cells = <1>;
>-			#dma-channels = <8>;
>-			#dma-requests = <32>;
>+			dma-channels = <8>;
>+			dma-requests = <32>;
> 			clocks = <&clock_imem
>IMEM_DMA1_IPCLKPORT_ACLK>;
> 			clock-names = "apb_pclk";
> 			iommus = <&smmu_imem 0x801 0x0>;
>@@ -456,8 +456,8 @@ pdma0: dma-controller@14280000 {
> 			reg = <0x0 0x14280000 0x0 0x1000>;
> 			interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
> 			#dma-cells = <1>;
>-			#dma-channels = <8>;
>-			#dma-requests = <32>;
>+			dma-channels = <8>;
>+			dma-requests = <32>;
> 			clocks = <&clock_peric
>PERIC_DMA0_IPCLKPORT_ACLK>;
> 			clock-names = "apb_pclk";
> 			iommus = <&smmu_peric 0x2 0x0>;
>@@ -468,8 +468,8 @@ pdma1: dma-controller@14290000 {
> 			reg = <0x0 0x14290000 0x0 0x1000>;
> 			interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
> 			#dma-cells = <1>;
>-			#dma-channels = <8>;
>-			#dma-requests = <32>;
>+			dma-channels = <8>;
>+			dma-requests = <32>;
> 			clocks = <&clock_peric
>PERIC_DMA1_IPCLKPORT_ACLK>;
> 			clock-names = "apb_pclk";
> 			iommus = <&smmu_peric 0x1 0x0>;
>--
>2.32.0