Re: [PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk

From: Jan Beulich <jbeulich@suse.com>
To: Shawn Anastasio <sanastasio@raptorengineering.com>
Cc: Timothy Pearson <tpearson@raptorengineering.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk
Date: Wed, 20 Dec 2023 12:48:13 +0100	[thread overview]
Message-ID: <002559fc-e57c-48e2-b99d-db352c2fdf60@suse.com> (raw)
In-Reply-To: <a45e841068ef66cc8c1d836a2452910fd3effd50.1702607884.git.sanastasio@raptorengineering.com>

On 15.12.2023 03:44, Shawn Anastasio wrote:
> Now that we have common code building, there's no need to keep the old
> itoa64+debug print function in mm-radix.c
> 
> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>

Looks okay, just one question:

> --- a/xen/arch/ppc/mm-radix.c
> +++ b/xen/arch/ppc/mm-radix.c
> @@ -15,6 +15,12 @@
>  
>  void enable_mmu(void);
>  
> +#ifdef NDEBUG
> +#define radix_dprintk(...)
> +#else
> +#define radix_dprintk(msg, ...) printk(XENLOG_DEBUG msg, ## __VA_ARGS__)
> +#endif

Do you really mean NDEBUG here, and not CONFIG_DEBUG? NDEBUG is generally
supposed to only control ASSERT() behavior.

Jan