From: Jan Beulich <jbeulich@suse.com>
To: Shawn Anastasio <sanastasio@raptorengineering.com>
Cc: Timothy Pearson <tpearson@raptorengineering.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h
Date: Wed, 20 Dec 2023 12:09:11 +0100 [thread overview]
Message-ID: <3fa1db69-adcc-4d1f-9e8a-e2300393210b@suse.com> (raw)
In-Reply-To: <1e4f48d753871bf61de3af97a3009e069d25d01e.1702607884.git.sanastasio@raptorengineering.com>
On 15.12.2023 03:43, Shawn Anastasio wrote:
> Introduce setup.h to asm-generic based off of ARM's to define all
> stubs necessary to compile bootfdt.c
>
> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
> ---
> xen/arch/ppc/include/asm/Makefile | 1 +
> xen/arch/ppc/include/asm/setup.h | 6 --
> xen/include/asm-generic/setup.h | 148 ++++++++++++++++++++++++++++++
> 3 files changed, 149 insertions(+), 6 deletions(-)
> delete mode 100644 xen/arch/ppc/include/asm/setup.h
> create mode 100644 xen/include/asm-generic/setup.h
>
> diff --git a/xen/arch/ppc/include/asm/Makefile b/xen/arch/ppc/include/asm/Makefile
> index a711cfa856..7167661f86 100644
> --- a/xen/arch/ppc/include/asm/Makefile
> +++ b/xen/arch/ppc/include/asm/Makefile
> @@ -6,5 +6,6 @@ generic-y += iocap.h
> generic-y += paging.h
> generic-y += percpu.h
> generic-y += random.h
> +generic-y += setup.h
> generic-y += static-shmem.h
> generic-y += vm_event.h
Looking at patch 5, you undo this there. Why introduce it in the first place
then? And why leave a stale (unused) file around there?
Jan
next prev parent reply other threads:[~2023-12-20 11:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 2:43 [PATCH v2 0/7] Early Boot Allocation on Power Shawn Anastasio
2023-12-15 2:43 ` [PATCH v2 1/7] xen/asm-generic: Introduce generic static-shmem.h Shawn Anastasio
2023-12-19 17:07 ` Jan Beulich
2023-12-15 2:43 ` [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h Shawn Anastasio
2023-12-20 7:23 ` Jan Beulich
2023-12-20 11:09 ` Jan Beulich [this message]
2023-12-20 18:51 ` Shawn Anastasio
2023-12-15 2:43 ` [PATCH v2 3/7] xen/common: Move Arm's bootfdt to common Shawn Anastasio
2023-12-19 17:03 ` Jan Beulich
2023-12-19 18:29 ` Julien Grall
2023-12-20 8:09 ` Jan Beulich
2023-12-20 20:58 ` Shawn Anastasio
2023-12-20 22:08 ` Julien Grall
2023-12-20 22:10 ` Timothy Pearson
2023-12-21 7:11 ` Jan Beulich
2023-12-20 13:53 ` Julien Grall
2023-12-15 2:43 ` [PATCH v2 4/7] xen/device-tree: Fix bootfdt.c to tolerate 0 reserved regions Shawn Anastasio
2024-01-09 18:14 ` Julien Grall
2024-01-10 8:15 ` Michal Orzel
2024-01-11 22:56 ` Shawn Anastasio
2023-12-15 2:44 ` [PATCH v2 5/7] xen/ppc: Enable bootfdt and boot allocator Shawn Anastasio
2023-12-20 11:44 ` Jan Beulich
2023-12-20 13:23 ` Julien Grall
2023-12-20 16:07 ` Julien Grall
2023-12-20 13:49 ` Julien Grall
2024-01-18 1:36 ` Shawn Anastasio
2024-01-18 9:21 ` Julien Grall
2023-12-15 2:44 ` [PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk Shawn Anastasio
2023-12-20 11:48 ` Jan Beulich
2024-01-18 1:37 ` Shawn Anastasio
2023-12-15 2:44 ` [PATCH v2 7/7] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime Shawn Anastasio
2023-12-21 7:06 ` Jan Beulich
2024-03-14 18:29 ` Shawn Anastasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa1db69-adcc-4d1f-9e8a-e2300393210b@suse.com \
--to=jbeulich@suse.com \
--cc=sanastasio@raptorengineering.com \
--cc=tpearson@raptorengineering.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.