From: "Kay, Allen M" <allen.m.kay@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "igvt-g@ml01.01.org" <igvt-g@ml01.01.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c
Date: Thu, 10 Mar 2016 17:51:51 +0000 [thread overview]
Message-ID: <003AAFE53969E14CB1F09B6FD68C3CD47BBC2657@ORSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D15F7E261C@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Tian, Kevin
> Sent: Wednesday, March 09, 2016 9:56 PM
> To: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>; Stefano Stabellini
> <stefano.stabellini@eu.citrix.com>; xen-devel@lists.xensource.com; igvt-
> g@ml01.01.org; Michael S. Tsirkin <mst@redhat.com>; open list:All patches
> CC here <qemu-devel@nongnu.org>; Kay, Allen M <allen.m.kay@intel.com>
> Subject: RE: [PATCH v4 2/8] pc: move igd support code to igd.c
>
> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > Sent: Wednesday, March 09, 2016 11:08 PM
> >
> > Hi,
> >
> > > +/* Here we just expose minimal host bridge offset subset. */ static
> > > +const IGDHostInfo igd_host_bridge_infos[] = {
> > > + {0x08, 2}, /* revision id */
> > > + {0x2c, 2}, /* sybsystem vendor id */
> > > + {0x2e, 2}, /* sybsystem id */
> >
> > Can anyone clarify where this comes from?
>
> Add Allen who is the original author.
>
> >
> > Setting the subsystem id without also setting the pci id looks wrong,
> > given that each pci id has its own subsystem id namespace.
> >
Host bridge register passthrough only serves the purpose of allowing Windows IGD driver accessing info it needs to boot and leave the rest intact so it would not look too different from the chipset it is emulating.
Allen
WARNING: multiple messages have this Message-ID (diff)
From: "Kay, Allen M" <allen.m.kay@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "igvt-g@ml01.01.org" <igvt-g@ml01.01.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v4 2/8] pc: move igd support code to igd.c
Date: Thu, 10 Mar 2016 17:51:51 +0000 [thread overview]
Message-ID: <003AAFE53969E14CB1F09B6FD68C3CD47BBC2657@ORSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D15F7E261C@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Tian, Kevin
> Sent: Wednesday, March 09, 2016 9:56 PM
> To: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>; Stefano Stabellini
> <stefano.stabellini@eu.citrix.com>; xen-devel@lists.xensource.com; igvt-
> g@ml01.01.org; Michael S. Tsirkin <mst@redhat.com>; open list:All patches
> CC here <qemu-devel@nongnu.org>; Kay, Allen M <allen.m.kay@intel.com>
> Subject: RE: [PATCH v4 2/8] pc: move igd support code to igd.c
>
> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > Sent: Wednesday, March 09, 2016 11:08 PM
> >
> > Hi,
> >
> > > +/* Here we just expose minimal host bridge offset subset. */ static
> > > +const IGDHostInfo igd_host_bridge_infos[] = {
> > > + {0x08, 2}, /* revision id */
> > > + {0x2c, 2}, /* sybsystem vendor id */
> > > + {0x2e, 2}, /* sybsystem id */
> >
> > Can anyone clarify where this comes from?
>
> Add Allen who is the original author.
>
> >
> > Setting the subsystem id without also setting the pci id looks wrong,
> > given that each pci id has its own subsystem id namespace.
> >
Host bridge register passthrough only serves the purpose of allowing Windows IGD driver accessing info it needs to boot and leave the rest intact so it would not look too different from the chipset it is emulating.
Allen
next prev parent reply other threads:[~2016-03-10 17:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 14:27 [PATCH v4 0/8] igd passthrough chipset tweaks Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 1/8] pc: remove has_igd_gfx_passthru global Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-09 15:08 ` [Qemu-devel] " Gerd Hoffmann
2016-03-09 15:08 ` Gerd Hoffmann
2016-03-10 5:56 ` [Qemu-devel] " Tian, Kevin
2016-03-10 5:56 ` Tian, Kevin
2016-03-10 17:51 ` Kay, Allen M [this message]
2016-03-10 17:51 ` Kay, Allen M
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 3/8] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 4/8] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 5/8] igd: use defines for standard pci config space offsets Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 6/8] igd: revamp host config read Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 7/8] igd: move igd-passthrough-isa-bridge to igd.c too Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
2016-03-08 14:27 ` [Qemu-devel] [PATCH v4 8/8] igd: handle igd-passthrough-isa-bridge setup in realize() Gerd Hoffmann
2016-03-08 14:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=003AAFE53969E14CB1F09B6FD68C3CD47BBC2657@ORSMSX106.amr.corp.intel.com \
--to=allen.m.kay@intel.com \
--cc=alex.williamson@redhat.com \
--cc=igvt-g@ml01.01.org \
--cc=kevin.tian@intel.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.