From: "Hyunki Koo" <hyunki00.koo@samsung.com>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Cc: "'Kukjin Kim'" <kgene@kernel.org>,
"'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Jiri Slaby'" <jslaby@suse.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg
Date: Wed, 6 May 2020 16:18:28 +0900 [thread overview]
Message-ID: <003b01d62376$8a602c40$9f2084c0$@samsung.com> (raw)
In-Reply-To: <20200506063105.GA2246050@kroah.com>
On Tuesday, May 5, 2020 at 2020 03:31:00 PM +0900, Greg Kroah-Hartman
> On Wed, May 06, 2020 at 08:30:46AM +0900, Hyunki Koo wrote:
> > On Tuesday, May 5, 2020 at 2020 11:23:00 PM +0900, Greg Kroah-Hartman
> Hartman wrote:
> > > On Mon, Apr 20, 2020 at 10:32:56AM +0900, Hyunki Koo wrote:
> > > > This patch change the name of macro for general usage.
> > > >
> > > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> > >
> > > This patch series creates the following build error, which is not
> > > allowed:
> > >
> > > CC [M] drivers/tty/serial/samsung_tty.o
> > > drivers/tty/serial/samsung_tty.c:186:13: warning: ‘wr_reg_barrier’
> > > defined but not used [-Wunused-function]
> > > 186 | static void wr_reg_barrier(struct uart_port *port, u32 reg, u32
> val)
> > > | ^~~~~~~~~~~~~~
> > >
> > > Please fix up and resend. Always make sure you keep the reviewed-by
> > > tags from others as well.
> > >
> > > greg k-h
> >
> > I tested on latest kernel today one more time, there is no error and
> warning on my side, not only patch 1/3 and patch 3/3
> > Line 1735: CC drivers/tty/serial/samsung_tty.o
> > Line 343: CC drivers/tty/serial/samsung_tty.o
> >
> > wr_reg_barrier is not defined in patch 1/3, and wr_reg_barrier is
> > define and used in patch3/3 it might be no warning.
>
> After I apply this series, I got the above build warning on my normal
> x86 system, so I can not take the patches. Please fix up and resend.
>
> greg k-h
I'm so sorry,
There is an warning if CONFIG_SERIAL_SAMSUNG_CONSOLE is not enabled.
I've fix the patch and resend
Thank you in advance.
WARNING: multiple messages have this Message-ID (diff)
From: "Hyunki Koo" <hyunki00.koo@samsung.com>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
'Krzysztof Kozlowski' <krzk@kernel.org>,
'Kukjin Kim' <kgene@kernel.org>,
linux-serial@vger.kernel.org, 'Jiri Slaby' <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg
Date: Wed, 6 May 2020 16:18:28 +0900 [thread overview]
Message-ID: <003b01d62376$8a602c40$9f2084c0$@samsung.com> (raw)
In-Reply-To: <20200506063105.GA2246050@kroah.com>
On Tuesday, May 5, 2020 at 2020 03:31:00 PM +0900, Greg Kroah-Hartman
> On Wed, May 06, 2020 at 08:30:46AM +0900, Hyunki Koo wrote:
> > On Tuesday, May 5, 2020 at 2020 11:23:00 PM +0900, Greg Kroah-Hartman
> Hartman wrote:
> > > On Mon, Apr 20, 2020 at 10:32:56AM +0900, Hyunki Koo wrote:
> > > > This patch change the name of macro for general usage.
> > > >
> > > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> > >
> > > This patch series creates the following build error, which is not
> > > allowed:
> > >
> > > CC [M] drivers/tty/serial/samsung_tty.o
> > > drivers/tty/serial/samsung_tty.c:186:13: warning: ‘wr_reg_barrier’
> > > defined but not used [-Wunused-function]
> > > 186 | static void wr_reg_barrier(struct uart_port *port, u32 reg, u32
> val)
> > > | ^~~~~~~~~~~~~~
> > >
> > > Please fix up and resend. Always make sure you keep the reviewed-by
> > > tags from others as well.
> > >
> > > greg k-h
> >
> > I tested on latest kernel today one more time, there is no error and
> warning on my side, not only patch 1/3 and patch 3/3
> > Line 1735: CC drivers/tty/serial/samsung_tty.o
> > Line 343: CC drivers/tty/serial/samsung_tty.o
> >
> > wr_reg_barrier is not defined in patch 1/3, and wr_reg_barrier is
> > define and used in patch3/3 it might be no warning.
>
> After I apply this series, I got the above build warning on my normal
> x86 system, so I can not take the patches. Please fix up and resend.
>
> greg k-h
I'm so sorry,
There is an warning if CONFIG_SERIAL_SAMSUNG_CONSOLE is not enabled.
I've fix the patch and resend
Thank you in advance.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-06 7:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200420013322epcas2p263e72997dd4ebdaf00b095a83a6b6651@epcas2p2.samsung.com>
2020-04-20 1:32 ` [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Hyunki Koo
2020-04-20 1:32 ` Hyunki Koo
[not found] ` <CGME20200420013325epcas2p13f65e6bc8ba68f89c805704830144870@epcas2p1.samsung.com>
2020-04-20 1:32 ` [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-30 15:12 ` Rob Herring
[not found] ` <CGME20200420013332epcas2p381793b8c09d71269d3e8c38a196a1c74@epcas2p3.samsung.com>
2020-04-20 1:32 ` [PATCH v8 3/3] tty: samsung_tty: 32-bit access for TX/RX hold registers Hyunki Koo
2020-04-20 1:32 ` Hyunki Koo
2020-04-20 14:19 ` Hyunki Koo
2020-04-20 14:19 ` Hyunki Koo
[not found] ` <CGME20200420233607epcas2p305dbd652ab73592a32c17773c1fce329@epcas2p3.samsung.com>
2020-04-20 23:35 ` [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver Hyunki Koo
2020-04-24 0:40 ` Hyunki Koo
2020-04-24 5:37 ` Greg KH
2020-04-26 23:15 ` Hyunki Koo
2020-05-05 14:23 ` [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Greg Kroah-Hartman
2020-05-05 14:23 ` Greg Kroah-Hartman
2020-05-05 23:30 ` Hyunki Koo
2020-05-05 23:30 ` Hyunki Koo
2020-05-06 6:31 ` 'Greg Kroah-Hartman'
2020-05-06 6:31 ` 'Greg Kroah-Hartman'
2020-05-06 7:18 ` Hyunki Koo [this message]
2020-05-06 7:18 ` Hyunki Koo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003b01d62376$8a602c40$9f2084c0$@samsung.com' \
--to=hyunki00.koo@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.