From: Jingoo Han <jg1.han@samsung.com>
To: 'Tomi Valkeinen' <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
"'Archit Taneja'" <a0393947@ti.com>,
"'Chandrabhanu Mahapatra'" <cmahapatra@ti.com>,
"'Raphaël Assénat'" <raph@8d.com>,
"'Tony Lindgren'" <tony@atomide.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 0/6] OMAPDSS: remove cpu_is_* calls
Date: Thu, 04 Oct 2012 01:33:38 +0000 [thread overview]
Message-ID: <005d01cda1d0$47a249e0$d6e6dda0$%han@samsung.com> (raw)
In-Reply-To: <1348828527-13309-1-git-send-email-tomi.valkeinen@ti.com>
On Friday, September 28, 2012 7:35 PM Tomi Valkeinen wrote
>
> Hi,
>
> This series adds an omapdss_version enum that is passed via platform data to
> omapdss driver. This version identifier is then used instead of cpu_is_*()
> calls.
Hi Tomi,
As you mentioned, cpu_is_*() is not preferable in driver.
Actually, I thought so, when I saw the OMAPDSS driver a few months ago.
Anyway, it looks good. :)
Best regards,
Jingoo Han
>
> After these, omapdss no longer contains any plat/ or mach/ includes. omapfb,
> vrfb and vram still do, though.
>
> Tomi
>
> Tomi Valkeinen (6):
> OMAPDSS: add omapdss_version
> OMAPDSS: use omapdss_version in dss_features.c
> OMAPDSS: DISPC: use omapdss_version
> OMAPDSS: DSS: use omapdss_version
> OMAPDSS: HDMI: use omapdss_version
> OMAPDSS: remove <plat/cpu.h> includes
>
> arch/arm/mach-omap2/display.c | 38 +++++++++++++++++++
> drivers/video/omap2/dss/core.c | 2 +-
> drivers/video/omap2/dss/dispc.c | 41 +++++++++++++-------
> drivers/video/omap2/dss/dss.c | 39 +++++++++++++------
> drivers/video/omap2/dss/dss_features.c | 64 ++++++++++++++++++++++----------
> drivers/video/omap2/dss/dss_features.h | 5 ++-
> drivers/video/omap2/dss/hdmi.c | 3 +-
> include/video/omapdss.h | 14 +++++++
> 8 files changed, 157 insertions(+), 49 deletions(-)
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jingoo Han <jg1.han@samsung.com>
To: 'Tomi Valkeinen' <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
"'Archit Taneja'" <a0393947@ti.com>,
"'Chandrabhanu Mahapatra'" <cmahapatra@ti.com>,
"'Raphaël Assénat'" <raph@8d.com>,
"'Tony Lindgren'" <tony@atomide.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 0/6] OMAPDSS: remove cpu_is_* calls
Date: Thu, 04 Oct 2012 10:33:38 +0900 [thread overview]
Message-ID: <005d01cda1d0$47a249e0$d6e6dda0$%han@samsung.com> (raw)
In-Reply-To: <1348828527-13309-1-git-send-email-tomi.valkeinen@ti.com>
On Friday, September 28, 2012 7:35 PM Tomi Valkeinen wrote
>
> Hi,
>
> This series adds an omapdss_version enum that is passed via platform data to
> omapdss driver. This version identifier is then used instead of cpu_is_*()
> calls.
Hi Tomi,
As you mentioned, cpu_is_*() is not preferable in driver.
Actually, I thought so, when I saw the OMAPDSS driver a few months ago.
Anyway, it looks good. :)
Best regards,
Jingoo Han
>
> After these, omapdss no longer contains any plat/ or mach/ includes. omapfb,
> vrfb and vram still do, though.
>
> Tomi
>
> Tomi Valkeinen (6):
> OMAPDSS: add omapdss_version
> OMAPDSS: use omapdss_version in dss_features.c
> OMAPDSS: DISPC: use omapdss_version
> OMAPDSS: DSS: use omapdss_version
> OMAPDSS: HDMI: use omapdss_version
> OMAPDSS: remove <plat/cpu.h> includes
>
> arch/arm/mach-omap2/display.c | 38 +++++++++++++++++++
> drivers/video/omap2/dss/core.c | 2 +-
> drivers/video/omap2/dss/dispc.c | 41 +++++++++++++-------
> drivers/video/omap2/dss/dss.c | 39 +++++++++++++------
> drivers/video/omap2/dss/dss_features.c | 64 ++++++++++++++++++++++----------
> drivers/video/omap2/dss/dss_features.h | 5 ++-
> drivers/video/omap2/dss/hdmi.c | 3 +-
> include/video/omapdss.h | 14 +++++++
> 8 files changed, 157 insertions(+), 49 deletions(-)
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-04 1:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 10:35 [PATCH 0/6] OMAPDSS: remove cpu_is_* calls Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-09-28 10:35 ` [PATCH 1/6] OMAPDSS: add omapdss_version Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-09-28 10:44 ` Tomi Valkeinen
2012-09-28 10:44 ` Tomi Valkeinen
2012-09-28 11:00 ` Archit Taneja
2012-09-28 11:12 ` Archit Taneja
2012-09-28 11:07 ` Tomi Valkeinen
2012-09-28 11:07 ` Tomi Valkeinen
2012-09-28 10:35 ` [PATCH 2/6] OMAPDSS: use omapdss_version in dss_features.c Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-09-28 10:35 ` [PATCH 3/6] OMAPDSS: DISPC: use omapdss_version Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-09-28 10:35 ` [PATCH 4/6] OMAPDSS: DSS: " Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-09-28 10:35 ` [PATCH 5/6] OMAPDSS: HDMI: " Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-09-28 10:35 ` [PATCH 6/6] OMAPDSS: remove <plat/cpu.h> includes Tomi Valkeinen
2012-09-28 10:35 ` Tomi Valkeinen
2012-10-04 1:33 ` Jingoo Han [this message]
2012-10-04 1:33 ` [PATCH 0/6] OMAPDSS: remove cpu_is_* calls Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005d01cda1d0$47a249e0$d6e6dda0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=a0393947@ti.com \
--cc=cmahapatra@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=raph@8d.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.