From: Jungseok Lee <jays.lee@samsung.com>
To: "'Mitchel Humpherys'" <mitchelh@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, Catalin.Marinas@arm.com,
"'Marc Zyngier'" <Marc.Zyngier@arm.com>,
"'Christoffer Dall'" <christoffer.dall@linaro.org>,
kgene.kim@samsung.com, steve.capper@linaro.org,
"'Arnd Bergmann'" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, ilho215.lee@samsung.com,
"'linux-samsung-soc'" <linux-samsung-soc@vger.kernel.org>,
sungjinn.chung@samsung.com
Subject: Re: [PATCH v4 1/7] arm64: Use pr_* instead of printk
Date: Wed, 30 Apr 2014 11:32:32 +0900 [thread overview]
Message-ID: <007c01cf641c$708af310$51a0d930$@samsung.com> (raw)
In-Reply-To: <vnkwsioveuwk.fsf@mitchelh-linux.qualcomm.com>
On Wednesday, April 30, 2014 5:35 AM, Mitchel Humpherys wrote:
> On Mon, Apr 28 2014 at 09:59:14 PM, Jungseok Lee <jays.lee@samsung.com> wrote:
> > This patch fixed the following checkpatch complaint as using pr_*
> > instead of printk.
> >
> > WARNING: printk() should include KERN_ facility level
> >
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Signed-off-by: Jungseok Lee <jays.lee@samsung.com>
> > Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com>
> > ---
> > arch/arm64/kernel/traps.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
> > index 7ffaddd..0484e81 100644
> > --- a/arch/arm64/kernel/traps.c
> > +++ b/arch/arm64/kernel/traps.c
> > @@ -65,7 +65,7 @@ static void dump_mem(const char *lvl, const char *str, unsigned long bottom,
> > fs = get_fs();
> > set_fs(KERNEL_DS);
> >
> > - printk("%s%s(0x%016lx to 0x%016lx)\n", lvl, str, bottom, top);
> > + pr_emerg("%s%s(0x%016lx to 0x%016lx)\n", lvl, str, bottom, top);
>
> Currently this printk is being called with lvl=KERN_EMERG or lvl="". In the case of lvl=KERN_EMERG
> leaving lvl in is redundant. In the case of lvl="" this is a behavioral change (printing to a
> different log level). Was this intended?
No intention. I will drop the change in the next version.
Thanks!!
Best Regards
Jungseok Lee
WARNING: multiple messages have this Message-ID (diff)
From: jays.lee@samsung.com (Jungseok Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/7] arm64: Use pr_* instead of printk
Date: Wed, 30 Apr 2014 11:32:32 +0900 [thread overview]
Message-ID: <007c01cf641c$708af310$51a0d930$@samsung.com> (raw)
In-Reply-To: <vnkwsioveuwk.fsf@mitchelh-linux.qualcomm.com>
On Wednesday, April 30, 2014 5:35 AM, Mitchel Humpherys wrote:
> On Mon, Apr 28 2014 at 09:59:14 PM, Jungseok Lee <jays.lee@samsung.com> wrote:
> > This patch fixed the following checkpatch complaint as using pr_*
> > instead of printk.
> >
> > WARNING: printk() should include KERN_ facility level
> >
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Signed-off-by: Jungseok Lee <jays.lee@samsung.com>
> > Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com>
> > ---
> > arch/arm64/kernel/traps.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
> > index 7ffaddd..0484e81 100644
> > --- a/arch/arm64/kernel/traps.c
> > +++ b/arch/arm64/kernel/traps.c
> > @@ -65,7 +65,7 @@ static void dump_mem(const char *lvl, const char *str, unsigned long bottom,
> > fs = get_fs();
> > set_fs(KERNEL_DS);
> >
> > - printk("%s%s(0x%016lx to 0x%016lx)\n", lvl, str, bottom, top);
> > + pr_emerg("%s%s(0x%016lx to 0x%016lx)\n", lvl, str, bottom, top);
>
> Currently this printk is being called with lvl=KERN_EMERG or lvl="". In the case of lvl=KERN_EMERG
> leaving lvl in is redundant. In the case of lvl="" this is a behavioral change (printing to a
> different log level). Was this intended?
No intention. I will drop the change in the next version.
Thanks!!
Best Regards
Jungseok Lee
next prev parent reply other threads:[~2014-04-30 2:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 4:59 [PATCH v4 1/7] arm64: Use pr_* instead of printk Jungseok Lee
2014-04-29 4:59 ` Jungseok Lee
2014-04-29 20:35 ` Mitchel Humpherys
2014-04-29 20:35 ` Mitchel Humpherys
2014-04-30 2:32 ` Jungseok Lee [this message]
2014-04-30 2:32 ` Jungseok Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007c01cf641c$708af310$51a0d930$@samsung.com' \
--to=jays.lee@samsung.com \
--cc=Catalin.Marinas@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=arnd@arndb.de \
--cc=christoffer.dall@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
--cc=steve.capper@linaro.org \
--cc=sungjinn.chung@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.