From: "Doug Smythies" <dsmythies@telus.net>
To: "'Shuah Khan'" <skhan@linuxfoundation.org>,
"'Huang Rui'" <ray.huang@amd.com>, <li.meng@amd.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
"'Rafael J. Wysocki'" <rafael@kernel.org>,
<linux-kselftest@vger.kernel.org>,
"Doug Smythies" <dsmythies@telus.net>, <sedat.dilek@gmail.com>
Subject: RE: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
Date: Thu, 26 Jan 2023 14:43:53 -0800 [thread overview]
Message-ID: <008501d931d7$aaba8360$002f8a20$@telus.net> (raw)
In-Reply-To: <c38ba6b9-b748-cf84-92bd-d29211b10f24@linuxfoundation.org>
On 2023.01.25 09:03 Shuah Khan wrote:
> On 1/21/23 09:41, Doug Smythies wrote:
>> Revert the portion of a recent Makefile change that incorrectly
>> deletes source files when doing "make clean".
>>
>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Acked-by: Huang Rui <ray.huang@amd.com>
>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>> ---
>> v2: fix address list.
>> ---
>> tools/testing/selftests/amd-pstate/Makefile | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
>> index 5f195ee756d6..5fd1424db37d 100644
>> --- a/tools/testing/selftests/amd-pstate/Makefile
>> +++ b/tools/testing/selftests/amd-pstate/Makefile
>> @@ -7,11 +7,6 @@ all:
>> uname_M := $(shell uname -m 2>/dev/null || echo not)
>> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>>
>> -ifeq (x86,$(ARCH))
>> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
>> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
>> -endif
>> -
>
> This looks good - Do you need these files to run this test and if so
> do these need to installed when the test is run on a test system?
I do not know.
It is a question for the AMD people.
> Now applied to linux-kselftest fixes. I will send this up for the next
> rc.
Thank you
... Doug
next prev parent reply other threads:[~2023-01-26 22:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 5:54 [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Doug Smythies
2023-01-20 9:17 ` Huang Rui
2023-01-20 16:11 ` Sedat Dilek
2023-01-20 16:15 ` Shuah Khan
2023-01-20 16:20 ` Sedat Dilek
2023-01-20 16:23 ` Shuah Khan
2023-01-20 16:06 ` Sedat Dilek
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2023-01-21 16:58 ` Sedat Dilek
2023-01-25 17:03 ` Shuah Khan
2023-01-26 22:43 ` Doug Smythies [this message]
2023-02-03 15:15 ` Guillaume Tucker
2023-02-03 16:26 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008501d931d7$aaba8360$002f8a20$@telus.net' \
--to=dsmythies@telus.net \
--cc=li.meng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=sedat.dilek@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.