Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile

From: Shuah Khan <skhan@linuxfoundation.org>
To: sedat.dilek@gmail.com
Cc: Huang Rui <ray.huang@amd.com>,
	Doug Smythies <dsmythies@telus.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
Date: Fri, 20 Jan 2023 09:23:29 -0700	[thread overview]
Message-ID: <c9eeaa5a-9efd-f6a8-b223-1211d4528e19@linuxfoundation.org> (raw)
In-Reply-To: <CA+icZUVgt422h2nOfhjyahMF2yX_Eon613Ep7=gJ5XRWDAMkmw@mail.gmail.com>

On 1/20/23 09:20, Sedat Dilek wrote:
> On Fri, Jan 20, 2023 at 5:15 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> On 1/20/23 09:11, Sedat Dilek wrote:
>>> On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote:
>>>>
>>>> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
>>>>> Revert the portion of a recent Makefile change that incorrectly
>>>>> deletes source files when doing "make clean".
>>
>> Ooo. That is bad.
>>
>>>>>
>>>>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>>>>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>>>>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>>>>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>>>>
>>>> (+ Shuah and linux-kselftest mailing list)
>>>>
>>>> Thanks for fix!
>>>>
>>>> Acked-by: Huang Rui <ray.huang@amd.com>
>>>>
>>>
>>> [ I already replied - but with these important CCs ]
>>>
>>> Hi Doug,
>>>
>>> Thanks for the patch!
>>>
>>> Small nit, I saw this with:
>>
>> What did you see and should that be fixed as well.
>>
>>>
>>> $ make -C tools/ clean
>>>
>>> Otherwise:
>>>
>>> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
>>>
>>
>> Send me the revised patch with all the right CCs and I will pull
>> this right away.
>>
> 
> Hi Shuah,
> 
> that was my original posting...
> 
> Subject: [6.2-rc4] tools: {amd,intel}_pstate_tracer: make -C tools/ clean
> https://lore.kernel.org/all/CA+icZUUOckm1kwOEZhSw8zsaL5z7r8uczwiKeKGEVioZ=GeFNg@mail.gmail.com/
> 
> ...and should contain all CCs I got with scripts/get_maintainer.pl.
> 
> Is that OK?
> 

Yes - the current list looks complete to me.

thanks,
-- Shuah