RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize

From: 廖崇榮 <kt.liao@emc.com.tw>
To: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>
Cc: "'KT Liao'" <ktalex.liao@gmail.com>,
	<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
	<phoenix@emc.com.tw>
Subject: RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize
Date: Tue, 12 Jul 2016 22:19:07 +0800	[thread overview]
Message-ID: <008a01d1dc48$5a2957f0$0e7c07d0$@emc.com.tw> (raw)
In-Reply-To: <20160711170321.GB26822@dtor-ws>

Hi Dmitry,

-----Original Message-----
From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@gmail.com] 
Sent: Tuesday, July 12, 2016 1:03 AM
To: 廖崇榮
Cc: 'KT Liao'; linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; phoenix@emc.com.tw
Subject: Re: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize

On Mon, Jul 11, 2016 at 08:40:58PM +0800, 廖崇榮 wrote:
> > +
> > +	error = data->ops->get_sm_version(client, &data->ic_type,
> > +					  &data->sm_version);
> > +	if (error)
> > +		return false;
> 
> That means we'd be fetching product ID and IC type twice when initializing the device. Can we come with a way to do it once?
> [KT]:Because the elan_query_device_info() is behind the elan_initialize(). That's why I fetching product ID and IC type in the elan_initialize()
>     I will discuss with FW team and then execute elan_query_device_info() first to get product_id and ic_type. 

We might need to split fetching product ID and IC type form the rest of the device info.
[KT] : ok, I will extract "product ID" and "IC type" to another query-device function. and it won't change original flow too much.

Thanks.

--
Dmitry