From: dhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org To: Stephen Boyd <swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org Subject: Re: [v2] msm: disp: dpu1: add support to access hw irqs regs depending on revision Date: Tue, 19 Nov 2019 12:40:58 +0000 [thread overview] Message-ID: <0101016e83ae256e-d09a6f18-5a58-4bce-8a60-7075ef0329a4-000000@us-west-2.amazonses.com> (raw) In-Reply-To: <5dcd8f05.1c69fb81.bdd4.2b0a-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org> On 2019-11-14 22:59, Stephen Boyd wrote: > Quoting Shubhashree Dhar (2019-11-13 21:56:16) >> Current code assumes that all the irqs registers offsets can be >> accessed in all the hw revisions; this is not the case for some >> targets that should not access some of the irq registers. > > What happens if we read the irq registers that we "should not access"? > Does the system reset? It would be easier to make those registers > return > 0 when read indicating no interrupt and ignore writes so that > everything > keeps working without having to skip registers. > In some of the hw revisions, the whole hw block is absent and trying to access those registers causes system panic(bus noc error). >> This change adds the support to selectively remove the irqs that >> are not supported in some of the hw revisions. >> >> Change-Id: I6052b8237b703a1a9edd53893e04f7bd72223da1 > > Please remove these before sending upstream. > >> Signed-off-by: Shubhashree Dhar <dhar@codeaurora.org> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 3 +++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 22 >> +++++++++++++++++----- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 1 + >> 4 files changed, 22 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> index ec76b868..def8a3f 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> @@ -646,6 +646,7 @@ struct dpu_perf_cfg { >> * @dma_formats Supported formats for dma pipe >> * @cursor_formats Supported formats for cursor pipe >> * @vig_formats Supported formats for vig pipe >> + * @mdss_irqs Bitmap with the irqs supported by the target > > Hmm pretty sure there needs to be a colon so that kernel-doc can match > this but maybe I'm wrong. > >> */ >> struct dpu_mdss_cfg { >> u32 hwversion; _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: dhar@codeaurora.org To: Stephen Boyd <swboyd@chromium.org> Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, abhinavk@codeaurora.org, hoegsberg@chromium.org, freedreno@lists.freedesktop.org, chandanu@codeaurora.org Subject: Re: [v2] msm: disp: dpu1: add support to access hw irqs regs depending on revision Date: Tue, 19 Nov 2019 12:40:58 +0000 [thread overview] Message-ID: <0101016e83ae256e-d09a6f18-5a58-4bce-8a60-7075ef0329a4-000000@us-west-2.amazonses.com> (raw) Message-ID: <20191119124058.tgVgoK3zuB-c4cXQUxLNRioJ8f3V9NLOmguG6hLmLqM@z> (raw) In-Reply-To: <5dcd8f05.1c69fb81.bdd4.2b0a@mx.google.com> On 2019-11-14 22:59, Stephen Boyd wrote: > Quoting Shubhashree Dhar (2019-11-13 21:56:16) >> Current code assumes that all the irqs registers offsets can be >> accessed in all the hw revisions; this is not the case for some >> targets that should not access some of the irq registers. > > What happens if we read the irq registers that we "should not access"? > Does the system reset? It would be easier to make those registers > return > 0 when read indicating no interrupt and ignore writes so that > everything > keeps working without having to skip registers. > In some of the hw revisions, the whole hw block is absent and trying to access those registers causes system panic(bus noc error). >> This change adds the support to selectively remove the irqs that >> are not supported in some of the hw revisions. >> >> Change-Id: I6052b8237b703a1a9edd53893e04f7bd72223da1 > > Please remove these before sending upstream. > >> Signed-off-by: Shubhashree Dhar <dhar@codeaurora.org> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 3 +++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 22 >> +++++++++++++++++----- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 1 + >> 4 files changed, 22 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> index ec76b868..def8a3f 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h >> @@ -646,6 +646,7 @@ struct dpu_perf_cfg { >> * @dma_formats Supported formats for dma pipe >> * @cursor_formats Supported formats for cursor pipe >> * @vig_formats Supported formats for vig pipe >> + * @mdss_irqs Bitmap with the irqs supported by the target > > Hmm pretty sure there needs to be a colon so that kernel-doc can match > this but maybe I'm wrong. > >> */ >> struct dpu_mdss_cfg { >> u32 hwversion; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-19 12:40 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-14 5:56 [v2] msm: disp: dpu1: add support to access hw irqs regs depending on revision Shubhashree Dhar 2019-11-14 5:56 ` Shubhashree Dhar 2019-11-14 17:29 ` Stephen Boyd 2019-11-14 17:29 ` Stephen Boyd 2019-11-14 17:29 ` Stephen Boyd 2019-11-19 12:40 ` dhar [not found] ` <5dcd8f05.1c69fb81.bdd4.2b0a-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org> 2019-11-19 12:40 ` dhar-sgV2jX0FEOL9JmXXK+q4OQ [this message] 2019-11-19 12:40 ` dhar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0101016e83ae256e-d09a6f18-5a58-4bce-8a60-7075ef0329a4-000000@us-west-2.amazonses.com \ --to=dhar-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \ --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.