RE: [PATCH 1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks

From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
	<linux-pci@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
	<linux-phy@lists.infradead.org>
Cc: "'Jingoo Han'" <jingoohan1@gmail.com>,
	"'Lorenzo Pieralisi'" <lpieralisi@kernel.org>,
	"'Rob Herring'" <robh@kernel.org>,
	"'Krzysztof Wilczyński'" <kw@linux.com>,
	"'Bjorn Helgaas'" <bhelgaas@google.com>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>,
	"'Vinod Koul'" <vkoul@kernel.org>
Subject: RE: [PATCH 1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks
Date: Wed, 29 Jun 2022 11:57:15 +0900	[thread overview]
Message-ID: <015901d88b63$f023f0a0$d06bd1e0$@samsung.com> (raw)
In-Reply-To: <20220628220409.26545-1-m.szyprowski@samsung.com>

> The exynos-pcie driver called phy_power_on() and then phy_init() for some
> historical reasons. However the generic PHY framework assumes that the
> proper sequence is to call phy_init() first, then phy_power_on(). The
> operations done by both functions should be considered as one action and
> as such they are called by the exynos-pcie driver (without doing anything
> between them). The initialization is just a sequence of register writes,
> which cannot be altered, without breaking the hardware operation.
> 
> To match the generic PHY framework requirement, simply move all register
> writes to the phy_init()/phy_exit() and drop power_on()/power_off()
> callbacks. This way the driver will also work with the old (incorrect) PHY
> initialization call sequence.
> 
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park