From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre Bailon <abailon@baylibre.com>,
robh+dt@kernel.org, krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de
Cc: rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
rui.zhang@intel.com, michael.kao@mediatek.com,
ben.tseng@mediatek.com, ethan.chang@mediatek.com,
frank-w@public-files.de, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, khilman@baylibre.com
Subject: Re: [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller
Date: Thu, 12 May 2022 16:30:46 +0200 [thread overview]
Message-ID: <01d30e6c-5d0a-a5c0-851a-817277a8712d@linaro.org> (raw)
In-Reply-To: <20220512122433.1399802-5-abailon@baylibre.com>
On 12/05/2022 14:24, Alexandre Bailon wrote:
> This patch adds binding document for mt8195 thermal controller.
You just added this binding, no need to change it. Squash it with first
patch.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> .../devicetree/bindings/thermal/mediatek-thermal-lvts.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> index 69ffe7b14c21..2e1ae00d4fd1 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> @@ -12,7 +12,11 @@ maintainers:
>
> properties:
> compatible:
> - const: mediatek,mt6873-lvts
> + oneOf:
Why oneOf? There is just one item below?
> + - items:
No items, you have only one item.
> + - enum:
> + - mediatek,mt6873-lvts
> + - mediatek,mt8195-lvts
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre Bailon <abailon@baylibre.com>,
robh+dt@kernel.org, krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de
Cc: devicetree@vger.kernel.org, daniel.lezcano@linaro.org,
rafael@kernel.org, khilman@baylibre.com,
linux-pm@vger.kernel.org, amitk@kernel.org,
linux-kernel@vger.kernel.org, michael.kao@mediatek.com,
ethan.chang@mediatek.com, linux-mediatek@lists.infradead.org,
rui.zhang@intel.com, ben.tseng@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller
Date: Thu, 12 May 2022 16:30:46 +0200 [thread overview]
Message-ID: <01d30e6c-5d0a-a5c0-851a-817277a8712d@linaro.org> (raw)
In-Reply-To: <20220512122433.1399802-5-abailon@baylibre.com>
On 12/05/2022 14:24, Alexandre Bailon wrote:
> This patch adds binding document for mt8195 thermal controller.
You just added this binding, no need to change it. Squash it with first
patch.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> .../devicetree/bindings/thermal/mediatek-thermal-lvts.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> index 69ffe7b14c21..2e1ae00d4fd1 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> @@ -12,7 +12,11 @@ maintainers:
>
> properties:
> compatible:
> - const: mediatek,mt6873-lvts
> + oneOf:
Why oneOf? There is just one item below?
> + - items:
No items, you have only one item.
> + - enum:
> + - mediatek,mt6873-lvts
> + - mediatek,mt8195-lvts
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre Bailon <abailon@baylibre.com>,
robh+dt@kernel.org, krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de
Cc: rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
rui.zhang@intel.com, michael.kao@mediatek.com,
ben.tseng@mediatek.com, ethan.chang@mediatek.com,
frank-w@public-files.de, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, khilman@baylibre.com
Subject: Re: [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller
Date: Thu, 12 May 2022 16:30:46 +0200 [thread overview]
Message-ID: <01d30e6c-5d0a-a5c0-851a-817277a8712d@linaro.org> (raw)
In-Reply-To: <20220512122433.1399802-5-abailon@baylibre.com>
On 12/05/2022 14:24, Alexandre Bailon wrote:
> This patch adds binding document for mt8195 thermal controller.
You just added this binding, no need to change it. Squash it with first
patch.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> .../devicetree/bindings/thermal/mediatek-thermal-lvts.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> index 69ffe7b14c21..2e1ae00d4fd1 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> @@ -12,7 +12,11 @@ maintainers:
>
> properties:
> compatible:
> - const: mediatek,mt6873-lvts
> + oneOf:
Why oneOf? There is just one item below?
> + - items:
No items, you have only one item.
> + - enum:
> + - mediatek,mt6873-lvts
> + - mediatek,mt8195-lvts
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-12 14:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:24 [PATCH v6 0/7] Add LVTS architecture thermal Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` [PATCH v6 1/7] thermal: mediatek: Relocate driver to mediatek folder Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-17 11:54 ` Rex-BC Chen
2022-05-17 11:54 ` Rex-BC Chen
2022-05-17 11:54 ` Rex-BC Chen
2022-05-12 12:24 ` [PATCH v6 2/7] dt-bindings: thermal: Add binding document for mt6873 thermal controller Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 14:25 ` Krzysztof Kozlowski
2022-05-12 14:25 ` Krzysztof Kozlowski
2022-05-12 14:25 ` Krzysztof Kozlowski
2022-05-17 17:59 ` Rob Herring
2022-05-17 17:59 ` Rob Herring
2022-05-17 17:59 ` Rob Herring
2022-05-12 12:24 ` [PATCH v6 3/7] thermal: mediatek: Add LVTS drivers for SoC theraml zones Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 14:29 ` Krzysztof Kozlowski
2022-05-12 14:29 ` Krzysztof Kozlowski
2022-05-12 14:29 ` Krzysztof Kozlowski
2022-05-17 12:13 ` Rex-BC Chen
2022-05-17 12:13 ` Rex-BC Chen
2022-05-17 12:13 ` Rex-BC Chen
2022-05-12 12:24 ` [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 14:30 ` Krzysztof Kozlowski [this message]
2022-05-12 14:30 ` Krzysztof Kozlowski
2022-05-12 14:30 ` Krzysztof Kozlowski
2022-05-12 12:24 ` [PATCH v6 5/7] thermal: mediatek: Add thermal zone settings for mt8195 Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` [PATCH v6 6/7] arm64: dts: mt8195: Add efuse node to mt8195 Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` [PATCH v6 7/7] arm64: dts: mt8195: Add thermal zone Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 12:24 ` Alexandre Bailon
2022-05-12 14:32 ` Krzysztof Kozlowski
2022-05-12 14:32 ` Krzysztof Kozlowski
2022-05-12 14:32 ` Krzysztof Kozlowski
2022-05-12 12:33 ` [PATCH v6 0/7] Add LVTS architecture thermal Lothar Waßmann
2022-05-12 12:33 ` Lothar Waßmann
2022-05-12 12:33 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d30e6c-5d0a-a5c0-851a-817277a8712d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=ben.tseng@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ethan.chang@mediatek.com \
--cc=frank-w@public-files.de \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michael.kao@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.