From: chen <547884940-9uewiaClKEY@public.gmane.org> To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>, Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org> Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb Date: Sat, 1 Jul 2017 20:55:04 +0800 [thread overview] Message-ID: <0200fd0a-b914-b31e-d76e-0b46fc59b876@qq.com> (raw) In-Reply-To: <10342435.5c883YxTZd@phil> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=UTF-8; format=flowed, Size: 1691 bytes --] Hi heiko, Heiko Stuebner wrote on 2017å¹´07æ01æ¥ 19:06: > Hi Jacob, > > Am Samstag, 1. Juli 2017, 10:02:46 CEST schrieb Jacob Chen: >> saradc in rk3288-evb use 1.8v ref. >> >> Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org> >> --- >> arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi >> index f226ca7..9cee856 100644 >> --- a/arch/arm/boot/dts/rk3288-evb.dtsi >> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi >> @@ -129,6 +129,15 @@ >> }; >> }; >> >> + vccadc_ref: vccadc-ref { >> + compatible = "regulator-fixed"; >> + regulator-name = "vcc1v8_sys"; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; > this looks wrong. Regulators should always be named with the name > used in schematics and also, according to the rk3288-evb schematics > I have here, the saradc uses vcc_18 directly which comes from either > the rk808 or act8846 pmics (depending on the board version). > OK, I don't have software to check that schematics... Agree and i will send a new patch. >> + >> /* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */ >> vcc_host: vcc-host-regulator { >> compatible = "regulator-fixed"; >> @@ -218,6 +227,11 @@ >> status = "okay"; >> }; >> >> +&saradc { >> + vref-supply = <&vccadc_ref>; > So taking the above into account > vref-supply = <&vcc_18>; ? > > > Heiko > >> + status = "okay"; >> +}; >> + >> &sdmmc { >> bus-width = <4>; >> cap-mmc-highspeed; >> > > TÑ\v [-- Attachment #2: Type: text/plain, Size: 200 bytes --] _______________________________________________ Linux-rockchip mailing list Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: 547884940@qq.com (chen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb Date: Sat, 1 Jul 2017 20:55:04 +0800 [thread overview] Message-ID: <0200fd0a-b914-b31e-d76e-0b46fc59b876@qq.com> (raw) In-Reply-To: <10342435.5c883YxTZd@phil> Hi heiko, Heiko Stuebner wrote on 2017?07?01? 19:06: > Hi Jacob, > > Am Samstag, 1. Juli 2017, 10:02:46 CEST schrieb Jacob Chen: >> saradc in rk3288-evb use 1.8v ref. >> >> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> >> --- >> arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi >> index f226ca7..9cee856 100644 >> --- a/arch/arm/boot/dts/rk3288-evb.dtsi >> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi >> @@ -129,6 +129,15 @@ >> }; >> }; >> >> + vccadc_ref: vccadc-ref { >> + compatible = "regulator-fixed"; >> + regulator-name = "vcc1v8_sys"; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; > this looks wrong. Regulators should always be named with the name > used in schematics and also, according to the rk3288-evb schematics > I have here, the saradc uses vcc_18 directly which comes from either > the rk808 or act8846 pmics (depending on the board version). > OK, I don't have software to check that schematics... Agree and i will send a new patch. >> + >> /* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */ >> vcc_host: vcc-host-regulator { >> compatible = "regulator-fixed"; >> @@ -218,6 +227,11 @@ >> status = "okay"; >> }; >> >> +&saradc { >> + vref-supply = <&vccadc_ref>; > So taking the above into account > vref-supply = <&vcc_18>; ? > > > Heiko > >> + status = "okay"; >> +}; >> + >> &sdmmc { >> bus-width = <4>; >> cap-mmc-highspeed; >> > >
next prev parent reply other threads:[~2017-07-01 12:55 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-01 2:02 [PATCH 0/5] some devicetree changes for rk3288 boards Jacob Chen 2017-07-01 2:02 ` Jacob Chen [not found] ` <1498874567-11219-1-git-send-email-jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org> 2017-07-01 2:02 ` [PATCH 1/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker Jacob Chen 2017-07-01 2:02 ` Jacob Chen 2017-07-01 2:02 ` [PATCH 2/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb Jacob Chen 2017-07-01 2:02 ` Jacob Chen 2017-07-01 2:02 ` [PATCH 3/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec Jacob Chen 2017-07-01 2:02 ` Jacob Chen 2017-07-01 2:02 ` [PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb Jacob Chen 2017-07-01 2:02 ` Jacob Chen [not found] ` <1498874567-11219-5-git-send-email-jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org> 2017-07-01 11:06 ` Heiko Stuebner 2017-07-01 11:06 ` Heiko Stuebner 2017-07-01 12:55 ` chen [this message] 2017-07-01 12:55 ` chen 2017-07-01 2:02 ` [PATCH 5/5] ARM: dts: rockchip: enable adc key " Jacob Chen 2017-07-01 2:02 ` Jacob Chen 2017-07-01 19:26 ` [PATCH 0/5] some devicetree changes for rk3288 boards Heiko Stuebner 2017-07-01 19:26 ` Heiko Stuebner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0200fd0a-b914-b31e-d76e-0b46fc59b876@qq.com \ --to=547884940-9uewiaclkey@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \ --cc=jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.