From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
iommu@lists.linux-foundation.org, Yong Wu <yong.wu@mediatek.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:MEDIATEK IOMMU DRIVER"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
kernel@collabora.com, linux-media@vger.kernel.org,
sebastian.reichel@collabora.com
Subject: Re: [PATCH v2 5/5] iommu/mediatek: Always tlb_flush_all when each PM resume
Date: Mon, 10 Jan 2022 12:44:32 +0100 [thread overview]
Message-ID: <02719a0f-9725-abc5-f5c4-acbb4bfac08d@collabora.com> (raw)
In-Reply-To: <20211208120744.2415-6-dafna.hirschfeld@collabora.com>
Il 08/12/21 13:07, Dafna Hirschfeld ha scritto:
> From: Yong Wu <yong.wu@mediatek.com>
>
> Prepare for 2 HWs that sharing pgtable in different power-domains.
>
> When there are 2 M4U HWs, it may has problem in the flush_range in which
> we get the pm_status via the m4u dev, BUT that function don't reflect the
> real power-domain status of the HW since there may be other HW also use
> that power-domain.
>
> DAM allocation is often done while the allocating device is runtime
> suspended. In such a case the iommu will also be suspended and partial
> flushing of the tlb will not be executed.
> Therefore, we add a tlb_flush_all in the pm_runtime_resume to make
> sure the tlb is always clean.
>
> In other case, the iommu's power should be active via device
> link with smi.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> [move the call to mtk_iommu_tlb_flush_all to the bottom of resume cb, improve doc/log]
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
iommu@lists.linux-foundation.org, Yong Wu <yong.wu@mediatek.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:MEDIATEK IOMMU DRIVER"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
kernel@collabora.com, linux-media@vger.kernel.org,
sebastian.reichel@collabora.com
Subject: Re: [PATCH v2 5/5] iommu/mediatek: Always tlb_flush_all when each PM resume
Date: Mon, 10 Jan 2022 12:44:32 +0100 [thread overview]
Message-ID: <02719a0f-9725-abc5-f5c4-acbb4bfac08d@collabora.com> (raw)
In-Reply-To: <20211208120744.2415-6-dafna.hirschfeld@collabora.com>
Il 08/12/21 13:07, Dafna Hirschfeld ha scritto:
> From: Yong Wu <yong.wu@mediatek.com>
>
> Prepare for 2 HWs that sharing pgtable in different power-domains.
>
> When there are 2 M4U HWs, it may has problem in the flush_range in which
> we get the pm_status via the m4u dev, BUT that function don't reflect the
> real power-domain status of the HW since there may be other HW also use
> that power-domain.
>
> DAM allocation is often done while the allocating device is runtime
> suspended. In such a case the iommu will also be suspended and partial
> flushing of the tlb will not be executed.
> Therefore, we add a tlb_flush_all in the pm_runtime_resume to make
> sure the tlb is always clean.
>
> In other case, the iommu's power should be active via device
> link with smi.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> [move the call to mtk_iommu_tlb_flush_all to the bottom of resume cb, improve doc/log]
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
iommu@lists.linux-foundation.org, Yong Wu <yong.wu@mediatek.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:MEDIATEK IOMMU DRIVER"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
kernel@collabora.com, linux-media@vger.kernel.org,
sebastian.reichel@collabora.com
Subject: Re: [PATCH v2 5/5] iommu/mediatek: Always tlb_flush_all when each PM resume
Date: Mon, 10 Jan 2022 12:44:32 +0100 [thread overview]
Message-ID: <02719a0f-9725-abc5-f5c4-acbb4bfac08d@collabora.com> (raw)
In-Reply-To: <20211208120744.2415-6-dafna.hirschfeld@collabora.com>
Il 08/12/21 13:07, Dafna Hirschfeld ha scritto:
> From: Yong Wu <yong.wu@mediatek.com>
>
> Prepare for 2 HWs that sharing pgtable in different power-domains.
>
> When there are 2 M4U HWs, it may has problem in the flush_range in which
> we get the pm_status via the m4u dev, BUT that function don't reflect the
> real power-domain status of the HW since there may be other HW also use
> that power-domain.
>
> DAM allocation is often done while the allocating device is runtime
> suspended. In such a case the iommu will also be suspended and partial
> flushing of the tlb will not be executed.
> Therefore, we add a tlb_flush_all in the pm_runtime_resume to make
> sure the tlb is always clean.
>
> In other case, the iommu's power should be active via device
> link with smi.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> [move the call to mtk_iommu_tlb_flush_all to the bottom of resume cb, improve doc/log]
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
iommu@lists.linux-foundation.org, Yong Wu <yong.wu@mediatek.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:MEDIATEK IOMMU DRIVER"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
kernel@collabora.com, linux-media@vger.kernel.org,
sebastian.reichel@collabora.com
Subject: Re: [PATCH v2 5/5] iommu/mediatek: Always tlb_flush_all when each PM resume
Date: Mon, 10 Jan 2022 12:44:32 +0100 [thread overview]
Message-ID: <02719a0f-9725-abc5-f5c4-acbb4bfac08d@collabora.com> (raw)
In-Reply-To: <20211208120744.2415-6-dafna.hirschfeld@collabora.com>
Il 08/12/21 13:07, Dafna Hirschfeld ha scritto:
> From: Yong Wu <yong.wu@mediatek.com>
>
> Prepare for 2 HWs that sharing pgtable in different power-domains.
>
> When there are 2 M4U HWs, it may has problem in the flush_range in which
> we get the pm_status via the m4u dev, BUT that function don't reflect the
> real power-domain status of the HW since there may be other HW also use
> that power-domain.
>
> DAM allocation is often done while the allocating device is runtime
> suspended. In such a case the iommu will also be suspended and partial
> flushing of the tlb will not be executed.
> Therefore, we add a tlb_flush_all in the pm_runtime_resume to make
> sure the tlb is always clean.
>
> In other case, the iommu's power should be active via device
> link with smi.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> [move the call to mtk_iommu_tlb_flush_all to the bottom of resume cb, improve doc/log]
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-10 11:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 12:07 [PATCH v2 0/5] iommu/mediatek: Fix tlb flush logic Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` [PATCH v2 1/5] iommu/mediatek: Remove for_each_m4u in tlb_sync_all Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2022-01-10 11:42 ` AngeloGioacchino Del Regno
2022-01-10 11:42 ` AngeloGioacchino Del Regno
2022-01-10 11:42 ` AngeloGioacchino Del Regno
2022-01-10 11:42 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 2/5] iommu/mediatek: Always check runtime PM status in tlb flush range callback Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-13 7:53 ` Yong Wu
2021-12-13 7:53 ` Yong Wu
2021-12-13 7:53 ` Yong Wu
2021-12-13 7:53 ` Yong Wu
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 3/5] iommu/mediatek: Remove the power status checking in tlb flush all Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 4/5] iommu/mediatek: Add tlb_lock in tlb_flush_all Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 5/5] iommu/mediatek: Always tlb_flush_all when each PM resume Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2021-12-08 12:07 ` Dafna Hirschfeld
2022-01-10 11:44 ` AngeloGioacchino Del Regno [this message]
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-03-04 10:05 ` [PATCH v2 0/5] iommu/mediatek: Fix tlb flush logic Joerg Roedel
2022-03-04 10:05 ` Joerg Roedel
2022-03-04 10:05 ` Joerg Roedel
2022-03-04 10:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02719a0f-9725-abc5-f5c4-acbb4bfac08d@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sebastian.reichel@collabora.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.