All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangyu Hua <hbh25y@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
	stefan.maetje@esd.eu, mailhol.vincent@wanadoo.fr,
	paskripkin@gmail.com, linux-can@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: usb: delete a redundant dev_kfree_skb() in ems_usb_start_xmit()
Date: Fri, 11 Mar 2022 16:22:58 +0800	[thread overview]
Message-ID: <03303592-ad5c-ffd0-80f5-8d1e64c2b011@gmail.com> (raw)
In-Reply-To: <f0e068ce-49bf-a13d-53ff-d81b4f5a8a65@gmail.com>

Hi Marc,

I didn't find this("can: usb: ems_usb_start_xmit(): fix double 
dev_kfree_skb() in error path") in can/testing. Did I miss it or did you 
forget to submit it?

Anyway, i find this problem also exists in two other places. You can 
check them in:
mcba_usb:
https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com/
usb_8dev:
https://lore.kernel.org/all/20220311080614.45229-1-hbh25y@gmail.com/

Thanks,
Hangyu


On 2022/2/28 18:47, Hangyu Hua wrote:
> All right. :)
> 
> On 2022/2/28 18:45, Marc Kleine-Budde wrote:
>> On 28.02.2022 18:44:06, Hangyu Hua wrote:
>>> I get it. I'll remake a patch that matches your suggestions.
>>
>> Not needed, it's already applied:
>>>> Added patch to can/testing.
>>
>> Marc
>>

      reply	other threads:[~2022-03-11  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  8:36 [PATCH] can: usb: delete a redundant dev_kfree_skb() in ems_usb_start_xmit() Hangyu Hua
2022-02-28  8:55 ` Marc Kleine-Budde
2022-02-28 10:44   ` Hangyu Hua
2022-02-28 10:45     ` Marc Kleine-Budde
2022-02-28 10:47       ` Hangyu Hua
2022-03-11  8:22         ` Hangyu Hua [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03303592-ad5c-ffd0-80f5-8d1e64c2b011@gmail.com \
    --to=hbh25y@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=paskripkin@gmail.com \
    --cc=stefan.maetje@esd.eu \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.