From: Hangyu Hua <hbh25y@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
stefan.maetje@esd.eu, mailhol.vincent@wanadoo.fr,
paskripkin@gmail.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: usb: delete a redundant dev_kfree_skb() in ems_usb_start_xmit()
Date: Mon, 28 Feb 2022 18:44:06 +0800 [thread overview]
Message-ID: <75c14302-b928-1e09-7cd1-78b8c2695f06@gmail.com> (raw)
In-Reply-To: <20220228085536.pa5wdq3w4ul5wqn5@pengutronix.de>
I get it. I'll remake a patch that matches your suggestions.
Thanks.
On 2022/2/28 16:55, Marc Kleine-Budde wrote:
> On 28.02.2022 16:36:39, Hangyu Hua wrote:
>> There is no need to call dev_kfree_skb when usb_submit_urb fails beacause
>> can_put_echo_skb deletes original skb and can_free_echo_skb deletes the cloned
>> skb.
>>
>> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>
> Thanks for the patch. Please add a Fixes tag, that points to the commit
> that introduced the problem, here it's:
>
> Fixes: 702171adeed3 ("ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface")
>
> I've adjusted the subject a bit ("can: usb: ems_usb_start_xmit(): fix
> double dev_kfree_skb() in error path") and added stable on Cc.
>
> Added patch to can/testing.
>
> regards,
> Marc
>
next prev parent reply other threads:[~2022-02-28 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 8:36 [PATCH] can: usb: delete a redundant dev_kfree_skb() in ems_usb_start_xmit() Hangyu Hua
2022-02-28 8:55 ` Marc Kleine-Budde
2022-02-28 10:44 ` Hangyu Hua [this message]
2022-02-28 10:45 ` Marc Kleine-Budde
2022-02-28 10:47 ` Hangyu Hua
2022-03-11 8:22 ` Hangyu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75c14302-b928-1e09-7cd1-78b8c2695f06@gmail.com \
--to=hbh25y@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=stefan.maetje@esd.eu \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.