From: Neil Armstrong <neil.armstrong@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 7/8] arm64: dts: qcom: sm8650-mtp: add interconnect dependent device nodes
Date: Wed, 25 Oct 2023 13:54:08 +0200 [thread overview]
Message-ID: <03630289-d25a-498a-9f24-ac7633b48ee7@linaro.org> (raw)
In-Reply-To: <c98a3141-13a2-4cb3-bbd0-74ff63446183@linaro.org>
On 25/10/2023 11:11, Konrad Dybcio wrote:
>
>
> On 10/25/23 09:47, Neil Armstrong wrote:
>> Now interconnect dependent devices are added in sm8650 DTSI,
>> now enable more devices for the Qualcomm SM8650 MTP board:
>> - PCIe
>> - Display
>> - DSPs
>> - SDCard
>> - UFS
>> - USB role switch with PMIC Glink
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> [...]
>
>> +&ufs_mem_hc {
>> + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
>> +
>> + vcc-supply = <&vreg_l17b_2p5>;
>> + vcc-max-microamp = <1300000>;
>> + vccq-supply = <&vreg_l1c_1p2>;
>> + vccq-max-microamp = <1200000>;
> You should amend these regulators' nodes with loadsetting
> and allowed mode properties
Ack will do that on both patches 7 & 8,
Thanks,
Neil
>
> Konrad
next prev parent reply other threads:[~2023-10-25 11:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:47 [PATCH RFC 0/8] arm64: dts: qcom: Introduce SM8650 platforms device tree Neil Armstrong
2023-10-25 7:47 ` [PATCH RFC 1/8] dt-bindings: arm: qcom: document SM8650 and the reference boards Neil Armstrong
2023-10-25 9:13 ` Krzysztof Kozlowski
2023-10-25 7:47 ` [PATCH RFC 2/8] arm64: dts: qcom: add initial SM8650 dtsi Neil Armstrong
2023-10-25 9:01 ` Konrad Dybcio
2023-10-25 11:55 ` Neil Armstrong
2023-11-02 10:54 ` Neil Armstrong
2023-11-02 13:32 ` Konrad Dybcio
2023-11-06 8:22 ` neil.armstrong
2023-10-25 7:47 ` [PATCH RFC 3/8] arm64: dts: qcom: pm8550ve: make PMK8550VE SID configurable Neil Armstrong
2023-10-25 9:02 ` Konrad Dybcio
2023-10-25 9:03 ` Dmitry Baryshkov
2023-10-25 9:17 ` Krzysztof Kozlowski
2023-10-25 11:51 ` Neil Armstrong
2023-10-25 7:47 ` [PATCH RFC 4/8] arm64: dts: qcom: sm8650: add initial SM8650 MTP dts Neil Armstrong
2023-10-25 9:03 ` Konrad Dybcio
2023-10-26 7:07 ` kernel test robot
2023-10-25 7:47 ` [PATCH RFC 5/8] arm64: dts: qcom: sm8650: add initial SM8650 QRD dts Neil Armstrong
2023-10-25 9:03 ` Konrad Dybcio
2023-10-25 7:47 ` [PATCH RFC 6/8] arm64: dts: qcom: sm8650: add interconnect dependent device nodes Neil Armstrong
2023-10-25 9:10 ` Konrad Dybcio
2023-10-25 11:52 ` Neil Armstrong
2023-10-25 7:47 ` [PATCH RFC 7/8] arm64: dts: qcom: sm8650-mtp: " Neil Armstrong
2023-10-25 9:11 ` Konrad Dybcio
2023-10-25 11:54 ` Neil Armstrong [this message]
2023-10-25 7:47 ` [PATCH RFC 8/8] arm64: dts: qcom: sm8650-qrd: " Neil Armstrong
2023-10-25 9:11 ` Konrad Dybcio
2023-10-26 7:43 ` [PATCH RFC 0/8] arm64: dts: qcom: Introduce SM8650 platforms device tree Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03630289-d25a-498a-9f24-ac7633b48ee7@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.