Re: [PATCH RFC 2/8] arm64: dts: qcom: add initial SM8650 dtsi

From: neil.armstrong@linaro.org
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/8] arm64: dts: qcom: add initial SM8650 dtsi
Date: Mon, 6 Nov 2023 09:22:08 +0100	[thread overview]
Message-ID: <9f5f317a-4f3a-4bdd-b640-b75858bd79d4@linaro.org> (raw)
In-Reply-To: <30b4c424-39ee-7ae6-faf2-c5ba32dda07f@linaro.org>

On 02/11/2023 14:32, Konrad Dybcio wrote:
> 
> 
> On 02/11/2023 11:54, Neil Armstrong wrote:
>> On 25/10/2023 11:01, Konrad Dybcio wrote:
>>>
>>>
>>> On 10/25/23 09:47, Neil Armstrong wrote:
>>>> Add initial DTSI for the Qualcomm SM8650 platform,
>>>> only contains nodes which doesn't depend on interconnect.
>>>>
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---[...]
>>>
>>>> +            CLUSTER_SLEEP_1: cluster-sleep-1 {
>>>> +                compatible = "domain-idle-state";
>>>> +                arm,psci-suspend-param = <0x4100c344>;
>>> I think this parameter signals the AOSS to attempt system
>>> suspend and CLUSTER_SLEEP is a shallower, separate state.
>>
>> OK, so downstream call this state "APSS_OFF" and the other state
>> calling 0x41000044 "CLUSTER_PWR_DN"Well, the name APSS_OFF suggests that all clusters go offline so
> that would be a bit more complex than a simple "cut power to this
> cluster"
> 
> 
>> On sm8[345]0 and qdu1000/sm4450 there's both states called CLUSTER_SLEEP_0 and CLUSTER_SLEEP_1,
>> and referenced into CLUSTER_PD cluster power domain.
>>
>> I assume this is the same as SM8550, so what's the issue ?
> It's just that we've been naming it in the most generic way possible
> and that it could be more descriptive, especially given its
> correlation with different things

Ack, will change the naming

Neil

> 
> Konrad