All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: kvalo@codeaurora.org, mkenna@codeaurora.org,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Stefan Lippers-Hollmann <s.l-h@gmx.de>,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v5.8] ath10k: Fix NULL pointer dereference in AHB device probe
Date: Tue, 14 Jul 2020 19:20:22 -0700	[thread overview]
Message-ID: <03aa088e5d2b46f570372f72c430f93f@codeaurora.org> (raw)
In-Reply-To: <20200714205802.17688-1-hauke@hauke-m.de>

On 2020-07-14 13:58, Hauke Mehrtens wrote:
> This fixes a NULL pointer dereference in the probe path for AHB 
> devices.
> There attr parameter in the ath10k_ce_alloc_pipe() function is not
> initialized, but accessed. This function is called by
> ath10k_pci_setup_resource() which is called by ath10k_ahb_probe().
> 
> The struct ath10k_pci is also used for AHB devices and not only for PCI
> devices.
> 
> The initialization of the new members of struct ath10k_pci is moved to
> ath10k_pci_setup_resource() which is used by the PCI and the AHB code.
> 
> This also fixes a use after free bug in ath10k_pci_remove() when ar_pci
> is accessed after ath10k_core_destroy() was called, which calls
> ieee80211_free_hw() and frees this memory.
> 
> This fixes the following bug seen with backports-5.8-rc2 on OpenWrt on 
> a
> IPQ4019 device:
> 
Thanks Hauke for taking care of this. Your change LGTM.

-Rajkumar

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: mkenna@codeaurora.org, linux-wireless-owner@vger.kernel.org,
	Stefan Lippers-Hollmann <s.l-h@gmx.de>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	kvalo@codeaurora.org
Subject: Re: [PATCH v5.8] ath10k: Fix NULL pointer dereference in AHB device probe
Date: Tue, 14 Jul 2020 19:20:22 -0700	[thread overview]
Message-ID: <03aa088e5d2b46f570372f72c430f93f@codeaurora.org> (raw)
In-Reply-To: <20200714205802.17688-1-hauke@hauke-m.de>

On 2020-07-14 13:58, Hauke Mehrtens wrote:
> This fixes a NULL pointer dereference in the probe path for AHB 
> devices.
> There attr parameter in the ath10k_ce_alloc_pipe() function is not
> initialized, but accessed. This function is called by
> ath10k_pci_setup_resource() which is called by ath10k_ahb_probe().
> 
> The struct ath10k_pci is also used for AHB devices and not only for PCI
> devices.
> 
> The initialization of the new members of struct ath10k_pci is moved to
> ath10k_pci_setup_resource() which is used by the PCI and the AHB code.
> 
> This also fixes a use after free bug in ath10k_pci_remove() when ar_pci
> is accessed after ath10k_core_destroy() was called, which calls
> ieee80211_free_hw() and frees this memory.
> 
> This fixes the following bug seen with backports-5.8-rc2 on OpenWrt on 
> a
> IPQ4019 device:
> 
Thanks Hauke for taking care of this. Your change LGTM.

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2020-07-15  2:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 20:58 [PATCH v5.8] ath10k: Fix NULL pointer dereference in AHB device probe Hauke Mehrtens
2020-07-14 20:58 ` Hauke Mehrtens
2020-07-15  2:20 ` Rajkumar Manoharan [this message]
2020-07-15  2:20   ` Rajkumar Manoharan
2020-07-20 17:24 ` Kalle Valo
2020-07-20 17:24 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03aa088e5d2b46f570372f72c430f93f@codeaurora.org \
    --to=rmanohar@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=hauke@hauke-m.de \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mkenna@codeaurora.org \
    --cc=s.l-h@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.