From: <Conor.Dooley@microchip.com> To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org> Cc: <arnd@arndb.de>, <josh@joshtriplett.org>, <paul.walmsley@sifive.com>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>, <linux-api@vger.kernel.org>, <akpm@linux-foundation.org>, <linux-mm@kvack.org> Subject: Re: [PATCH v2] kernel/sys_ni: add compat entry for fadvise64_64 Date: Sat, 13 Aug 2022 17:03:25 +0000 [thread overview] Message-ID: <03c5f897-d4e2-8408-6116-ad7619ca385d@microchip.com> (raw) In-Reply-To: <20220807220934.5689-1-rdunlap@infradead.org> On 07/08/2022 23:09, Randy Dunlap wrote: > When CONFIG_ADVISE_SYSCALLS is not set/enabled and CONFIG_COMPAT is > set/enabled, the riscv compat_syscall_table references > 'compat_sys_fadvise64_64', which is not defined: > > riscv64-linux-ld: arch/riscv/kernel/compat_syscall_table.o:(.rodata+0x6f8): > undefined reference to `compat_sys_fadvise64_64' > > Add 'fadvise64_64' to kernel/sys_ni.c as a conditional COMPAT function > so that when CONFIG_ADVISE_SYSCALLS is not set, there is a fallback > function available. Is this in a 6.0 destined tree somewhere that I've missed? Bumped into it while looking at an unrelated LKP randconfig error. FWIW: Tested-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > Fixes: d3ac21cacc24 ("mm: Support compiling out madvise and fadvise") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Cc: Josh Triplett <josh@joshtriplett.org> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-api@vger.kernel.org > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-mm@kvack.org > --- > v2: patch kernel/sys_ni.c (for any arch) instead of arch/riscv's > unistd.h (Arnd) > > kernel/sys_ni.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -277,6 +277,7 @@ COND_SYSCALL(landlock_restrict_self); > > /* mm/fadvise.c */ > COND_SYSCALL(fadvise64_64); > +COND_SYSCALL_COMPAT(fadvise64_64); > > /* mm/, CONFIG_MMU only */ > COND_SYSCALL(swapon); > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com> To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org> Cc: <arnd@arndb.de>, <josh@joshtriplett.org>, <paul.walmsley@sifive.com>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>, <linux-api@vger.kernel.org>, <akpm@linux-foundation.org>, <linux-mm@kvack.org> Subject: Re: [PATCH v2] kernel/sys_ni: add compat entry for fadvise64_64 Date: Sat, 13 Aug 2022 17:03:25 +0000 [thread overview] Message-ID: <03c5f897-d4e2-8408-6116-ad7619ca385d@microchip.com> (raw) In-Reply-To: <20220807220934.5689-1-rdunlap@infradead.org> On 07/08/2022 23:09, Randy Dunlap wrote: > When CONFIG_ADVISE_SYSCALLS is not set/enabled and CONFIG_COMPAT is > set/enabled, the riscv compat_syscall_table references > 'compat_sys_fadvise64_64', which is not defined: > > riscv64-linux-ld: arch/riscv/kernel/compat_syscall_table.o:(.rodata+0x6f8): > undefined reference to `compat_sys_fadvise64_64' > > Add 'fadvise64_64' to kernel/sys_ni.c as a conditional COMPAT function > so that when CONFIG_ADVISE_SYSCALLS is not set, there is a fallback > function available. Is this in a 6.0 destined tree somewhere that I've missed? Bumped into it while looking at an unrelated LKP randconfig error. FWIW: Tested-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > Fixes: d3ac21cacc24 ("mm: Support compiling out madvise and fadvise") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Cc: Josh Triplett <josh@joshtriplett.org> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-api@vger.kernel.org > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-mm@kvack.org > --- > v2: patch kernel/sys_ni.c (for any arch) instead of arch/riscv's > unistd.h (Arnd) > > kernel/sys_ni.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -277,6 +277,7 @@ COND_SYSCALL(landlock_restrict_self); > > /* mm/fadvise.c */ > COND_SYSCALL(fadvise64_64); > +COND_SYSCALL_COMPAT(fadvise64_64); > > /* mm/, CONFIG_MMU only */ > COND_SYSCALL(swapon); > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-08-13 17:03 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-07 22:09 [PATCH v2] kernel/sys_ni: add compat entry for fadvise64_64 Randy Dunlap 2022-08-07 22:09 ` Randy Dunlap 2022-08-08 6:57 ` Arnd Bergmann 2022-08-08 6:57 ` Arnd Bergmann 2022-08-13 17:03 ` Conor.Dooley [this message] 2022-08-13 17:03 ` Conor.Dooley 2022-08-13 17:44 ` Randy Dunlap 2022-08-13 17:44 ` Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=03c5f897-d4e2-8408-6116-ad7619ca385d@microchip.com \ --to=conor.dooley@microchip.com \ --cc=akpm@linux-foundation.org \ --cc=aou@eecs.berkeley.edu \ --cc=arnd@arndb.de \ --cc=josh@joshtriplett.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.