From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 11/12] iwlwifi: pcie: remove TR/CR tail allocations
Date: Thu, 17 Jun 2021 09:43:09 +0200 [thread overview]
Message-ID: <03ef297b35b87ed8f3c111cf7e67592b1c8e29a9.camel@sipsolutions.net> (raw)
In-Reply-To: <iwlwifi.20210617100544.b5c639f3866f.I4d5de1929be048085767f1234a1e07b517ab6a2d@changeid> (sfid-20210617_091102_610763_E92F4BD5)
On Thu, 2021-06-17 at 10:08 +0300, Luca Coelho wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The TR/CR tail data are meant to be per-queue-arrays, however,
> we allocate them completely wrong (we have a separate allocation
> per queue).
>
> Looking at this more closely, it turns out that the hardware
> never uses these - we have a separate free list per RX queue
> and maintain a write pointer for that in a register, and the
> RX itself is indicated in the RB status (rb_stts) DMA region.
>
> Therefore, remove the TR/CR tail allocations completely.
I guess you should've updated the commit message when squashing in the
fix here - we do need to give it dummy pointers, and the hardware *does*
use them, just for no relevant purpose :)
johannes
next prev parent reply other threads:[~2021-06-17 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 7:08 [PATCH 00/12] iwlwifi: updates intended for v5.14 2021-06-17 Luca Coelho
2021-06-17 7:08 ` [PATCH 01/12] iwlwifi: pcie: identify the RF module Luca Coelho
2021-06-17 7:08 ` [PATCH 02/12] iwlwifi: mvm: don't request SMPS in AP mode Luca Coelho
2021-06-17 7:08 ` [PATCH 03/12] iwlwifi: mvm: apply RX diversity per PHY context Luca Coelho
2021-06-17 7:08 ` [PATCH 04/12] iwlwifi: mvm: honour firmware SMPS requests Luca Coelho
2021-06-17 7:08 ` [PATCH 05/12] iwlwifi: mvm: fix error print when session protection ends Luca Coelho
2021-06-17 7:08 ` [PATCH 06/12] iwlwifi: mvm: Call NMI instead of REPLY_ERROR Luca Coelho
2021-06-17 7:08 ` [PATCH 07/12] iwlwifi: correct HE capabilities Luca Coelho
2021-06-17 7:08 ` [PATCH 08/12] iwlwifi: mvm: support LMR feedback Luca Coelho
2021-06-17 7:08 ` [PATCH 09/12] iwlwifi: advertise broadcast TWT support Luca Coelho
2021-06-22 12:19 ` Luca Coelho
2021-06-17 7:08 ` [PATCH 10/12] iwlwifi: pcie: fix some kernel-doc comments Luca Coelho
2021-06-17 7:08 ` [PATCH 11/12] iwlwifi: pcie: remove TR/CR tail allocations Luca Coelho
2021-06-17 7:43 ` Johannes Berg [this message]
2021-06-17 8:07 ` [PATCH v2 " Luca Coelho
2021-06-22 12:20 ` Luca Coelho
2021-06-17 7:08 ` [PATCH 12/12] iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap Luca Coelho
2021-06-22 12:21 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ef297b35b87ed8f3c111cf7e67592b1c8e29a9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.