From: "David.Wu" <david.wu@rock-chips.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: thierry.reding@gmail.com, heiko@sntech.de, robh+dt@kernel.org,
catalin.marinas@arm.com, briannorris@chromium.org,
dianders@chromium.org, mark.rutland@arm.com,
huangtao@rock-chips.com, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328
Date: Tue, 4 Jul 2017 15:37:54 +0800 [thread overview]
Message-ID: <05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com> (raw)
In-Reply-To: <20170703203957.03f3d1db@bbrezillon>
Hi Boris,
在 2017/7/4 2:39, Boris Brezillon 写道:
> Yet another customization. Don't you think we can extract common parts,
> expose them as helpers and then have 3 different pwm_ops (with 3
> different ->apply() implementation), one for each IP revision.
Sounds reasonable.I will try to implement 3 different apply().
WARNING: multiple messages have this Message-ID (diff)
From: david.wu@rock-chips.com (David.Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328
Date: Tue, 4 Jul 2017 15:37:54 +0800 [thread overview]
Message-ID: <05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com> (raw)
In-Reply-To: <20170703203957.03f3d1db@bbrezillon>
Hi Boris,
? 2017/7/4 2:39, Boris Brezillon ??:
> Yet another customization. Don't you think we can extract common parts,
> expose them as helpers and then have 3 different pwm_ops (with 3
> different ->apply() implementation), one for each IP revision.
Sounds reasonable.I will try to implement 3 different apply().
next prev parent reply other threads:[~2017-07-04 7:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 12:27 [PATCH 0/5] Add rk3328 pwm support David Wu
2017-06-29 12:27 ` David Wu
2017-06-29 12:27 ` David Wu
2017-06-29 12:27 ` [PATCH 1/5] pwm: rockchip: Add APB and function both clocks support David Wu
2017-06-29 12:27 ` David Wu
2017-06-29 12:27 ` David Wu
2017-07-06 17:12 ` Rob Herring
2017-07-06 17:12 ` Rob Herring
2017-07-06 17:12 ` Rob Herring
2017-06-29 12:27 ` [PATCH 2/5] pwm: rockchip: Remove the judge from return value of rockchip_pwm_config() David Wu
2017-06-29 12:27 ` David Wu
2017-07-03 18:31 ` Boris Brezillon
2017-07-03 18:31 ` Boris Brezillon
2017-06-29 12:27 ` [PATCH 3/5] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config() David Wu
2017-06-29 12:27 ` David Wu
2017-06-29 12:27 ` David Wu
2017-07-03 18:36 ` Boris Brezillon
2017-07-03 18:36 ` Boris Brezillon
2017-07-03 18:36 ` Boris Brezillon
2017-07-04 6:46 ` David.Wu
2017-07-04 6:46 ` David.Wu
2017-06-29 12:27 ` [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 David Wu
2017-06-29 12:27 ` David Wu
2017-07-03 18:39 ` Boris Brezillon
2017-07-03 18:39 ` Boris Brezillon
2017-07-04 7:37 ` David.Wu [this message]
2017-07-04 7:37 ` David.Wu
2017-07-06 17:17 ` Rob Herring
2017-07-06 17:17 ` Rob Herring
2017-06-29 12:34 ` [PATCH 5/5] Arm64: dts: rockchip: Add pwm nodes " David Wu
2017-06-29 12:34 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com \
--to=david.wu@rock-chips.com \
--cc=boris.brezillon@free-electrons.com \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.