All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tiantao (H)" <tiantao6@hisilicon.com>
To: "tiantao (H)" <tiantao6@hisilicon.com>,
	"Chenfeng (puck)" <puck.chen@hisilicon.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"kraxel@redhat.com" <kraxel@redhat.com>,
	"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"xinliang.liu@linaro.org" <xinliang.liu@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Linuxarm <linuxarm@huawei.com>
Subject: 答复: [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver
Date: Fri, 6 Mar 2020 03:58:53 +0000	[thread overview]
Message-ID: <063d5262b6f7401bb9a0bb2a52a123b2@hisilicon.com> (raw)
In-Reply-To: <1583466184-7060-2-git-send-email-tiantao6@hisilicon.com>

Hi All:

	Sorry,please  ignore this patch.

Best

-----邮件原件-----
发件人: Linuxarm [mailto:linuxarm-bounces@huawei.com] 代表 Tian Tao
发送时间: 2020年3月6日 11:43
收件人: Chenfeng (puck) <puck.chen@hisilicon.com>; airlied@linux.ie; daniel@ffwll.ch; tzimmermann@suse.de; kraxel@redhat.com; alexander.deucher@amd.com; tglx@linutronix.de; dri-devel@lists.freedesktop.org; xinliang.liu@linaro.org; linux-kernel@vger.kernel.org
抄送: Linuxarm <linuxarm@huawei.com>
主题: [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver

add the shutdown function to release the resource.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 51f1c70..0e58455d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -357,9 +357,14 @@ static void hibmc_pci_remove(struct pci_dev *pdev)  {
 	struct drm_device *dev = pci_get_drvdata(pdev);
 
-	drm_dev_unregister(dev);
-	hibmc_unload(dev);
 	drm_dev_put(dev);
+	pci_disable_device(pdev);
+
+}
+
+static void hibmc_pci_shutdown(struct pci_dev *pdev) {
+	hibmc_pci_remove(pdev);
 }
 
 static struct pci_device_id hibmc_pci_table[] = { @@ -372,6 +377,7 @@ static struct pci_driver hibmc_pci_driver = {
 	.id_table =	hibmc_pci_table,
 	.probe =	hibmc_pci_probe,
 	.remove =	hibmc_pci_remove,
+	.shutdown = hibmc_pci_shutdown,
 	.driver.pm =    &hibmc_pm_ops,
 };
 
--
2.7.4

_______________________________________________
Linuxarm mailing list
Linuxarm@huawei.com
http://hulk.huawei.com/mailman/listinfo/linuxarm

WARNING: multiple messages have this Message-ID (diff)
From: "tiantao (H)" <tiantao6@hisilicon.com>
To: "tiantao (H)" <tiantao6@hisilicon.com>,
	"Chenfeng (puck)" <puck.chen@hisilicon.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"kraxel@redhat.com" <kraxel@redhat.com>,
	"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"xinliang.liu@linaro.org" <xinliang.liu@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Linuxarm <linuxarm@huawei.com>
Subject: 答复: [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver
Date: Fri, 6 Mar 2020 03:58:53 +0000	[thread overview]
Message-ID: <063d5262b6f7401bb9a0bb2a52a123b2@hisilicon.com> (raw)
In-Reply-To: <1583466184-7060-2-git-send-email-tiantao6@hisilicon.com>

Hi All:

	Sorry,please  ignore this patch.

Best

-----邮件原件-----
发件人: Linuxarm [mailto:linuxarm-bounces@huawei.com] 代表 Tian Tao
发送时间: 2020年3月6日 11:43
收件人: Chenfeng (puck) <puck.chen@hisilicon.com>; airlied@linux.ie; daniel@ffwll.ch; tzimmermann@suse.de; kraxel@redhat.com; alexander.deucher@amd.com; tglx@linutronix.de; dri-devel@lists.freedesktop.org; xinliang.liu@linaro.org; linux-kernel@vger.kernel.org
抄送: Linuxarm <linuxarm@huawei.com>
主题: [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver

add the shutdown function to release the resource.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 51f1c70..0e58455d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -357,9 +357,14 @@ static void hibmc_pci_remove(struct pci_dev *pdev)  {
 	struct drm_device *dev = pci_get_drvdata(pdev);
 
-	drm_dev_unregister(dev);
-	hibmc_unload(dev);
 	drm_dev_put(dev);
+	pci_disable_device(pdev);
+
+}
+
+static void hibmc_pci_shutdown(struct pci_dev *pdev) {
+	hibmc_pci_remove(pdev);
 }
 
 static struct pci_device_id hibmc_pci_table[] = { @@ -372,6 +377,7 @@ static struct pci_driver hibmc_pci_driver = {
 	.id_table =	hibmc_pci_table,
 	.probe =	hibmc_pci_probe,
 	.remove =	hibmc_pci_remove,
+	.shutdown = hibmc_pci_shutdown,
 	.driver.pm =    &hibmc_pm_ops,
 };
 
--
2.7.4

_______________________________________________
Linuxarm mailing list
Linuxarm@huawei.com
http://hulk.huawei.com/mailman/listinfo/linuxarm
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-03-06  3:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06  3:42 [PATCH] drm/hisilicon: Add the load and unload for hibmc_driver Tian Tao
2020-03-06  3:42 ` Tian Tao
2020-03-06  3:42 ` [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver Tian Tao
2020-03-06  3:42   ` Tian Tao
2020-03-06  3:58   ` tiantao (H) [this message]
2020-03-06  3:58     ` 答复: " tiantao (H)
2020-03-06  3:43 ` [PATCH] drm/hisilicon: Code cleanup for hibmc_drv_vdac Tian Tao
2020-03-06  3:43   ` Tian Tao
2020-03-06  3:59   ` 答复: " tiantao (H)
2020-03-06  3:59     ` tiantao (H)
2020-03-06  3:43 ` [PATCH 1/4] drm/hisilicon: Enforce 128-byte stride alignment to fix the hardware limitation Tian Tao
2020-03-06  3:43   ` Tian Tao
2020-04-03  2:00   ` Xinliang Liu
2020-04-03  2:00     ` Xinliang Liu
2020-03-06  3:43 ` [PATCH 2/4] drm/hisilicon: Code cleanup for hibmc_drv_vdac Tian Tao
2020-03-06  3:43   ` Tian Tao
2020-04-03  2:26   ` Xinliang Liu
2020-04-03  2:26     ` Xinliang Liu
2020-04-03  7:00     ` Thomas Zimmermann
2020-04-03  7:00       ` Thomas Zimmermann
2020-03-06  3:43 ` [PATCH 3/4] drm/hisilicon: Add the load and unload for hibmc_driver Tian Tao
2020-03-06  3:43   ` Tian Tao
2020-03-06  3:43 ` [PATCH 4/4] drm/hisilicon: Add the shutdown for hibmc_pci_driver Tian Tao
2020-03-06  3:43   ` Tian Tao
2020-03-06  3:59 ` 答复: [PATCH] drm/hisilicon: Add the load and unload for hibmc_driver tiantao (H)
2020-03-06  3:59   ` tiantao (H)
2020-03-06  7:24 ` Thomas Zimmermann
2020-03-06  7:24   ` Thomas Zimmermann
2020-03-06  9:11 ` kbuild test robot
2020-03-06  9:11   ` kbuild test robot
2020-03-06  9:11   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063d5262b6f7401bb9a0bb2a52a123b2@hisilicon.com \
    --to=tiantao6@hisilicon.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=puck.chen@hisilicon.com \
    --cc=tglx@linutronix.de \
    --cc=tzimmermann@suse.de \
    --cc=xinliang.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.