From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support
Date: Thu, 21 Apr 2022 12:33:55 +0200 [thread overview]
Message-ID: <068165d5-6c25-2a65-0191-957b6b1d0680@collabora.com> (raw)
In-Reply-To: <20220415153629.1817202-8-fparent@baylibre.com>
Il 15/04/22 17:36, Fabien Parent ha scritto:
> Add node for the MT6359 PMIC keyboard in mt6359.dtsi.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Hello Fabien,
I agree that all MT6359 PMICs do support pmic-keys, but not all devices using
this PMIC have physical keys connected to that.
Besides, even if all of them did, it wouldn't be guaranteed that key-0 would be
always KEY_POWER, as much as it wouldn't be guaranteed that key-1 would be always
KEY_HOME.
In my opinion, it *is* correct to add mediatek,mt6359-keys to the PMIC dtsi, but
you should do that without declaring any key, hence it's enough to do:
mt6359_keys: mtk-pmic-keys {
compatible = "mediatek,mt6359-keys";
};
... then, any machine that *actually does* have these keys connected and manageable
in Linux should declare its own keys in its own dts/dtsi.
Of course, this means that you'll have to remove your input.h inclusion as well.
Regards,
Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support
Date: Thu, 21 Apr 2022 12:33:55 +0200 [thread overview]
Message-ID: <068165d5-6c25-2a65-0191-957b6b1d0680@collabora.com> (raw)
In-Reply-To: <20220415153629.1817202-8-fparent@baylibre.com>
Il 15/04/22 17:36, Fabien Parent ha scritto:
> Add node for the MT6359 PMIC keyboard in mt6359.dtsi.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Hello Fabien,
I agree that all MT6359 PMICs do support pmic-keys, but not all devices using
this PMIC have physical keys connected to that.
Besides, even if all of them did, it wouldn't be guaranteed that key-0 would be
always KEY_POWER, as much as it wouldn't be guaranteed that key-1 would be always
KEY_HOME.
In my opinion, it *is* correct to add mediatek,mt6359-keys to the PMIC dtsi, but
you should do that without declaring any key, hence it's enough to do:
mt6359_keys: mtk-pmic-keys {
compatible = "mediatek,mt6359-keys";
};
... then, any machine that *actually does* have these keys connected and manageable
in Linux should declare its own keys in its own dts/dtsi.
Of course, this means that you'll have to remove your input.h inclusion as well.
Regards,
Angelo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support
Date: Thu, 21 Apr 2022 12:33:55 +0200 [thread overview]
Message-ID: <068165d5-6c25-2a65-0191-957b6b1d0680@collabora.com> (raw)
In-Reply-To: <20220415153629.1817202-8-fparent@baylibre.com>
Il 15/04/22 17:36, Fabien Parent ha scritto:
> Add node for the MT6359 PMIC keyboard in mt6359.dtsi.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Hello Fabien,
I agree that all MT6359 PMICs do support pmic-keys, but not all devices using
this PMIC have physical keys connected to that.
Besides, even if all of them did, it wouldn't be guaranteed that key-0 would be
always KEY_POWER, as much as it wouldn't be guaranteed that key-1 would be always
KEY_HOME.
In my opinion, it *is* correct to add mediatek,mt6359-keys to the PMIC dtsi, but
you should do that without declaring any key, hence it's enough to do:
mt6359_keys: mtk-pmic-keys {
compatible = "mediatek,mt6359-keys";
};
... then, any machine that *actually does* have these keys connected and manageable
in Linux should declare its own keys in its own dts/dtsi.
Of course, this means that you'll have to remove your input.h inclusion as well.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-21 10:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 15:36 [PATCH 0/7] Input: mtk-pmic-keys: Add support for MT6359 PMIC Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` [PATCH 1/7] dt-bindings: input: mtk-pmic-keys: add MT6359 binding definition Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` [PATCH 2/7] mfd: add missing defines necessary for mtk-pmic-keys support Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-26 14:14 ` Lee Jones
2022-04-26 14:14 ` Lee Jones
2022-04-26 14:14 ` Lee Jones
2022-04-15 15:36 ` [PATCH 3/7] mfd: mt6397-core: add resources for PMIC keys for MT6359 Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-26 14:14 ` Lee Jones
2022-04-26 14:14 ` Lee Jones
2022-04-26 14:14 ` Lee Jones
2022-04-15 15:36 ` [PATCH 4/7] Input: mtk-pmic-keys: rename platform data struct Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-21 15:56 ` Mattijs Korpershoek
2022-04-21 15:56 ` Mattijs Korpershoek
2022-04-21 15:56 ` Mattijs Korpershoek
2022-04-15 15:36 ` [PATCH 5/7] Input: mtk-pmic-keys: add field to store if PMIC has key release IRQs Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-21 15:57 ` Mattijs Korpershoek
2022-04-21 15:57 ` Mattijs Korpershoek
2022-04-21 15:57 ` Mattijs Korpershoek
2022-04-15 15:36 ` [PATCH 6/7] Input: keyboard: mtk-pmic-keys: add support for MT6359 Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-15 15:36 ` Fabien Parent
2022-04-21 10:33 ` AngeloGioacchino Del Regno [this message]
2022-04-21 10:33 ` AngeloGioacchino Del Regno
2022-04-21 10:33 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=068165d5-6c25-2a65-0191-957b6b1d0680@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.