From: Suman Anna <s-anna@ti.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
David Lechner <david@lechnology.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-remoteproc@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 6/8] remoteproc: da8xx: prepare and unprepare the clock where needed
Date: Mon, 26 Mar 2018 16:19:33 -0500 [thread overview]
Message-ID: <07c2258c-b4ca-5dd6-0a9b-47c5a3fac826@ti.com> (raw)
In-Reply-To: <20180323130455.11470-7-brgl@bgdev.pl>
On 03/23/2018 08:04 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We're currently switching the platform to using the common clock
> framework. We need to explicitly prepare and unprepare the rproc
> clock.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
FWIW, I have been able to use this patch even without the CCF adaptation
as clk_prepare()/clk_unprepare() are stubs returning 0, and the
effective code would be same as before. Prefer "remoteproc/davinci: ..."
on the patch subject as was being done previously.
With that,
Acked-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 2b24291337b7..f134192922e0 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -149,9 +149,9 @@ static int da8xx_rproc_start(struct rproc *rproc)
>
> writel(rproc->bootaddr, drproc->bootreg);
>
> - ret = clk_enable(dsp_clk);
> + ret = clk_prepare_enable(dsp_clk);
> if (ret) {
> - dev_err(dev, "clk_enable() failed: %d\n", ret);
> + dev_err(dev, "clk_prepare_enable() failed: %d\n", ret);
> return ret;
> }
>
> @@ -165,7 +165,7 @@ static int da8xx_rproc_stop(struct rproc *rproc)
> struct da8xx_rproc *drproc = rproc->priv;
>
> davinci_clk_reset_assert(drproc->dsp_clk);
> - clk_disable(drproc->dsp_clk);
> + clk_disable_unprepare(drproc->dsp_clk);
>
> return 0;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
David Lechner <david@lechnology.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 6/8] remoteproc: da8xx: prepare and unprepare the clock where needed
Date: Mon, 26 Mar 2018 16:19:33 -0500 [thread overview]
Message-ID: <07c2258c-b4ca-5dd6-0a9b-47c5a3fac826@ti.com> (raw)
In-Reply-To: <20180323130455.11470-7-brgl@bgdev.pl>
On 03/23/2018 08:04 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We're currently switching the platform to using the common clock
> framework. We need to explicitly prepare and unprepare the rproc
> clock.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
FWIW, I have been able to use this patch even without the CCF adaptation
as clk_prepare()/clk_unprepare() are stubs returning 0, and the
effective code would be same as before. Prefer "remoteproc/davinci: ..."
on the patch subject as was being done previously.
With that,
Acked-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 2b24291337b7..f134192922e0 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -149,9 +149,9 @@ static int da8xx_rproc_start(struct rproc *rproc)
>
> writel(rproc->bootaddr, drproc->bootreg);
>
> - ret = clk_enable(dsp_clk);
> + ret = clk_prepare_enable(dsp_clk);
> if (ret) {
> - dev_err(dev, "clk_enable() failed: %d\n", ret);
> + dev_err(dev, "clk_prepare_enable() failed: %d\n", ret);
> return ret;
> }
>
> @@ -165,7 +165,7 @@ static int da8xx_rproc_stop(struct rproc *rproc)
> struct da8xx_rproc *drproc = rproc->priv;
>
> davinci_clk_reset_assert(drproc->dsp_clk);
> - clk_disable(drproc->dsp_clk);
> + clk_disable_unprepare(drproc->dsp_clk);
>
> return 0;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
David Lechner <david@lechnology.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 6/8] remoteproc: da8xx: prepare and unprepare the clock where needed
Date: Mon, 26 Mar 2018 16:19:33 -0500 [thread overview]
Message-ID: <07c2258c-b4ca-5dd6-0a9b-47c5a3fac826@ti.com> (raw)
In-Reply-To: <20180323130455.11470-7-brgl@bgdev.pl>
On 03/23/2018 08:04 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We're currently switching the platform to using the common clock
> framework. We need to explicitly prepare and unprepare the rproc
> clock.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
FWIW, I have been able to use this patch even without the CCF adaptation
as clk_prepare()/clk_unprepare() are stubs returning 0, and the
effective code would be same as before. Prefer "remoteproc/davinci: ..."
on the patch subject as was being done previously.
With that,
Acked-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 2b24291337b7..f134192922e0 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -149,9 +149,9 @@ static int da8xx_rproc_start(struct rproc *rproc)
>
> writel(rproc->bootaddr, drproc->bootreg);
>
> - ret = clk_enable(dsp_clk);
> + ret = clk_prepare_enable(dsp_clk);
> if (ret) {
> - dev_err(dev, "clk_enable() failed: %d\n", ret);
> + dev_err(dev, "clk_prepare_enable() failed: %d\n", ret);
> return ret;
> }
>
> @@ -165,7 +165,7 @@ static int da8xx_rproc_stop(struct rproc *rproc)
> struct da8xx_rproc *drproc = rproc->priv;
>
> davinci_clk_reset_assert(drproc->dsp_clk);
> - clk_disable(drproc->dsp_clk);
> + clk_disable_unprepare(drproc->dsp_clk);
>
> return 0;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: s-anna@ti.com (Suman Anna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/8] remoteproc: da8xx: prepare and unprepare the clock where needed
Date: Mon, 26 Mar 2018 16:19:33 -0500 [thread overview]
Message-ID: <07c2258c-b4ca-5dd6-0a9b-47c5a3fac826@ti.com> (raw)
In-Reply-To: <20180323130455.11470-7-brgl@bgdev.pl>
On 03/23/2018 08:04 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We're currently switching the platform to using the common clock
> framework. We need to explicitly prepare and unprepare the rproc
> clock.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
FWIW, I have been able to use this patch even without the CCF adaptation
as clk_prepare()/clk_unprepare() are stubs returning 0, and the
effective code would be same as before. Prefer "remoteproc/davinci: ..."
on the patch subject as was being done previously.
With that,
Acked-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 2b24291337b7..f134192922e0 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -149,9 +149,9 @@ static int da8xx_rproc_start(struct rproc *rproc)
>
> writel(rproc->bootaddr, drproc->bootreg);
>
> - ret = clk_enable(dsp_clk);
> + ret = clk_prepare_enable(dsp_clk);
> if (ret) {
> - dev_err(dev, "clk_enable() failed: %d\n", ret);
> + dev_err(dev, "clk_prepare_enable() failed: %d\n", ret);
> return ret;
> }
>
> @@ -165,7 +165,7 @@ static int da8xx_rproc_stop(struct rproc *rproc)
> struct da8xx_rproc *drproc = rproc->priv;
>
> davinci_clk_reset_assert(drproc->dsp_clk);
> - clk_disable(drproc->dsp_clk);
> + clk_disable_unprepare(drproc->dsp_clk);
>
> return 0;
> }
>
next prev parent reply other threads:[~2018-03-26 21:19 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 13:04 [PATCH v4 0/8] ARM: davinci: complete the conversion to using the reset framework Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 13:04 ` [PATCH v4 1/8] reset: modify the way reset lookup works for board files Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 13:43 ` Philipp Zabel
2018-03-23 13:43 ` Philipp Zabel
2018-03-23 13:43 ` Philipp Zabel
2018-03-23 13:46 ` Bartosz Golaszewski
2018-03-23 13:46 ` Bartosz Golaszewski
2018-03-23 13:04 ` [PATCH v4 2/8] ARM: davinci: dts: make psc0 a reset provider Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 13:04 ` [PATCH v4 3/8] ARM: davinci: dts: add a reset control to the dsp node Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 13:04 ` [PATCH v4 4/8] clk: davinci: add a reset lookup table for psc0 Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 13:04 ` [PATCH v4 5/8] remoteproc: da8xx: add the missing retval check for clk_enable() Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-26 21:15 ` Suman Anna
2018-03-26 21:15 ` Suman Anna
2018-03-26 21:15 ` Suman Anna
2018-03-23 13:04 ` [PATCH v4 6/8] remoteproc: da8xx: prepare and unprepare the clock where needed Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-26 21:19 ` Suman Anna [this message]
2018-03-26 21:19 ` Suman Anna
2018-03-26 21:19 ` Suman Anna
2018-03-26 21:19 ` Suman Anna
2018-03-23 13:04 ` [PATCH v4 7/8] remoteproc: da8xx: use the reset framework Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-26 21:28 ` Suman Anna
2018-03-26 21:28 ` Suman Anna
2018-03-26 21:28 ` Suman Anna
2018-03-23 13:04 ` [PATCH v4 8/8] clk: davinci: kill davinci_clk_reset_assert/deassert() Bartosz Golaszewski
2018-03-23 13:04 ` Bartosz Golaszewski
2018-03-23 16:49 ` [PATCH v4 0/8] ARM: davinci: complete the conversion to using the reset framework Stephen Boyd
2018-03-23 16:49 ` Stephen Boyd
2018-03-23 16:49 ` Stephen Boyd
2018-03-23 16:55 ` Bartosz Golaszewski
2018-03-23 16:55 ` Bartosz Golaszewski
2018-03-23 17:08 ` Stephen Boyd
2018-03-23 17:08 ` Stephen Boyd
2018-03-23 17:08 ` Stephen Boyd
2018-03-23 17:16 ` Bartosz Golaszewski
2018-03-23 17:16 ` Bartosz Golaszewski
2018-03-24 0:30 ` Suman Anna
2018-03-24 0:30 ` Suman Anna
2018-03-24 0:30 ` Suman Anna
2018-03-24 0:30 ` Suman Anna
2018-03-27 0:42 ` Suman Anna
2018-03-27 0:42 ` Suman Anna
2018-03-27 0:42 ` Suman Anna
2018-03-27 0:42 ` Suman Anna
2018-03-27 5:24 ` Sekhar Nori
2018-03-27 5:24 ` Sekhar Nori
2018-03-27 5:24 ` Sekhar Nori
2018-03-27 5:24 ` Sekhar Nori
2018-03-28 22:44 ` Suman Anna
2018-03-28 22:44 ` Suman Anna
2018-03-28 22:44 ` Suman Anna
2018-03-27 6:09 ` Sekhar Nori
2018-03-27 6:09 ` Sekhar Nori
2018-03-27 6:09 ` Sekhar Nori
2018-03-27 6:09 ` Sekhar Nori
2018-03-27 9:23 ` Philipp Zabel
2018-03-27 9:23 ` Philipp Zabel
2018-03-27 9:23 ` Philipp Zabel
2018-03-27 9:29 ` Bartosz Golaszewski
2018-03-27 9:29 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c2258c-b4ca-5dd6-0a9b-47c5a3fac826@ti.com \
--to=s-anna@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=brgl@bgdev.pl \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.