From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfsrahead: fix linking while static linking
Date: Wed, 10 Aug 2022 23:43:43 +0200 [thread overview]
Message-ID: <07d99979-a395-64a9-f051-e400bfefe1ca@benettiengineering.com> (raw)
In-Reply-To: <20220809223308.1421081-1-giulio.benetti@benettiengineering.com>
Hi All,
please drop this patch in favor of upcoming V3. This is not a good way
to use pkg-config with Autotools.
Sorry for the noise
Best regards
--
Giulio Benetti
Benetti Engineering sas
On 10/08/22 00:33, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add:
> `pkg-config --libs mount`
> in place of:
> `-lmount`
> This ways the library order will always be correct.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * modify pkg-conf to pkg-config
> ---
> tools/nfsrahead/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..280a2eb4 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
> libexec_PROGRAMS = nfsrahead
> nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= `pkg-config --libs mount`
> nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>
> man5_MANS = nfsrahead.man
next prev parent reply other threads:[~2022-08-10 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 22:12 [PATCH] nfsrahead: fix linking while static linking Giulio Benetti
2022-08-09 22:23 ` Giulio Benetti
2022-08-09 22:33 ` [PATCH v2] " Giulio Benetti
2022-08-10 21:43 ` Giulio Benetti [this message]
2022-08-10 21:45 ` [PATCH v3] " Giulio Benetti
2022-08-11 20:20 ` Petr Vorel
2022-08-11 20:36 ` Giulio Benetti
2022-08-22 19:17 ` Steve Dickson
2022-08-22 20:33 ` Giulio Benetti
2022-09-13 15:55 ` Steve Dickson
2022-09-13 15:56 ` Petr Vorel
2022-09-13 21:06 ` Giulio Benetti
2022-09-13 17:38 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07d99979-a395-64a9-f051-e400bfefe1ca@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.